October 2022 - Wine-gitlab - list.winehq.org

Re: [PATCH v9 0/1] MR1065: ntdll: Add CFI unwind info to __wine_syscall_dispatcher (x86_64)
by Martin Storsjö 21 Oct '22

21 Oct '22

Martin Storsjö (@mstorsjo) commented about dlls/ntdll/unix/signal_x86_64.c: > - DW_OP_xderef_size = 0x95, > - DW_OP_nop = 0x96, > - DW_OP_push_object_address = 0x97, > - DW_OP_call2 = 0x98, > - DW_OP_call4 = 0x99, > - DW_OP_call_ref = 0x9a, > - DW_OP_form_tls_address = 0x9b, > - DW_OP_call_frame_cfa = 0x9c, > - DW_OP_bit_piece = 0x9d, > - DW_OP_lo_user = 0xe0, > - DW_OP_hi_user = 0xff, > - DW_OP_GNU_push_tls_address = 0xe0, > - DW_OP_GNU_uninit = 0xf0, > - DW_OP_GNU_encoded_addr = 0xf1, > -}; > +#define DW_CFA_advance_loc 0x40 Out of curiosity - was there any specific reason for changing these enums into defines (or was this maybe an artifact from how this patch evolved from earlier forms)? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1065#note_11673

1 0

[PATCH 0/2] MR1133: Get rid of home grown allocator in DbgHelp.
by eric pouech (＠epo) 21 Oct '22

21 Oct '22

Replace DbgHelp's internal memory allocator with heap functions: - slight improvement in speed (~ 1 to 2 %) - ability to reallocate chunks -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1133

3 3

Re: [PATCH v2 0/5] MR1126: Spelling and trailing linefeed fixes.
by Jan Sikorski (＠jsikorski) 21 Oct '22

21 Oct '22

Jan Sikorski (@jsikorski) commented about dlls/dbghelp/dwarf.c: > } > > /* Dwarf tends to keep the structure of the C/C++ program, and emits DW_TAG_lexical_block > - * for every block in source program. > + * for every block the in source program. in the ;) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1126#note_11664

1 0

Re: [PATCH v2 0/1] MR1114: ntdll/tests: Force alignment of output structures.
by eric pouech (＠epo) 21 Oct '22

21 Oct '22

On Thu Oct 20 17:51:23 2022 +0000, **** wrote: > Zebediah Figura replied on the mailing list: > ``` > On 10/20/22 03:54, Eric Pouech wrote: > > From: Eric Pouech <eric.pouech(a)gmail.com> > > > > Some Windows version expect output to be aligned on 4 bytes. > > > > Notes (from i386 and x86_64 tests): > > - MSVC and Mingw/gcc don't layout the two variables (sdki, sdki_ex) > > the same way. > > - MSVC aligns each variable on 4-byte boundary, > > - MingW/GCC stores them in a 8-byte chunk, but starting from the > > end of the buffer: hence none of them is on a 4-byte boundary. > > > > So, fixing the alignment of variables is not sufficient to > > workaround the compilers' discrepancy on all source code. > > > > I didn't find a generic way to align on 4 bytes structures of size > > smaller than 4 bytes (apart from adding the DECLSPEC_ALIGN to > > each of the offending structures, likely not that many though). > > Ideas welcomed. > Should we put those structs in pshpack4/poppack in the header? (They > aren't defined anywhere publicly on Windows, so we can't compare there.) > ``` from the testbot results, it seems that only W8 and early versions of W10 return errors on pointers not aligned on 4-byte; newer versions of W10 happily handle calls with unaligned pointers so I considered that the "default" is to support non aligned access, but this requires adapting the tests to workaround limitations (not to say bug) in W8/early W10 versions rather than to put it inside the structure declaration -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1114#note_11659

1 0

[PATCH v2 0/1] MR14: include: Add missing types in vkd3d_d3d12.idl.
by Biswapriyo Nath (＠Biswa96) 21 Oct '22

21 Oct '22

-- v2: include: Add missing types in vkd3d_d3d12.idl. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/14

4 7

[PATCH v10 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v10: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v9 0/6] MR1120: Add support for localized functions in msvcrt dlls
by Bartosz Kosiorek (＠gang65) 21 Oct '22

21 Oct '22

-- v9: msvcrt: Add _ismbstrail_l implementation. msvcrt: Add _ismbslead_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1120

3 7

[PATCH v4 0/7] MR871: ntdll: Fill the IOSB only inside the if (alerted) block in multiple functions.
by Zebediah Figura (＠zfigura) 21 Oct '22

21 Oct '22

-- v4: ntdll: Fill the IOSB in sock_transmit() only inside the "if (alerted)" block. ntdll: Combine the "if (alerted)" blocks in sock_send(). ntdll: Fill the IOSB in sock_send() only inside the "if (alerted)" block. ntdll: Combine the "if (alerted)" blocks in sock_recv(). ntdll: Fill the IOSB in sock_recv() only inside the "if (alerted)" block. ntdll: The async handle passed to set_async_direct_result() cannot be NULL. ws2_32/tests: Add more tests for iosb contents while a recv is pending. https://gitlab.winehq.org/wine/wine/-/merge_requests/871

3 8

Re: [PATCH v3 0/1] MR1002: win32u: Fix data race in NtUserGetProcessDpiAwarenessContext. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1002

1 0

Re: [PATCH v2 0/1] MR996: ddraw/tests: Mark tests failing randomly on Windows as flaky. - approved
by Alexandre Julliard (＠julliard) 20 Oct '22

20 Oct '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/996

1 0