October 2022 - Wine-gitlab - list.winehq.org

[PATCH v5 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46012 Signed-off-by: Patrick Hibbs <hibbsncc1701(a)gmail.com> -- v5: d3dx9/tests: Implement tests for d3dx_effect_SetRawValue(). https://gitlab.winehq.org/wine/wine/-/merge_requests/979

3 3

Re: [PATCH v5 0/5] MR944: win32u: Make desktop resize logic asynchronous.
by Rémi Bernon 19 Oct '22

19 Oct '22

On Tue Oct 18 23:34:47 2022 +0000, Rémi Bernon wrote: > The cause of the failure was that we're using incorrect mutex names in > some places for the `display_device_init` mutex. In some unlikely event, > which becomes apparently more likely with the changes here, > `D3DKMTOpenAdapterFromGdiDisplayName` was able to enter the mutex CS at > the same time as the devices are refreshed, and fails to find the video > device in `HKLM\\HARDWARE\\DEVICEMAP\\VIDEO`, returning an error which > ultimately triggers an allocation failure. > This should never happens as the device refresh should also be done > while holding the same mutex, but because the names were wrong it was > two different mutexes. I've opened > https://gitlab.winehq.org/wine/wine/-/merge_requests/1099 to fix this. > This is for the `d3drm` tests failure at least, I didn't look at the > ddraw ones, hopefully it's the same problem. Marvin reported the same `ddraw7` errors in !1099, so they may not be fixed. I'm not able to reproduce them locally so far, using the same kind of setup as Gitlab and running the tests in a loop. These take a longer time, especially as I'm running the other d3d tests with ddraw in case they have an impact, so it's possible I'm simply being unlucky, or that they are somehow only happening on the testbot now. I'll probably stop looking for now and see how things improve with that MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/944#note_11293

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Wed Oct 19 09:30:52 2022 +0000, Patrick Hibbs wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_9206_9250) That was a leftover I missed from a previous iteration of the test. It's been removed in v3 of the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11292

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Wed Oct 19 09:30:34 2022 +0000, Patrick Hibbs wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_9089_9004) The same issue with strings occurs with Texture and shader types. I.e. Paramater is rendered irretrievable. Calling it's relevant GetXXX() function causes a crash if it's a scalar. Calling GetParamaterByName() will return an invalid handle. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11291

1 0

Re: [PATCH v6 0/2] MR979: d3d9: Implement d3dx_effect_SetRawValue
by Patrick Hibbs (＠hibbsncc1701) 19 Oct '22

19 Oct '22

On Wed Oct 19 09:30:33 2022 +0000, Patrick Hibbs wrote: > changed this line in [version 5 of the diff](/wine/wine/-/merge_requests/979/diffs?diff_id=14510&start_sha=9be4873a7477520f0eb74837f2a269f864a9ac13#6af8d13245d87d86339fd93c308f9d2332f22092_9077_9004) Actually it seems that the strings are rendered irretrievable by the call to SetRawValue(). Calling GetString() on a scalar string after the destruction causes a crash in win10. While calling it with a string vector doesn't crash, but returns D3DERR_INVALIDCALL instead. I've updated the tests in v3 of the patch to check for this. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/979#note_11290

1 0

[PATCH v2 0/1] MR970: wined3d: Do not enforce map access for resources with WINED3D_RESOURCE_ACCESS_CPU.
by Zebediah Figura (＠zfigura) 19 Oct '22

19 Oct '22

-- v2: https://gitlab.winehq.org/wine/wine/-/merge_requests/970

4 4

[PATCH v3 0/10] MR966: server: Some fixes for the shared Software\Classes registry.
by Sven Baars (＠sbaars) 19 Oct '22

19 Oct '22

This seems to be more correct than what we previously had with fewer lines of code, so I like that. I still don't really like the extra flag I had to add for Nt{Create,Open}Key, but I couldn't find a way to make things work without it. I also checked that Windows doesn't use a similar flag (by iterating over all bit masks). -- v3: wine.inf: Put the Clients key in the right place. ntdll/tests: Factor out the NtEnumerateKey() tests. kernelbase: Remove special Wow64 handling for HKEY_CLASSES_ROOT. kernelbase: Remove special Wow6432Node handling from RegCreateKeyEx(). kernelbase: Remove special Wow6432Node handling from RegOpenKeyEx(). server: Don't return the actual 32-bit Software\Classes key. ntdll/tests: Add some some Software\Classes query and enumerate tests. ntdll/tests: Test that NtCreateKeyEx() also recursively obtains the Wow6432Node parent. server: Recursively obtain the Wow6432Node parent. https://gitlab.winehq.org/wine/wine/-/merge_requests/966

4 14

[PATCH 0/5] MR1078: mshtml: Initial HTMLDocumentNode / HTMLDocumentObj split.
by Gabriel Ivăncescu 19 Oct '22

19 Oct '22

This is the first in a series of MRs to get rid of the `HTMLDocument` basedoc struct and separate the `HTMLDocumentNode` and `HTMLDocumentObj`, as suggested. The other interfaces and fields will be done in follow-up MRs. It should be a no-op in general. Some of the things are ugly but temporary (e.g. the chunk in `HTMLDocument_put_designMode` on first commit) until the entire transition is done, then they will be cleaned up. For most of the interfaces, they all deal with doc objects in most cases, so the implementation on HTMLDocumentNode tends to just forward to that. There are exceptions of course, but care has been taken to have them mostly no-ops ("mostly" because there's cases where the previous code did not check for e.g. NULL node, so it would crash instead, which is bad and should be fixed now). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1078

3 7

[PATCH v4 0/2] MR1079: wininet/netprofm: Connectivity improvements.
by Gabriel Ivăncescu 19 Oct '22

19 Oct '22

-- v4: netprofm: Handle non-internet connectivity. wininet: Handle offline state in InternetGetConnectedStateExW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1079

3 4

[PATCH 0/2] MR1099: win32u: Use session BaseNamedObjects for display_device_init mutex.
by Rémi Bernon 19 Oct '22

19 Oct '22

The mutex is also used in user32, gdi32, and winevulkan, where it is opened through kernel32, which opens it from the session directory. I believe this will fix the d3drm spurious errors, and hopefully the ddraw ones too, but I haven't investigated these as the test takes much longer to run. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1099

2 4