October 2022 - Wine-gitlab - list.winehq.org

[PATCH 0/4] MR1084: comctl32/tests: Ignore WM_NCPAINT when testing WM_THEMECHANGED for updown control.
by Zhiyi Zhang (＠zhiyi) 18 Oct '22

18 Oct '22

Fix a possible test failure. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1084

4 6

[PATCH 0/1] MR1083: hhctrl.ocx: Fix toolbar icons order
by Stanislav Motylkov (＠binarymaster) 18 Oct '22

18 Oct '22

In `hhtoolbar.bmp` the "Expand" icon comes first, then "Collapse". ![](https://gitlab.winehq.org/wine/wine/-/raw/master/dlls/hhctrl.ocx/hhtoolbar.bmp) External issue link in ReactOS Jira: [CORE-12198](https://jira.reactos.org/browse/CORE-12198) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1083

4 3

[PATCH v10 0/7] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon 18 Oct '22

18 Oct '22

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v10: win32u: Read mode from the registry if GetCurrentDisplaySettings fails. win32u: Write display settings to the registry in apply_display_settings. win32u: Lock display devices while applying display settings. win32u: Use an internal WINE_DM_PRIMARY_DEVICE flag on primary adapter modes. win32u: Remove the device name parameter from GetCurrentDisplaySettings. win32u: Force update display cache after NtUserChangeDisplaySettingsEx. win32u: Add a BOOL force parameter to update_display_cache. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

3 15

[PATCH v6 0/5] MR1080: Draft: msvcrt: implement missing CRT functions to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) 18 Oct '22

18 Oct '22

With this commit the following functions were implemented: - _mbsupr_s_l - converts multibyte string to uppercase, by using specified locale that's passed in. - _mbslwr_s_l - converts multibyte string to lowercase, by using specified locale that's passed in. - _mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. - _mbctoupper_l - converts multibyte lowercase character to uppercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/strupr-s-… After applying the patch the crash of the ChessBase application was fixed. More information: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v6: fix: reintroduce _mbsupr_s_l and _mbctolower_l in msvcr100.spec Revert "fix: temporarly remove new tests" https://gitlab.winehq.org/wine/wine/-/merge_requests/1080

2 5

[PATCH 0/1] MR1085: sapi: Implement ISpObjectToken OpenKey
by Alistair Leslie-Hughes (＠alesliehughes) 18 Oct '22

18 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1085

3 2

[PATCH 0/1] MR1086: include: Add WSANO_ADDRESS to winsock2.h.
by Alex Henrie (＠alexhenrie) 18 Oct '22

18 Oct '22

Needed to compile Tera Term. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1086

3 2

[PATCH 0/1] MR1082: sechost: Set the name of internal threads.
by Brendan Shanks (＠bshanks) 18 Oct '22

18 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1082

3 2

[PATCH v5 0/3] MR1080: Draft: msvcrt: implement missing CRT functions to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) 17 Oct '22

17 Oct '22

With this commit the following functions were implemented: - _mbsupr_s_l - converts multibyte string to uppercase, by using specified locale that's passed in. - _mbslwr_s_l - converts multibyte string to lowercase, by using specified locale that's passed in. - _mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. - _mbctoupper_l - converts multibyte lowercase character to uppercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/strupr-s-… After applying the patch the crash of the ChessBase application was fixed. More information: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v5: revert spec definitions https://gitlab.winehq.org/wine/wine/-/merge_requests/1080

3 4

[PATCH v4 0/2] MR1080: Draft: msvcrt: implement missing CRT functions to fix ChessBase 14 crash
by Bartosz Kosiorek (＠gang65) 17 Oct '22

17 Oct '22

With this commit the following functions were implemented: - _mbsupr_s_l - converts multibyte string to uppercase, by using specified locale that's passed in. - _mbslwr_s_l - converts multibyte string to lowercase, by using specified locale that's passed in. - _mbctolower_l - converts multibyte uppercase character to lowercase character, by using specified locale that's passed in. - _mbctoupper_l - converts multibyte lowercase character to uppercase character, by using specified locale that's passed in. More information about these methods are available at: https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/strupr-s-… After applying the patch the crash of the ChessBase application was fixed. More information: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v4: fix: temporarly remove new tests msvcrt: implement missing CRT functions to fix ChessBase 14 crash https://gitlab.winehq.org/wine/wine/-/merge_requests/1080

3 3

[PATCH 0/2] MR1081: win32u: Reject invalid length in SetWindowPlacement.
by Esme Povirk (＠madewokherd) 17 Oct '22

17 Oct '22

This change has been in Proton to fix a bug in the DayZ launcher. The launcher is a .NET application that, best I can tell, contains marshaling code that calls SetWindowPlacement incorrectly. This results in undefined memory being passed in and broken values returned by GetWindowPlacement. I think the value passed in must be broken on Windows, but as the tests show, Windows rejects SetWindowPlacement calls that don't have length set correctly (but not GetWindowPlacement, as zeroing the structure to give it an invalid length in `other_process_proc` shows). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1081

3 4