November 2022 - Wine-gitlab

[PATCH 0/1] MR1565: wldap32: Use the strdup function instead of reimplementing it.
by Alex Henrie (＠alexhenrie) 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1565

3 2

[PATCH 0/12] MR1570: joy.cpl: Refactoring and fixes to prevent crash on exit.
by Rémi Bernon 28 Nov '22

28 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1570

1 12

[PATCH 0/1] MR1568: winex11.drv: Support _KDE_NET_WM_STATE_SKIP_SWITCHER.
by Zhiyi Zhang (＠zhiyi) 28 Nov '22

28 Nov '22

KWin has a switcher that triggered by Alt+Tab that basically acts like a pager. And hiding items in the switcher is controlled by _KDE_NET_WM_STATE_SKIP_SWITCHER. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1568

2 1

[PATCH v4 0/4] MR566: shell32: Implement SHBindToFolderIDListParent.
by Mohamad Al-Jaf (＠maljaf) 28 Nov '22

28 Nov '22

Called by IE11. Signed-off-by: Mohamad Al-Jaf <mohamadaljaf(a)gmail.com> v3: Fix failed test. Don't know how to change the subject version number. -- v4: shell32/tests: Add SHBindToFolderIDListParent tests. shell32: Implement SHBindToFolderIDListParent. shell32: Fix error handling in SHBindToParent. shell32/tests: Test SHBindToParent last parameter behavior. https://gitlab.winehq.org/wine/wine/-/merge_requests/566

3 8

[PATCH v2 0/4] MR1554: win32u: Reset focused item when removing menu item
by Vladislav Timonin (＠vt) 27 Nov '22

27 Nov '22

Fixes an out of bounds access in `show_popup`. ```c if (menu->FocusedItem != NO_SELECTED_ITEM) { menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); // <- can crash here menu->FocusedItem = NO_SELECTED_ITEM; } ``` Menu resets focused item on show, not on close. If items were later deleted, next time user opens the menu, menu can crash on out of bounds access and won't show up again, as menu thinks it's still on screen. In other words: - open split button dropdown - click on any item - clear dropdown items - open dropdown again Menu borked and won't open again. Source for the testing app for reproduction. [test.c](/uploads/2f703f63891b33e1a0eb0fcd27c912b7/test.c) I guess, the alternative is to reset focused item when menu is closed, but not sure where's the best place to do that, haven't dug deep enough. -- v2: win32u: Reset focused item when removing menu item win32u: Allow (de)select_item to work with off-screen menus win32u: Add deselect to HiliteMenuItem win32u: Return FALSE in HiliteMenuItem when window handle is NULL https://gitlab.winehq.org/wine/wine/-/merge_requests/1554

3 7

[PATCH 0/2] MR1557: localspl: Add FILE: port monitor implementation
by Piotr Caban (＠piotr) 27 Nov '22

27 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1557

4 4

[PATCH v6 0/3] MR1199: xmllite/writer : Implement a few APIs
by David Kahurani (＠kahurani) 27 Nov '22

27 Nov '22

Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v6: xmllite/writer: Implement WriteSurrogateCharEntity. xmllite/writer: Implement WriteRawChars. xmllite/writer: Implement WriteChars. https://gitlab.winehq.org/wine/wine/-/merge_requests/1199

4 6

[PATCH v5 0/1] MR1522: mfmediaengine: Volume change.
by Bernhard Kölbl 27 Nov '22

27 Nov '22

-- v5: mfmediaengine: Pass volume changes to media session. https://gitlab.winehq.org/wine/wine/-/merge_requests/1522

2 3

[PATCH 0/1] MR1556: d3dcompiler: Implement D3DDisassemble() using vkd3d-shader.
by Nikolay Sivov (＠nsivov) 27 Nov '22

27 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=46649 Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1556

2 1

[PATCH 0/4] MR51: vkd3d-shader/hlsl: Improve constant handling in copy prop, and extend the use of aoffimmi modifiers.
by Francisco Casas (＠fcasas) 27 Nov '22

27 Nov '22

If a hlsl_ir_load loads a variable whose components are stored from different instructions, copy propagation doesn't replace it. But if all these instructions are constants (which currently is the case for value constructors), the load can be replaced with a constant value, which is what the first patch of this series does. For instance, this shader: ``` sampler s; Texture2D t; float4 main() : sv_target { return t.Gather(s, float2(0.6, 0.6), int2(0, 0)); } ``` results in the following IR before applying the patch: ``` float | 6.00000024e-01 float | 6.00000024e-01 uint | 0 | = (<constructor-2>[@4].x @2) uint | 1 | = (<constructor-2>[@6].x @3) float2 | <constructor-2> int | 0 int | 0 uint | 0 | = (<constructor-5>[@11].x @9) uint | 1 | = (<constructor-5>[@13].x @10) int2 | <constructor-5> float4 | gather_red(resource = t, sampler = s, coords = @8, offset = @15) | return | = (<output-sv_target0> @16) ``` and this IR afterwards: ``` float2 | {6.00000024e-01 6.00000024e-01 } int2 | {0 0 } float4 | gather_red(resource = t, sampler = s, coords = @2, offset = @3) | return | = (<output-sv_target0> @4) ``` This is required to write texel_offsets as aoffimmi modifiers in the sm4 backend, since it expects the texel_offset arguments to be hlsl_ir_constant. This series also: * Allows Gather() methods to use aoffimmi modifiers instead of an additional source register (which is the only way allowed for shader model 4.1), when possible. * Adds support to texel_offsets in the Load() method via aoffimmi modifiers (the only allowed method). -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/51

4 19