November 2022 - Wine-gitlab

[PATCH v4 0/5] MR1278: winegstreamer: Do not destroy condition variables when a thread is waiting on them.
by Giovanni Mascellani (＠giomasce) 23 Nov '22

23 Nov '22

It is possible that a stream is destroyed while another thread is waiting on event_empty_cond or event_cond. The waiting thread should have the opportunity to be rescheduled and exit the critical section before the condition variables and the mutex are destroyed. -- v4: winegstreamer: Synchronize media source async commands and shutdown. winegstreamer: Free the GStreamer buffer when freeing a WG parser stream. winegstreamer: Synchronize access to the media source from callbacks. winegstreamer: Synchronize concurrent access to the media stream. winegstreamer: Synchronize concurrent access to the media source. https://gitlab.winehq.org/wine/wine/-/merge_requests/1278

3 9

[PATCH v2 0/2] MR1522: mfmediaengine: Volume change.
by Bernhard Kölbl 23 Nov '22

23 Nov '22

-- v2: mfmediaengine: Pass volume changes to the audio renderer. https://gitlab.winehq.org/wine/wine/-/merge_requests/1522

2 3

[PATCH 0/1] MR1515: urlmon: Use standard C functions for memory allocation.
by Alex Henrie (＠alexhenrie) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1515

3 2

[PATCH 0/6] MR1506: jscript: Pass correct 'this' to callbacks called by builtins & misc fixes.
by Gabriel Ivăncescu 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1506

3 8

[PATCH 0/1] MR1500: winspool: Correctly free data allocated with GdiConvertToDevmodeW.
by Piotr Caban (＠piotr) 23 Nov '22

23 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1500

3 2

[PATCH 0/1] MR1521: rpcss: Use I_Rpc(Free|Allocate) in MIDL_user_(allocate|free).
by Rémi Bernon 23 Nov '22

23 Nov '22

In ept_map, rpcss uses TowerConstruct to allocate tower array elements. The array is later released by the generated stub code, and each element is ultimately freed using MIDL_user_free. TowerConstruct always allocate memory using I_RpcAllocate, we must use I_RpcFree to free it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1521

1 1

[PATCH v3 0/7] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 23 Nov '22

23 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: comctl32/listview: Use CRT allocation functions. comctl32/button: Use CRT allocation functions. comctl32/propsheet: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

3 8

[PATCH v2 0/7] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 23 Nov '22

23 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: comctl32/listview: Use CRT allocation functions. comctl32/button: Use CRT allocation functions. comctl32/propsheet: Use CRT allocation functions. comctl32/imagelist: Use CRT allocation functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

3 8

[PATCH 0/7] MR1520: comctl32: Use CRT allocation functions.
by Nikolay Sivov (＠nsivov) 23 Nov '22

23 Nov '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1520

4 10

[PATCH v9 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 23 Nov '22

23 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v9: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

3 2