November 2022 - Wine-gitlab

[PATCH v3 0/1] MR1453: include: Add Stg functions declaration in propvarutil.h.
by Biswapriyo Nath (＠Biswa96) 22 Nov '22

22 Nov '22

-- v3: include: Add Stg functions declaration in propvarutil.h. https://gitlab.winehq.org/wine/wine/-/merge_requests/1453

2 1

[PATCH 0/1] MR1483: explorer: Put the calling convention inside the function pointer parentheses.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

As required by MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1483

3 2

[PATCH 0/1] MR1501: ntdll: Use system language as preferred, if user language is custom-unspecified.
by Nikolay Sivov (＠nsivov) 22 Nov '22

22 Nov '22

This is follow up for !1417, user language still could be set to unspecified due to later change to original MR to reset only the system locale. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1501

2 1

[PATCH 0/1] MR1497: xinputuap.dll: Add new dll.
by Rémi Bernon 22 Nov '22

22 Nov '22

Based on a patch by Yusuf Khan <yusisamerican(a)gmail.com>. Required for Halo Infinite. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1497

3 4

[PATCH 0/1] MR1499: server: Set missing error status for get_process_image_name.
by Rémi Bernon 22 Nov '22

22 Nov '22

This is supposedly fixing some games (Age of Empires II Definitive Edition) but I must say that I don't remember in which circumstances this happens. In any case the `get_process_image_name` request doesn't set any reply when `process->image` is NULL, and in which case it also doesn't set any error. Having an error status seems to be a correct fix. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1499

1 1

[PATCH 0/2] MR1496: winebus.sys: Add more trace messages.
by Rémi Bernon 22 Nov '22

22 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1496

1 2

[PATCH v2 0/1] MR1460: hhctrl: Handle memory allocation failure in GetChmString.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

-- v2: hhctrl: Handle memory allocation failure in GetChmString. https://gitlab.winehq.org/wine/wine/-/merge_requests/1460

3 2

[PATCH v6 0/1] MR1456: imm32: Prevent deadlock on unload
by Fabian Maurer (＠DarkShadow44) 22 Nov '22

22 Nov '22

We need to make sure all (important) cleanup is finished when we exit DllMain, otherwise we might already unload krnl386 and deadlock Since we can't have a synchronous DestroyWindow, use an extra message Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52511 Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> Code flow is like follows: - DOSVM_Exit -> RtlExitUserThread -> LdrShutdownThread - acquire loader lock - send DLL_THREAD_DETACH to imm32 - - calls DestroyWindow on its window - - WM_DESTROY is handled asynchonously! - send DLL_THREAD_DETACH to krnl386.exe - - TASK_ExitTask - - try get win16 lock, is blocked by ime32 meanwhile, at ime32 - handles WM_DESTROY - already have win16 lock from user32 - __wine_ime_wnd_proc (WM_DESTROY) -> imm_couninit_thread -> CoRevokeInitializeSpy - LdrGetProcedureAddress (want CoRevokeInitializeSpy) - try get loader_lock, is blocked Solution is to wait in ime32 DllMain until the cleanup as happened, aka CoRevokeInitializeSpy has finished. -- v6: imm32: Prevent deadlock on unload https://gitlab.winehq.org/wine/wine/-/merge_requests/1456

4 4

[PATCH 0/1] MR1482: ucrtbase/tests: Put the calling convention inside the function pointer parentheses.
by Alex Henrie (＠alexhenrie) 22 Nov '22

22 Nov '22

As required by MSVC. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1482

3 2

[PATCH v2 0/2] MR1492: Load and save application-specific console settings from the registry
by Hugh McMaster (＠hmc) 22 Nov '22

22 Nov '22

On Windows, application-specific settings are stored in the registry under HKCU\Console\<path_to_app>. Our implementation of conhost.exe does not know which process is connected to it, so we need to get the full process image name before loading any application-specific console settings. To do this, we extend the server protocol to pass the process Id of the connected console process to conhost.exe. Please run tools/make_requests before merging. -- v2: conhost: Load application-specific settings using the full process image name https://gitlab.winehq.org/wine/wine/-/merge_requests/1492

2 2