December 2022 - Wine-gitlab

[PATCH 0/1] MR1884: d3d8: Filter out redundant buffer discards.
by Zebediah Figura (＠zfigura) 23 Dec '22

23 Dec '22

I was unable to write tests for this; it seems it doesn't consistently work on Windows. However, Rayman 3 seems to rely on it; it maps the same buffer twice immediately after creation, with DISCARD flags on both maps, and expects the same address to be returned. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53752 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1884

3 3

[PATCH v17 0/3] MR155: ntdll: Fix reading stale Information from IOSB.
by Jinoh Kang (＠iamahuman) 23 Dec '22

23 Dec '22

Enforce proper atomic update so that other threads do not read stale data from IO_STATUS_BLOCK. Signed-off-by: Jinoh Kang <jinoh.kang.kr(a)gmail.com> -- v17: ntdll: Fix reading stale Information from IOSB. https://gitlab.winehq.org/wine/wine/-/merge_requests/155

3 5

[PATCH v4 0/1] MR1492: Load and save application-specific console settings from the registry
by Hugh McMaster (＠hmc) 23 Dec '22

23 Dec '22

On Windows, application-specific settings are stored in the registry under HKCU\\Console\\<path_to_app>. Our implementation of conhost.exe does not know which process is connected to it, so we need to get the full process image name before loading any application-specific console settings. To do this, we extend the server protocol to pass the process Id of the connected console process to conhost.exe. Please run tools/make_requests before merging. -- v4: conhost: Load/Save console settings using the process path or window title https://gitlab.winehq.org/wine/wine/-/merge_requests/1492

4 8

[PATCH 0/2] MR1875: regedit.exe redraw fixes
by Jinoh Kang (＠iamahuman) 23 Dec '22

23 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1875

3 4

[PATCH 0/1] MR1864: wined3d: Ignore DISCARD and NOOVERWRITE on buffers which are not GPU-accessible.
by Zebediah Figura (＠zfigura) 23 Dec '22

23 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53863 This fixes a regression introduced by ebbcc10b0593948657b8e684c3a9be8ace1a5d25. Prior to that commit, buffers which were not CPU-accessible would not have the WINED3D_BUFFER_USE_BO flag set, and accordingly buffer_resource_sub_resource_map() would simply return the SYSMEM location, ignoring the DISCARD and NOOVERWRITE flags. However, the "accelerated" path in wined3d_cs_map_upload_bo() only checks for the DISCARD flag, assuming that it is only set for dynamic GPU-accessible buffers, and would subsequently try to allocate non-mappable memory and then map it. This commit avoids the accelerated path for such buffers, once again matching our old behaviour. According to [1], this also matches Windows: DISCARD on SYSTEMMEM buffers is ignored on both AMD and NVidia, and NOOVERWRITE is ignored on NVidia (but not AMD). [1] https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.org/mes… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1864

3 2

[PATCH v3 0/3] MR1865: wined3d: Load and invalidate every mipmap level when mapping the top mipmap level.
by Zebediah Figura (＠zfigura) 23 Dec '22

23 Dec '22

-- v3: wined3d: Load and invalidate every mipmap level when mapping the top mipmap level. d3d8/tests: Test uploading the whole mipmap chain in one map. d3d9/tests: Test uploading the whole mipmap chain in one map. https://gitlab.winehq.org/wine/wine/-/merge_requests/1865

4 6

[PATCH 0/1] MR1863: d3d11/tests: Do not test deferred contexts in test_dynamic_map_synchronization().
by Zebediah Figura (＠zfigura) 23 Dec '22

23 Dec '22

DISCARD maps on deferred contexts do not seem to offer the same synchronization guarantees as do DISCARD maps on the immediate context, at least not with respect to subsequent NOOVERWRITE maps on the immediate context. This is not particularly surprising, seeing as it is probably far more usual to only map a resource on one kind of context or the other. The test currently fails on Windows 11 on NVidia drivers, but it also fails on Mesa, for what I think are the same reasons. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52563 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54023 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1863

3 2

[PATCH 0/1] MR1881: comctl32/test: Adapt the edit tests for height to Win10+.
by eric pouech (＠epo) 23 Dec '22

23 Dec '22

Starting with Win10, height of multiline edit controls no longer seems to be hardwired to a multiple of the font height (when larger than font height). - Adapt the tests accordingly (detecting how to compute the expected height of a control). - Extend the ranges of the tested heights. Note: - there may be another way to detect the model for height computation. - the range of heights tested stem from internal testing and is larger than existing testing. It could be reduced as a range, or picking values from a fixed set of values (if needed). Wine-bug: https://bugs.winehq.org/show_bug.cgi?id=52152 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1881

3 4

[PATCH v2 0/1] MR1878: comctl32/listview: Draw border and background separately in WM_NCPAINT.
by Vladislav Timonin (＠vt) 23 Dec '22

23 Dec '22

Depending on the theme, if there was a header, the border ends up painted lower than it should be, and clipped by the header. 7-Zip file manager, the reason why the offset was added in 5f0dcf79185941c4faff35d1cc9c758160f3a27d in the first place, still renders correctly. Before: ![before](/uploads/8321f45c657469278b2787edfa147b20/before.png) After: ![after](/uploads/013241f4cd3b893c7f4073b6a9fe8119/after.png) EDIT1: Actually compared screenshots of 7-Zip file manager and looks like the headers are now painted consistently after highlighting them. ![7zFM-before-hilite](/uploads/64fe3fb80002c847c2e9270337bab4e8/7zFM-before-hilite.png) ![7zFM-after-hilite](/uploads/4db4778c2ad6d27eddbd4a1202b41881/7zFM-after-hilite.png) -- v2: comctl32/listview: Exclude header area in WM_NCPAINT. https://gitlab.winehq.org/wine/wine/-/merge_requests/1878

3 3

Re: [PATCH v2 0/1] MR1883: include: Add missing constants in d3d11.idl. - approved
by Alexandre Julliard (＠julliard) 22 Dec '22

22 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1883

1 0