December 2022 - Wine-gitlab

[PATCH v10 0/7] MR1445: kernelbase: Some refactoring of the open_key() and create_key() functions.
by Sven Baars (＠sbaars) 02 Dec '22

02 Dec '22

This is in preparation of implementing all logic from the server in kernelbase, which is needed because Nt*Key ignores KEY_WOW64_32KEY. Unfortunately this requires a lot of server calls. The full branch can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-new The old approach that doesn't duplicate code to kernelbase can be found here https://gitlab.winehq.org/sbaars/wine/-/tree/shared-classes-old I ran make_requests by the way, not sure if we should still leave that out with the gitlab workflow. -- v10: kernelbase: Always try to open the Wow6432Node in create_key() kernelbase: Restructure the create_key() loop. kernelbase: Add a fast path to create_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/1445

2 7

[PATCH 0/1] MR1654: mfplat: Clear the clsid pointer in MFTEnum to avoid invalid free.
by Rémi Bernon 02 Dec '22

02 Dec '22

If no MFT are enumerated the pointer is still later freed with `CoTaskMemFree` without being initialized. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1654

2 2

[PATCH v2 0/8] MR1659: localspl: Add support for Job handles.
by Piotr Caban (＠piotr) 02 Dec '22

02 Dec '22

-- v2: winspool: Call providor in ReadPrinter implementation. localspl: Add ReadPrinter implementation. localspl: Add support for Job handles. localspl: Rename job_t structure to job_info_t. localspl: Use separate structure to store printserver handles. localspl: Use separate structure to store XcvPort and XcvMonitor handles. https://gitlab.winehq.org/wine/wine/-/merge_requests/1659

3 10

[PATCH v2 0/3] MR1631: wineusb.sys: Implement DevClass compatible id for devices with multiple interfaces.
by Ivo Ivanov (＠logos128) 02 Dec '22

02 Dec '22

Also make the device instance id unique (at least to the bus), as required by MS. It is also easily addressable by other drivers. -- v2: wineusb.sys: Add usbver, revision, busnum and portnum to PDO's instance id. wineusb.sys: Implement DevClass compatible id for devices with multiple interfaces. wineusb.sys: Pass interface and interface_index from the event data to the usb device data. https://gitlab.winehq.org/wine/wine/-/merge_requests/1631

2 3

Re: [PATCH v2 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by mbriar (＠mbriar) 02 Dec '22

02 Dec '22

On Fri Dec 2 10:52:41 2022 +0000, Alexandre Julliard wrote: > > I'm more optimistic about 8.0. Anyway, I wouldn't mind committing it > if we need to. At the same time, since there is an active work on the > final solution, we may as well wait a few days and see how it goes. Let > me defer that to Alexandre (I think he took over that optimization work). > I've committed some fixes inspired by Rémi's work. Hopefully that will > be good enough to avoid the direct calls, can you please give it a try? Hello, I've compared a windows build of [vkoverhead](https://github.com/zmike/vkoverhead) test case 92, which uses descriptor buffers, on latest wine from git. I'm getting a score of around 48000 operations per second without this patch, and around 84000 with this patch using direct calls, so still almost a 2x difference. FWIW, a linux build without using wine gets around 320000 in the same test, all using the RADV vulkan driver. I haven't tested it with actual games yet, but I expect it to still have a noticeable effect on CPU-bound games with vkd3d-proton. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552#note_18427

1 0

[PATCH 0/1] MR1653: msvcrt: Use operator_delete to free _Condition_variable queue nodes.
by Rémi Bernon 02 Dec '22

02 Dec '22

Fwiw, HeapAlloc / HeapFree are used elsewhere in this file, but I don't think they overlap with the _Condition_variable queue nodes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1653

2 2

[PATCH 0/1] MR1623: rpcrt4/tests: Don't use an array of pointers in test_conf_complex_struct.
by Alex Henrie (＠alexhenrie) 02 Dec '22

02 Dec '22

An array of pointers isn't conformant on 64-bit and will overrun the destination buffer when unmarshalling. Since the purpose of this function is to test a conformant FC_BOGUS_STRUCT, use one that is conformant on both 32-bit and 64-bit. The revised test coincidentally reveals that there is a problem with the padding or alignment after a marshalled 16-bit enum, which will need to be addressed separately. Co-authored-by: Zebediah Figura <z.figura12(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1623

4 3

[PATCH 0/1] MR1652: winspool: Define copy_file() only if CUPS is available.
by Zebediah Figura (＠zfigura) 02 Dec '22

02 Dec '22

Avoid unused function warnings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1652

4 3

[PATCH 0/1] MR1640: mshtml: Fix realloc size vs element count mixup.
by Rémi Bernon 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1640

2 2

[PATCH 0/1] MR1647: mshtml: Annotate nsalloc with __WINE_(DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 02 Dec '22

02 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1647

3 2