August 2022 - Wine-gitlab - list.winehq.org

Re: [PATCH v5 0/6] MR589: winemac: wineandroid: Display settings code cleanup. - approved
by Alexandre Julliard (＠julliard) 08 Aug '22

08 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/589

1 0

Re: [PATCH v2 0/6] MR575: mf: Use the Video Processor transform for video conversion. - approved
by Alexandre Julliard (＠julliard) 08 Aug '22

08 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/575

1 0

[PATCH v2 0/1] MR602: ntdll: Also initialize icmp_over_dgram in sock_read().
by Paul Gofman (＠gofman) 08 Aug '22

08 Aug '22

Fixes a regression introduced by commit 1e35966eb57db7060d0c459bc7aaac2f6cad7442. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52429 -- v2: ntdll: Also initialize icmp_over_dgram in sock_read(). https://gitlab.winehq.org/wine/wine/-/merge_requests/602

3 2

Re: [PATCH v2 0/1] MR4: vkd3d: Remove unused field fence_destruction_cond. - approved
by Alexandre Julliard (＠julliard) 08 Aug '22

08 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/4

1 0

Re: [PATCH v3 0/1] MR3: vkd3d: Unlock fence worker mutex before exiting. - approved
by Alexandre Julliard (＠julliard) 08 Aug '22

08 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/3

1 0

[PATCH v2 0/2] MR574: mf: Improve session pause / restart handling.
by Paul Gofman (＠gofman) 08 Aug '22

08 Aug '22

Patch 1. The tests on Windows show that when the timer callback is queued behind the clock time it is queued and executed quite soon with 0-15ms delay which corresponds to default timer granularity. The timeout tolerance in the test is quite bigger to avoid a flaky test. Wine currently may execute the callback right away or delay it indefinitely depending on the time difference and current system time. Patch 2. It turns out when the session is paused and then restarted and all the samples were delivered to sample grabber before restart, nothing is going to request the samples again when the session is restarted. I am attaching a test in a patch which hopefully confirms how that should work. I am not including that in the patches as the test involves delays (to make sure all the async events settle at certain points) and inherently flaky. Also, _ IMFStreamSink_GetEvent(stream, ...) in the test crashes on Win7 for some unknown reason. [0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch](/uploads/58c1738d48b3392e7ec430a0757210d0/0001-mf-tests-Add-test-for-pausing-and-restarting-sample-.patch) -- v2: mf/samplegrabber: Request a sample when going from paused to running state. mf: Handle timer time behind clock time in present_clock_schedule_timer(). https://gitlab.winehq.org/wine/wine/-/merge_requests/574

2 3

[PATCH 0/5] MR581: d3d8, d3d9: More tests for dirty rects and UpdateTexture().
by Zebediah Figura (＠zfigura) 08 Aug '22

08 Aug '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/581

4 7

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Huw Davies (＠huw) 08 Aug '22

08 Aug '22

On Mon Aug 8 14:11:55 2022 +0000, Francois Gouget wrote: > Ah, right. Well, there is a `memset( &ip_h, 0, sizeof(ip_h) );` earlier on. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5818

2 1

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Francois Gouget (＠fgouget) 08 Aug '22

08 Aug '22

On Mon Aug 8 13:20:50 2022 +0000, **** wrote: > Paul Gofman replied on the mailing list: > ``` > > On 8 Aug 2022, at 02:56, Francois Gouget (@fgouget) > <wine(a)gitlab.winehq.org> wrote: > > > > ��Francois Gouget (@fgouget) commented about dlls/ntdll/unix/socket.c: > >> + req->icmp_seq = icmp_h->un.echo.sequence; > >> + if (!(fixup_status = wine_server_call( req ))) > >> + icmp_h->un.echo.id = reply->icmp_id; > >> + else > >> + WARN( "socket_get_fixup_data returned %#x.\n", > fixup_status ); > >> + } > >> + SERVER_END_REQ; > >> + > >> + if (!fixup_status) > >> + { > >> + icmp_h->checksum = 0; > >> + icmp_h->checksum = chksum( (BYTE *)icmp_h, recv_len - > sizeof(ip_h) ); > >> + } > >> + } > >> + ip_h.checksum = 0; > >> + ip_h.checksum = chksum( (BYTE *)&ip_h, sizeof(ip_h) ); > > Isn't the first assignment redundant? > > > No, it isn��t. checksum field is not excluded anyhow else from checksum > calculation and should be 0 for correct result. > > -- > > https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5796 > > _______________________________________________ > > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > _______________________________________________ > wine-gitlab mailing list -- wine-gitlab(a)winehq.org > To unsubscribe send an email to wine-gitlab-leave(a)winehq.org > ``` Ah, right. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5817

1 0

Re: [PATCH v5 0/5] MR384: winsock: Support fallback to ICMP over SOCK_DGRAM on Linux
by Francois Gouget (＠fgouget) 08 Aug '22

08 Aug '22

Francois Gouget (@fgouget) commented about dlls/ntdll/unix/socket.c: > + req->icmp_seq = icmp_h->un.echo.sequence; > + if (!(fixup_status = wine_server_call( req ))) > + icmp_h->un.echo.id = reply->icmp_id; > + else > + WARN( "socket_get_fixup_data returned %#x.\n", fixup_status ); > + } > + SERVER_END_REQ; > + > + if (!fixup_status) > + { > + icmp_h->checksum = 0; > + icmp_h->checksum = chksum( (BYTE *)icmp_h, recv_len - sizeof(ip_h) ); > + } > + } > + ip_h.checksum = 0; > + ip_h.checksum = chksum( (BYTE *)&ip_h, sizeof(ip_h) ); Isn't the first assignment redundant? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/384#note_5796

2 1