August 2022 - Wine-gitlab - list.winehq.org

[PATCH v10 0/1] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens 02 Aug '22

02 Aug '22

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- v10: cabinet/tests: add tests for DllGetVersion & GetDllVersion https://gitlab.winehq.org/wine/wine/-/merge_requests/564

1 1

Re: [PATCH v2 0/3] MR511: webservices: Support error strings and faults in error.
by Hans Leidekker (＠hans) 02 Aug '22

02 Aug '22

First patch should be merged with the second. Tests and include changes could be separate patches. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/511#note_5492

1 0

[PATCH v9 0/1] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens 02 Aug '22

02 Aug '22

Fix stub DllGetVersion implementation to read Dll version and put it in correct structure. Implement GetDllVersion by using DllGetVersion function and return version -- v9: cabinet/tests: add tests for DllGetVersion & GetDllVersion https://gitlab.winehq.org/wine/wine/-/merge_requests/564

2 3

Re: [PATCH v8 0/1] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Tobias Görgens 02 Aug '22

02 Aug '22

On Tue Aug 2 05:00:46 2022 +0000, Chip Davis wrote: > > Is there any way to manually trigger the test bot? > You can submit patches yourself to [the > testbot](https://testbot.winehq.org/). Note that you will need an > account on the testbot in order to do this, which I believe is separate > from your account here. > > the pipeline fails due to a (more or less) unrelated issue in another > dll (msi). They have a function with the same name, DllGetVersion. > That is because `DllGetVersion()` is also the name of an optional > function supported by COM server DLLs. That's what those definitions in > `<shlwapi.h>` are for. > > Could it be that the dev defined it in shlwapi.h? The issue is that I > can't define my function correctly with this definition (probably the > reason why the first implementation used it, wrongly), but they can't > use it without (or probably can, but didn't). > Or, you could give `cabinet`'s `DllGetVersion()` a new name, and then in > `cabinet.spec`, export the new name under the correct name: > ``` > 2 stdcall -private DllGetVersion(ptr) cabinet_dll_get_version > ``` > (Why did you remove the ordinals? The commit in which this happened has > somehow vanished, but I remember seeing that.) OK, I'll try to submit the patch manually to the test bot to see if it works now as expected :) Oh, I see, o I should leave the definition of DllGetVersion in it I guess. Renaming the function in cabinet.dll seems more like a workaround than a fix tbh, but I'll do as you say. Removing the ordinals didn't have a specific reason, I just noticed that in some spec files there are ordinals and in some there are just @'s. I couldn't find anything on the difference, so I swapped them. Especially since I don't know how to numerate the imports, this seemed easier and worked fine. Do the ordinals have any meaning/is there a reason to keep them? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_5485

1 0

[PATCH v3 0/7] MR536: xactengine3_7: Add helper function to add entries
by Alistair Leslie-Hughes (＠alesliehughes) 02 Aug '22

02 Aug '22

Signed-off-by: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> -- v3: xactengine3_7: Return error on invalid notification value. xactengine3_7: Implement callback for supported messages xactengine3_7: Record context for each notications xactengine3_7: Map IXACT3Wave interfaces xactengine3_7: Map IXACT3Cue interfaces xactengine3_7: Map SoundBank interfaces xactengine3_7: Add helper function to add entries https://gitlab.winehq.org/wine/wine/-/merge_requests/536

3 12

[PATCH v3 0/2] MR521: ddraw: Don't account video memory for sysmem surfaces' draw textures.
by Stefan Dösinger 02 Aug '22

02 Aug '22

Star Trek Starfleet Academy does not like it when available video memory goes down after creating a system memory resource. It destroys all its textures and recreates them, and in some sitations forgets to recreate one or another texture, resulting in rendering bugs. I suspect the game is trying to detect focus loss by monitoring for unexpected video memory changes. --- I am open to renaming WINED3DUSAGE_PRIVATE to something else, like WINED3DUSAGE_NO_VIDMEM_ACCOUNTING. This particular name is ugly long though. -- v3: ddraw/tests: Add some video memory accounting tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/521

3 5

[PATCH v2 0/6] MR543: wined3d: Cache the output mode lists where possible.
by Zebediah Figura (＠zfigura) 02 Aug '22

02 Aug '22

-- v2: wined3d: Build the device list only once in wined3d_output_find_closest_matching_mode(). dxgi: Build the device list only once in dxgi_output_get_display_mode_list(). d3d8: Cache the output mode list. d3d9: Cache the output mode list. wined3d: Build a list of wined3d_display_mode structures in wined3d_output_get_mode[_count](). wined3d: Factor out mode_matches_filter(). https://gitlab.winehq.org/wine/wine/-/merge_requests/543

5 10

[PATCH v2 0/7] MR544: ws2_32: More TCP reset patches.
by Zebediah Figura (＠zfigura) 02 Aug '22

02 Aug '22

-- v2: ws2_32: Translate AFD_POLL_RESET to FD_CLOSE plus WSAECONNABORTED in WSAEnumNetworkEvents(). server: Translate AFD_POLL_RESET to FD_CLOSE plus WSAECONNABORTED in window messages. server: Return ERROR_CONNECTION_RESET when trying to recv() on a reset socket. ws2_32/tests: Work around a Linux bug. ws2_32/tests: Test send() after TCP reset. http.sys: Keep connection sockets open after sending a 400 response. ws2_32/tests: Test sending data to a peer is closed(). https://gitlab.winehq.org/wine/wine/-/merge_requests/544

2 7

[PATCH v2 0/11] MR557: mciqtz32: Correct video window behavior by creating default window.
by Akihiro Sagawa (＠sgwaki) 02 Aug '22

02 Aug '22

This is a new try of mciqtz32's video window patch. Comparing to the previous !370, I added a lot of tests regarding the video window behavior. Some portion of the previous patch are dropped to avoid complexity, I'll add that part later. -- v2: mciqtz32: Show the default video window when switching from another one. mciqtz32: Hide the default video window when switching to another one. mciqtz32: Reset the video size when changing video destination. mciqtz32: Correct initial video window dimensions. mciqtz32: Fix MCI_DGV_WHERE_WINDOW behavior. mciqtz32: Correct video window behavior by creating default window. winmm/tests: Add tests for destination of video window. winmm/tests: Add tests for dimensions of video window. winmm/tests: Add tests for window style of video window. mciqtz32: Don't hide video window when stopping. winmm/tests: Add tests for visibility of video window. https://gitlab.winehq.org/wine/wine/-/merge_requests/557

3 15

Re: [PATCH v8 0/1] MR564: cabinet: implement DllGetVersion & GetDllVersion
by Chip Davis (＠cdavis5e) 02 Aug '22

02 Aug '22

> Is there any way to manually trigger the test bot? You can submit patches yourself to [the testbot](https://testbot.winehq.org/). Note that you will need an account on the testbot in order to do this, which I believe is separate from your account here. > the pipeline fails due to a (more or less) unrelated issue in another dll (msi). They have a function with the same name, DllGetVersion. That is because `DllGetVersion()` is also the name of an optional function supported by COM server DLLs. That's what those definitions in `<shlwapi.h>` are for. > Could it be that the dev defined it in shlwapi.h? The issue is that I can't define my function correctly with this definition (probably the reason why the first implementation used it, wrongly), but they can't use it without (or probably can, but didn't). Or, you could give `cabinet`'s `DllGetVersion()` a new name, and then in `cabinet.spec`, export the new name under the correct name: ``` 2 stdcall -private DllGetVersion(ptr) cabinet_dll_get_version ``` (Why did you remove the ordinals? The commit in which this happened has somehow vanished, but I remember seeing that.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/564#note_5469

1 0