September 2022 - Wine-gitlab

[PATCH v5 0/1] MR734: tests: Make sure only one thread prints traces at a time.
by Francois Gouget (＠fgouget) 01 Sep '22

01 Sep '22

Some Wine tests are multi-threaded or start child processes which can result in traces and failure messages being garbled which prevents them from being recognized by continuous integration tools. So printing the tests messages is now serialized. Note that if a process crashes while holding the mutex, that mutex will be abandonned and not cause a deadlock. -- v5: tests: Make sure only one thread prints traces at a time. https://gitlab.winehq.org/wine/wine/-/merge_requests/734

2 2

[PATCH v3 0/1] MR730: user32: Implement DefRawInputProc.
by Andrey Gusev (＠agusev) 01 Sep '22

01 Sep '22

-- v3: user32: Implement DefRawInputProc. https://gitlab.winehq.org/wine/wine/-/merge_requests/730

4 4

[PATCH 0/1] MR759: include/wine/test.h: Enable ANSI support in console for WINETEST_COLOR.
by eric pouech (＠epo) 01 Sep '22

01 Sep '22

This lets WINETEST_COLOR works under Windows console (at least, on recent versions where ANSI support is available). (Keeping logic: + "auto": emit ANSI sequences only when output is capable of + "1": always use ANSI sequences ) Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/759

2 1

[PATCH v2 0/5] MR755: uxtheme: Do not draw parent background even if scrollbar arrows and thumb are transparent.
by Zhiyi Zhang (＠zhiyi) 01 Sep '22

01 Sep '22

This is confirmed by the tests in test_scrollbar() and manual tests on XP. Even though scrollbar arrows and thumb are in fact transparent, DrawThemeParentBackground() is not called to paint the parent background, leaving the transparent area untouched. On Windows, even if the scrollbar arrows are reported to be transparent, the bitmaps for arrow parts in the stock themes are in fact opaque. Fix Ice Cream Calculator slow scrolling after 4cb229a because the WM_PRINTCLIENT handling in the application is slow. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53337 -- v2: comctl32/datetime: Do not paint parent background when painting arrows. uxtheme: Do not draw parent background even if scrollbar arrows and thumb are transparent. uxtheme: Use the brush from WM_CTLCOLORSCROLLBAR to paint SB_CTL scrollbar tracks if present. comctl32/tests: Add themed scrollbar background tests. uxtheme/tests: Add theme tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/755

2 5

[PATCH 0/1] MR757: dwrite: Handle variation selectors 17-256 in MapCharacters().
by Nikolay Sivov (＠nsivov) 31 Aug '22

31 Aug '22

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/757

2 1

Re: [PATCH v5 0/6] MR697: Implement d3dx10 effect creation for compiled shader.
by Ziqing Hui (＠zhui) 31 Aug '22

31 Aug '22

On Sat Aug 27 11:18:20 2022 +0000, Matteo Bruni wrote: > Nah, let's just keep this as it is now, no reason to make everything > more complicated. > I guess this is just something peculiar to fx_4_0 effects, surprised > that I never encountered it before. I'll do some further digging locally. I found that in d3d10/tests/effect.c: create_effect(): > /* > * Don't use sizeof(data), use data[6] as size, > * because the DWORD data[] has only complete DWORDs and > * so it could happen that there are padded bytes at the end. > * > * The fx size (data[6]) could be up to 3 BYTEs smaller > * than the sizeof(data). > */ Maybe we could do something like this? Use DWORDs to store shader code. And pass data[6] to size argument. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/697#note_7431

1 0

[PATCH 0/4] MR755: uxtheme: Do not draw parent background even if scrollbar arrows and thumb are transparent.
by Zhiyi Zhang (＠zhiyi) 31 Aug '22

31 Aug '22

This is confirmed by the tests in test_scrollbar() and manual tests on XP. Even though scrollbar arrows and thumb are in fact transparent, DrawThemeParentBackground() is not called to paint the parent background, leaving the transparent area untouched. On Windows, even if the scrollbar arrows are reported to be transparent, the bitmaps for arrow parts in the stock themes are in fact opaque. Fix Ice Cream Calculator slow scrolling after 4cb229a because the WM_PRINTCLIENT handling in the application is slow. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53337 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/755

3 5

[PATCH v13 0/2] MR672: comdlg32: Common item dialog fixes
by Ben Cottrell (＠bgc) 31 Aug '22

31 Aug '22

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v13: comdlg32: Add missing controls to the common item dialog, only affecting the implementation comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

3 4