January 2023 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR2068: Draft: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 31 Jan '23

31 Jan '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)) Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v2: comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

3 4

[PATCH 0/4] MR2079: Be consistent in naming bits inside PDB files.
by eric pouech (＠epo) 31 Jan '23

31 Jan '23

This series tidy up some naming used to describe the PDB internals. We are not consistent in the various names added over the years. Let's try to be a bit more clear. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2079

2 4

[PATCH v7 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 31 Jan '23

31 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v7: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 2

[PATCH v6 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 31 Jan '23

31 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v6: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 3

[PATCH v6 0/4] MR65: hlsl: More function-related tests.
by Zebediah Figura (＠zfigura) 31 Jan '23

31 Jan '23

-- v6: tests: Test entry point semantics on function declarations. tests: Add more tests for early return from the entry point. tests: Add some tests for early return from user-defined functions. vkd3d-shader/hlsl: Emit a hlsl_fixme() for HLSL_IR_CALL instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/65

3 5

[PATCH v3 0/1] MR2074: ws2_32: Provide same address order from gethostbyname() on consequent calls.
by Paul Gofman (＠gofman) 31 Jan '23

31 Jan '23

Fixes error connecting to servers in Life is Strange Remastered (due to timeout). When there are multiple IP addresses for a host name Linux gethostbyname() returns those in random order upon each call (meaning to provide server load balancing). On Windows the order of IP addresses is not determined as well but it is the same on consequent calls (changes after network resets and probably DNS timeout expiration). The game executes multiple http requests over TLS connection through its own libraries using only winsock from Wine. Upon executing each next request it calls gethostbyname() for the server DNS name and uses the first returned IP address. When that's different from the previous IP address used for established TLS connection it doesn't reuse the connection and establishes the connection from scratch which is very long process due to how the game does it (on Windows as well). One obvious way to make gethostbyname() behave like Windows would be to cache the results we get from host. But caching gethostbyname() results is tricky, there are already host-side caches which take into account DNS timeouts and network interfaces change. It is possible in theory to cache the result and then still call native gethostbyname() and keep the order if nothing else has changed in the reply, but it seems to me that would complicate things more than this patch does. The patch sorts the output by IP address randomly hashed with a random transform hash established only once per process run. So it will still provide load balancing between the IP addresses between different clients and different process instances while will be returning the same order of IP addresses on consequent calls. -- v3: ws2_32: Provide same address order from gethostbyname() on consequent calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2074

2 2

[PATCH 0/6] MR2069: jscript/mshtml: Misc fixes and preparations.
by Gabriel Ivăncescu 31 Jan '23

31 Jan '23

Bunch of misc fixes and preparations for further improvements. The location changes are especially important later when we'll use outer windows everywhere we pass them to external callers (such as script engines, since inner windows are an implementation detail and all operations otherwise should go through the outer window "proxy"). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2069

2 9

Re: [PATCH v7 0/1] MR777: ntoskrnl: MmAllocateContiguousMemorySpecifyCache semi-stub
by Etaash Mathamsetty (＠etaash.mathamsetty) 31 Jan '23

31 Jan '23

I will probably redo this with NtAllocateVirtualMemoryEx and create a full implementation -- https://gitlab.winehq.org/wine/wine/-/merge_requests/777#note_22462

1 0

[PATCH v2 0/1] MR2074: ws2_32: Provide same address order from gethostbyname() on consequent calls.
by Paul Gofman (＠gofman) 31 Jan '23

31 Jan '23

Fixes error connecting to servers in Life is Strange Remastered (due to timeout). When there are multiple IP addresses for a host name Linux gethostbyname() returns those in random order upon each call (meaning to provide server load balancing). On Windows the order of IP addresses is not determined as well but it is the same on consequent calls (changes after network resets and probably DNS timeout expiration). The game executes multiple http requests over TLS connection through its own libraries using only winsock from Wine. Upon executing each next request it calls gethostbyname() for the server DNS name and uses the first returned IP address. When that's different from the previous IP address used for established TLS connection it doesn't reuse the connection and establishes the connection from scratch which is very long process due to how the game does it (on Windows as well). One obvious way to make gethostbyname() behave like Windows would be to cache the results we get from host. But caching gethostbyname() results is tricky, there are already host-side caches which take into account DNS timeouts and network interfaces change. It is possible in theory to cache the result and then still call native gethostbyname() and keep the order if nothing else has changed in the reply, but it seems to me that would complicate things more than this patch does. The patch sorts the output by IP address randomly hashed with a random transform hash established only once per process run. So it will still provide load balancing between the IP addresses between different clients and different process instances while will be returning the same order of IP addresses on consequent calls. -- v2: ws2_32: Provide same address order from gethostbyname() on consequent calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2074

4 4

Re: [PATCH v3 0/1] MR2041: Draft: gdiplus: Correctly handle new lines.
by David Kahurani (＠kahurani) 31 Jan '23

31 Jan '23

Sorry, I had to mark this as draft once again... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2041#note_22457

1 0