October 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/3] MR382: vkd3d-shader/tpf: Replace sm4 register structs with vkd3d-shader register structs, part 4.
by Francisco Casas (＠fcasas) 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/382

4 5

[PATCH 0/1] MR4000: msvfw32: Correctly store internal pointer.
by eric pouech (＠epo) 02 Oct '23

02 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55696 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4000

2 1

[PATCH v3 0/1] MR3974: winemac.drv: Ensure user-land callback can access app_icon results.
by eric pouech (＠epo) 02 Oct '23

02 Oct '23

Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=55658 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- v3: winemac.drv: Use NtCallbackReturn to send back app's icons to unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/3974

3 2

Re: [PATCH v2 0/1] MR3854: winmm: Avoid use of hardcoded return values.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Oct '23

02 Oct '23

Yes, currently MCI_MapMsgAtoW returns a tri-state. -1 = Memory allocation error 0 = No unmap required 1 = Unmap required. Since MCI_UnmapMsgAtoW handles all the cases where MCI_MapMsgAtoW allocates memory. Why not just call MCI_UnmapMsgAtoW to do its thing in all cases? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_47342

1 0

[PATCH 0/1] MR3991: gdi32: Pass default DEVMODE to winspool in CreateDC."
by Piotr Caban (＠piotr) 02 Oct '23

02 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55670 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3991

3 2

[PATCH 0/5] MR3995: dmime: Preparatory cleanup of segment state.
by Rémi Bernon 02 Oct '23

02 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3995

2 6

[PATCH v2 0/4] MR3983: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current().
by Mohamad Al-Jaf (＠maljaf) 02 Oct '23

02 Oct '23

Needed for Minecraft Windows 10. -- v2: windows.storage.applicationdata: Implement IApplicationDataStatics::get_Current(). windows.storage.applicationdata/tests: Add IApplicationDataStatics::get_Current() tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3983

4 7

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 01 Oct '23

01 Oct '23

On Sun Oct 1 23:30:07 2023 +0000, YuriK7 wrote: > Thanks ! > The game I mentioned (touhou sky fight) is a weird case. It already > hangs (actually it just errors out and closes) without your patch on > vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they > updated it to 1.22. With the old gstreamer it used to be a skippable > black screen, however adding gstkrkr makes it crash. This merge doesn't > seem to change anything on that so be reassured, I guess I should open > either a wine issue or a gstreamer issue... > But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works > perfectly well with the new gstreamer + gstkrkr (the new version show a > color bars screen when the codec is missing, instead of playing the sound). Yes, that is consistent with my experience. I tried Azumanga (everything looks good to me with this patch) and Touhou (crashes on Wine 8.17, Wine 8.17 with this patch, and Debian's Wine 8.0; different output before the crash, but they all segfault in SampleGrabber_ISampleGrabber_GetCurrentBuffer). Sounds like a different bug to me. The color bars are not a Wine bug; they're protonmediaconverter. It does that if it can't find a converted version of the media, which it can't if you're running it outside Steam. gstkrkr fills that exact hole. (gstkrkr also does a little trick to ensure ffmpeg's WMA audio decoder is selected instead of mediaconverter.) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47318

1 0

Re: [PATCH v7 0/7] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by YuriK7 (＠riyu12383) 01 Oct '23

01 Oct '23

On Sun Oct 1 14:18:55 2023 +0000, Alfred Agrell wrote: > Glorious-Eggroll has a MPEG demuxer, which Proton's GStreamer lacks, but > neither of them have any MPEG-1 video decoder. > From what I can google, the correct incantation is adding > --enable-decoder=mpegvideo to GE's ffmpeg configure line; if successful, > it should show up in GStreamer as avdec_mpeg2video. > If adding gstkrkr works even without this MR, my guess is that those > programs tell DirectShow to automatically pick the appropriate decoders, > which ends up using CLSID_decodebin_parser instead of > CLSID_CMpegVideoCodec; you were missing the codec, but nothing else. > If adding this MR makes it hang or otherwise screw up, that's definitely > something I should look into... Thanks ! The game I mentioned (touhou sky fight) is a weird case. It already hangs (actually it just errors out and closes) without your patch on vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they updated it to 1.22. With the old gstreamer it used to be a skippable black screen, however adding gstkrkr makes it crash. This merge doesn't seem to change anything on that so be reassured, I guess I should open either a wine issue or a gstreamer issue... But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works perfectly well with the new gstreamer + gstkrkr (the new version show a color bars screen when the codec is missing, instead of playing the sound). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47317

1 0

[PATCH v10 0/1] MR3959: uxtheme: Add ShouldSystemUseDarkMode.
by Helix Graziani (＠TornadoCookie) 01 Oct '23

01 Oct '23

Used in some .NET apps for theming purposes. -- v10: uxtheme: Add ShouldSystemUseDarkMode. https://gitlab.winehq.org/wine/wine/-/merge_requests/3959

3 2