November 2023 - Wine-gitlab

Re: [PATCH v2 0/3] MR4484: comctl32: Use selected font to determine default min tab width
by Nikolay Sivov (＠nsivov) 30 Nov '23

30 Nov '23

Nikolay Sivov (@nsivov) commented about dlls/comctl32/tab.c: > - if (infoPtr->tabMinWidth < 0) > - oldcx = DEFAULT_MIN_TAB_WIDTH; > - else > + if (infoPtr->tabMinWidth < 0) { > + TEXTMETRICW text_metrics; > + HDC hdc = GetDC(infoPtr->hwnd); > + HFONT oldFont = SelectObject(hdc, infoPtr->hFont); > + GetTextMetricsW(hdc, &text_metrics); > + oldcx = text_metrics.tmAveCharWidth * MIN_CHAR_LENGTH + infoPtr->uHItemPadding * 2; > + SelectObject(hdc, oldFont); > + ReleaseDC(infoPtr->hwnd, hdc); > + } else { > oldcx = infoPtr->tabMinWidth; > + } > infoPtr->tabMinWidth = cx; > TAB_SetItemBounds(infoPtr); Could we move this segment to SetItemBounds()? It does exactly the same calculation. At the very least we should consider a helper. Or maybe we could return oldcx value from SetItemBounds()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4484#note_54425

1 0

[PATCH 0/7] MR4565: winex11: Use helpers to attach / detach / destroy client windows.
by Rémi Bernon 30 Nov '23

30 Nov '23

After some discussion on https://gitlab.winehq.org/wine/wine/-/merge_requests/4533, this refactors how child_window are handled to make it easier to decouple them from the whole_window, and eventually have multiple detached child_window for some Vulkan use case (possibly also GL). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4565

2 9

Re: [PATCH v4 0/6] MR4522: winewayland.drv: part 10.3: Vulkan swapchain presentation
by beh 591 (＠beh_591) 30 Nov '23

30 Nov '23

On Wed Nov 29 09:33:45 2023 +0000, Stefan Riesenberger wrote: > Thanks for the quick answer! > Yeah if everything diverged too much it makes no sense wasting time on rebasing. > Looking forward to everything getting upstream then! I hope the road > will be less bumpy next year as it has been this year. looking forward for the mouselock support (you mean putting the cursor in the center I suppose) basically all I need to switch to wine-wayland which is great having support for wl-clipboard is appreciated since xwayland is broken -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4522#note_54421

1 0

[PATCH v3 0/4] MR4441: Adding tests for CreateProcess and std handles.
by eric pouech (＠epo) 30 Nov '23

30 Nov '23

Various new tests for CreateProcess showing a couple of issues in current implementation. -- v3: kernelbase: Reset std handles gotten by GetStartupInfo(). ntdll,server: Revisit std handles inheritance. kernel32/tests: Add more tests about CreateProcess. kernel32/tests: Introduce a new infrastructure for testing CreateProcess(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4441

3 9

[PATCH 0/9] MR4546: [PATCH] Implement bypass process freeze flag (0x40) in NtCreateThreadEx
by Dāvis Mosāns 30 Nov '23

30 Nov '23

https://secret.club/2021/01/04/thread-stuff.html https://research.checkpoint.com/2023/raspberry-robin-anti-evasion-how-to-ex… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4546

3 4

[PATCH 0/1] MR4563: wineps.drv: Fix printing images from iexplore.
by Piotr Caban (＠piotr) 30 Nov '23

30 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4563

2 1

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by Alexandros Frantzis (＠afrantzis) 30 Nov '23

30 Nov '23

On Thu Nov 30 15:33:34 2023 +0000, Yona-TYT wrote: > I did a little test with the Jagex Launcher to play oldrunescape, but in > wayland the window is completely black. > Even so, I was able to execute by guessing where the "Play" button was. > [JagexLauncherInstaller.exe](https://cdn.jagex.com/Jagex%20Launcher%20Instal… > x11:![Captura_desde_2023-11-30_10-24-39](/uploads/b8c9d8f92502f0865f35cc4163655bff/Captura_desde_2023-11-30_10-24-39.png) > wayland![Captura_desde_2023-11-30_10-01-26](/uploads/94516f1b42566425180f383cc717c7e7/Captura_desde_2023-11-30_10-01-26.png) >From a quick look, the launcher uses CEF (Chromium Embedded Framework). CEF typically uses cross-process rendering which is not supported in the upstream Wayland driver yet. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_54400

1 0

[PATCH 0/1] MR4562: dwmapi: Implement DwmGetWindowAttribute(DWMWA_EXTENDED_FRAME_BOUNDS).
by Akihiro Sagawa (＠sgwaki) 30 Nov '23

30 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55968 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4562

2 1

Re: [PATCH v3 0/7] MR3909: winewayland.drv: part 7: Basic window management
by Yona-TYT (＠Yona-TYT) 30 Nov '23

30 Nov '23

I did a little test with the Jagex Launcher to play oldrunescape, but in wayland the window is completely black. Even so, I was able to execute by guessing where the "Play" button was. [JagexLauncherInstaller.exe](https://cdn.jagex.com/Jagex%20Launcher%20Instal… x11:![Captura_desde_2023-11-30_10-24-39](/uploads/b8c9d8f92502f0865f35cc4163655bff/Captura_desde_2023-11-30_10-24-39.png) wayland![Captura_desde_2023-11-30_10-01-26](/uploads/94516f1b42566425180f383cc717c7e7/Captura_desde_2023-11-30_10-01-26.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_54398

1 0

[PATCH 0/5] MR502: vkd3d-shader/d3d-asm: Add an "internal" mode for the ASM dumper.
by Giovanni Mascellani (＠giomasce) 30 Nov '23

30 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/502

3 7