December 2023 - Wine-gitlab

[PATCH 0/1] MR4752: Fix comctl32/propsheet - should react to CTRL+TAB and CTRL+SHIFT+TAB
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

Fix comctl32/propsheet - should react to CTRL+TAB and CTRL+SHIFT+TAB Currently not working as calling IsDialogMessageW instead of PROPSHEET_IsDialogMessage which is correctly implementing TAB key management -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4752

2 2

[PATCH 0/1] MR4751: Comdlg32/Color : Implement ClipCursor logic
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

Comdlg32/Color : Fix ClipCursor ClipCursor ("cursor caging in 2D spectrum") is not implemented (FIXME). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4751

2 2

Re: [PATCH v2 0/1] MR4747: Fix Comdlg32/Color : color picker does not use "limited" value, leading to out of bound - closed
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

This merge request was closed by Kyle Katarn. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4747

1 0

Re: [PATCH v2 0/1] MR4747: Fix Comdlg32/Color : color picker does not use "limited" value, leading to out of bound
by Nikolay Sivov (＠nsivov) 27 Dec '23

27 Dec '23

Could you explain how to reproduce this, without mspaint? P.S. note that commit message needs to be meaningful, that's what going to get in the git history. It also need to use your real name. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4747#note_56444

1 0

[PATCH 0/2] MR4748: Don't test function directly when reporting GetLastError()
by André Zwing 27 Dec '23

27 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4748

4 5

Re: [PATCH v3 0/4] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound - closed
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

This merge request was closed by Kyle Katarn. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

1 0

[PATCH v2 0/2] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

ComDlg32 / Color picker does not use "limited" value, leading to out of bound This cause the lum bar to get crazy ![image](/uploads/ed7511b46d1aa89e2828ddcb10f8816c/image.png) ![image](/uploads/c4d8b78416bf24929aca9a308baebd94/image.png) -- v2: Update ipaddress.c https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

2 2

[PATCH 0/1] MR4746: ComDlg32 / Color picker does not use "limited" value, leading to out of bound
by Kyle Katarn (＠KRosUser) 27 Dec '23

27 Dec '23

ComDlg32 / Color picker does not use "limited" value, leading to out of bound This cause the lum bar to get crazy ![image](/uploads/ed7511b46d1aa89e2828ddcb10f8816c/image.png) ![image](/uploads/c4d8b78416bf24929aca9a308baebd94/image.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4746

2 1

[PATCH 0/2] MR4745: Finnish translation
by Lauri Kenttä 27 Dec '23

27 Dec '23

None -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4745

1 2

Re: [PATCH v2 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Dāvis Mosāns 27 Dec '23

27 Dec '23

On Wed Dec 27 01:54:00 2023 +0000, Jinoh Kang wrote: > You're correct that debuggers can be sensitive to the timing of the > initial breakpoint. > Adding a conformance test would let us confirm your observation, and > ensure such regression won't happen in the future. For reference, see 2b40969c58a099f958c58909b666915991a42979. > I'm still approving since the existing tests did not fail and I cannot > find a particular reason `process_breakpoint();` must be placed exactly > there in the commit history. I'm not really sure how to write test case for this, seems quite complicated since basically need to load DLL with `int3` - if it's triggered after system breakpoint then it's a pass. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655#note_56427

1 0