December 2023 - Wine-gitlab

[PATCH v6 0/7] MR4380: mshtml: Keep inner window's link to the outer window until it's destroyed.
by Gabriel Ivăncescu 04 Dec '23

04 Dec '23

Here's a list of usages of `base.outer_window` that may be impacted by the change and my analysis/fixes. Note that I specifically did not look for `document->outer_window` since that one was already holding it forever, so it's out of scope for this MR (whether it's correct or not, the behavior is the same after this MR). I also didn't consider some cases that already **did not check** for it being NULL or not, because they would have crashed earlier before anyway (they'd still crash now if outer window gets killed, but it's out of scope of the MR as I said). For those that says "Handled" it means I've added checks so that the behavior is same as before, i.e. detached inner windows behave as if outer window is NULL. * `htmldoc.c/HTMLDocument_get_mimeType`: Changed so it doesn't rely on outer window. * `htmldoc.c/HTMLDocument7_get_defaultView`: This is actually fixed by these patches. * `htmlform.c/HTMLFormElement_submit`: Handled. * `htmlstorage.c/send_storage_event`: Fixed in a separate patch with tests, since it follows the outer window. * `htmlwindow.c/check_target_origin`: This (along with many other methods) can't have it NULL anymore or detached, since the caller must hold a ref to the outer window, and they're not called from our objects holding ref to inner window only. * `htmlwindow.c/HTMLWindowSP_QueryService`: This uses the outer window to obtain the browser and the doc obj, so it's fine. * `mutation.c/set_document_mode`: Handled. * `navigate.c/BindCallbackRedirect_Redirect`: Handled. * `navigate.c/nsAsyncVerifyRedirectCallback_OnRedirectVerifyCallback`: Handled. * `navigate.c/nsChannelBSC_init_bindinfo`: Uses the outer window to obtain the browser and doc obj to set a flag, so it's harmless and probably correct this way. * `navigate.c/handle_navigation_error`: Handled. * `navigate.c/handle_extern_mime_navigation`: Handled. * `omnavigator.c/OmHistory_get_length`: This is actually fixed by these patches. * `script.c/ActiveScriptSite_GetItemInfo`: Handled. * `script.c/ActiveScriptSiteWindow_GetWindow`: Handled. -- v6: mshtml/tests: Fix XHR leak in test_window_refs. mshtml: Get rid of outer_window member in HTMLDocumentNode. mshtml: Remove the inner window ref from the doc only when it is actually mshtml: Don't check for NULL outer_window from within HTMLWindow* methods. mshtml: Don't attempt to send storage events after outer window is detached. mshtml/tests: Improve the iframe navigation test. mshtml: Don't rely on the outer_window in document.mimeType. https://gitlab.winehq.org/wine/wine/-/merge_requests/4380

2 16

[PATCH v32 0/4] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 04 Dec '23

04 Dec '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v32: win32u: Add SNI driver for systray handling win32u: Add a SystrayRunLoop driver interface win32u: Refactor NotifyIcon driver interface into separate calls. win32u: Add a ShowBalloon driver interface https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 5

[PATCH v31 0/4] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 04 Dec '23

04 Dec '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v31: win32u: add SNI driver for systray handling win32u: add a SystrayRunLoop driver interface win32u: Refactor NotifyIcon driver interface into separate calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 17

Re: [PATCH v3 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Henri Verbeet (＠hverbeet) 04 Dec '23

04 Dec '23

Shouldn't this simply be a matter of adjusting the existing vkd3d_test_push_context() and vkd3d_test_pop_context() calls in run_shader_tests() to update the context for each line? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499#note_54856

1 0

[PATCH 0/2] MR503: vkd3d-shader/spirv: Silence fixmes for SV_TARGET.
by Conor McCarthy (＠cmccarthy) 04 Dec '23

04 Dec '23

Tests produce many spurious fixmes since SV_TARGET used to map to SV_NONE. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/503

3 3

[PATCH 0/8] MR4572: winevulkan: Use "host" instead of "native" and improve driver handle unwrapping.
by Rémi Bernon 04 Dec '23

04 Dec '23

We often use "native" to talk about Windows "native" code, which is confusing here. The unwrapping is also broken and always unwraps client handles to driver handles in the thunks, if they are wrapped. This currently forces every function that may be needing unwrapping to be handled in the drivers to unwrap the handles, which will be an issue if we intend to wrap VkSwapchainKHR in the drivers (which might be useful), and which requires to implement a lot of pass-through VkSurfaceKHR entry points. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4572

2 13

[PATCH v2 0/5] MR502: Draft: vkd3d-shader/d3d-asm: Add an "internal" mode for the ASM dumper.
by Giovanni Mascellani (＠giomasce) 04 Dec '23

04 Dec '23

-- v2: vkd3d-shader/d3d-asm: Add an "internal" mode for the ASM dumper. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/502

2 6

[PATCH 0/1] MR411: win32u: Don't load bitmap only TTF fonts without bitmap table.
by Paul Gofman (＠gofman) 04 Dec '23

04 Dec '23

The offending font is NotoColorEmoji.ttf which is present in, e. g., google-noto-emoji-color-fonts or noto-fonts-emoji packages available in various distribution. Attempting to load this font on Windows 10 (with AddFontResourceA() or open it with default font viewer) fails while currently succeeds on Windows. fontforge also refuses to open this font. That is because the font is bitmap only but missing bitmap table. Some apps (Glyph launcher is an example) try to GetOutlineTextMetrics() on this font and do not expect that to have an error return (as we currenly do), which leads to crash on unhandled division by zero exception. I am attaching a bitmap-only ttf test font (with only one bitmap) which I created with fontforge to make sure that such font can still be loaded in Wine. This font also loads on Windows (both with AddFontResourceA() and with default font viewer). There are other font types which can be legitimately missing EBDT table, but FT_Load_Sfnt_Table() returns a different error for those and my patch doesn't reject those fonts. [test.ttf](/uploads/b41472180b80c2c53f9dcc06055990f0/test.ttf) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/411

5 12

[PATCH 0/2] MR505: vkd3d-shader/dxil: Fix two small issues.
by Conor McCarthy (＠cmccarthy) 04 Dec '23

04 Dec '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/505

3 3

Re: [PATCH v3 0/1] MR499: tests: Print the line number of the probe when a test fails.
by Giovanni Mascellani (＠giomasce) 04 Dec '23

04 Dec '23

On Sat Dec 2 18:00:47 2023 +0000, Petrichor Park wrote: > (the change is to remove the `vkd3d_test_push_context` call on L1439, > and then I'd need to remove the matching `vkd3d_test_pop_context` call > that's somewhere) Currently we push the debug context when entering a section and pop it just before entering the following one. It would be enough to keep doing this for all except for the `[test]` section, and push and pull at each line inside a `[test]` section. Does this make sense for you? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/499#note_54833

1 0