February 2023 - Wine-gitlab

[PATCH 0/1] MR2295: msado15: Free recordset filter on close.
by Akihiro Sagawa (＠sgwaki) 27 Feb '23

27 Feb '23

Introduced by commit 669107f6c5e54f520a846caec9649163675784a4. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2295

2 1

Re: [PATCH v3 0/1] MR2291: win32u: replace calling unix functions by unix_call and remove callback unix_funcs
by Jacek Caban (＠jacek) 27 Feb '23

27 Feb '23

The plan for those functions is to use syscall interface (not unixlib calls), see https://gitlab.winehq.org/jacek/wine/-/commits/wow/. We can't merge it yet because printer driver needs refactoring first (with current code, wineps.drv is a PE file that exposes GDI driver, so we still do some unixlib->PE calls in win32u). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2291#note_25557

1 0

[PATCH 0/3] MR2293: gdi32/tests: Fix the SetDeviceGammaRamp() tests on Windows 10 1909.
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2293

3 4

[PATCH v11 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v11: winspool: Check dmSize in IsValidDevmodeWw https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

4 4

[PATCH v3 0/1] MR2288: kernel32:locale: Fix the French GetNumberFormatEx() test on Windows 11.
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

Windows 11 uses a narrow non-breaking space instead of a plain one when formatting numbers. This is probably more correct and maybe Wine should switch too. But marking the old result as broken() would require unbundling expect_wstr() which would be bothersome. So this commit just accepts both. -- v3: kernel32/tests: Fix the French GetNumberFormatEx() test on Windows 11. https://gitlab.winehq.org/wine/wine/-/merge_requests/2288

2 3

[PATCH v2 0/1] MR2133: Draft: ntdll/tests: Minimize the stack size for test_tp_multi_wait().
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- v2: ntdll/tests: Minimize the stack size for test_tp_multi_wait(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2133

2 2

Re: [PATCH v4 0/2] MR2282: d3d9: Disable instancing for not-indexed drawing
by Henri Verbeet (＠hverbeet) 27 Feb '23

27 Feb '23

There are some minor style and formatting issues in this series that I'm going to ignore for the moment. The test either doesn't test the changes in patch 2/2, or it fails before that patch. The larger issue with this series though is that it doesn't seem quite ideal to potentially set and restore the stream source frequency on each DrawPrimitive()/DrawPrimitiveUP() call, because of the resulting state invalidation. It may be time to move the d3d9-style instance count handling out of wined3d and track that entirely in d3d9. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2282#note_25548

1 0

[PATCH v3 0/2] MR2213: Draft: Debug GitLab's kernel32:heap failures in test_GlobalMemoryStatus()
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- v3: DEBUG kernel32:heap: Trace the GlobalMemoryStatus() results for the GitLab CI failures. https://gitlab.winehq.org/wine/wine/-/merge_requests/2213

3 4

[PATCH 0/1] MR2281: nsi: Simplify and better document NsiAllocateAndGetTable().
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2281

3 3

[PATCH v10 0/1] MR2262: winspool: Check dmSize in IsValidDevmodeW
by Tingzhong Luo (＠tzluo) 27 Feb '23

27 Feb '23

When dmSize is zero or greter than size of input buffer, `IsValidDevmodeW()` failed in Windows 10. But current implementation in wine, it will return `true` because there is no check to `dm.dmSize`. -- v10: winspool: Check dmSize in IsValidDevmodeW https://gitlab.winehq.org/wine/wine/-/merge_requests/2262

2 1