February 2023 - Wine-gitlab

[PATCH 0/2] MR2213: Draft: Debug GitLab's kernel32:heap failures in test_GlobalMemoryStatus()
by Francois Gouget (＠fgouget) 15 Feb '23

15 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2213

3 3

[PATCH 0/3] MR93: vkd3d-shader/hlsl: Two bug fixes.
by Francisco Casas (＠fcasas) 15 Feb '23

15 Feb '23

Currently, we can't use add_load_index() or add_load_component() on the loads to the `"retval"` variables that come from `add_call()` because these functions assume that the loaded value (`var_instr`) won't change between its location and the location and the new load to be created. We can't get rid of this assumptions either, because, at least `add_load_index()` may be used in the lhs of an assignment, and in that case we can't store to the "deref" synthetic: ``` x[0] = 20; ``` Here I implemented the alternative solution of copying `"retval"` into a synthetic variable after each function call, but we may want to discuss this approach. The second problem this that is covered in 3/3 is fixing the number of components of the swizzle instructions generated by copy-prop, without it, the following assertion in `hlsl_sm4.c` fails for me ```c /* Narrowing casts were already lowered. */ assert(src_type->dimx == dst_type->dimx); ``` for some tests, in one of my branches, because of narrowing casts may end up appearing if the node is replaced with a node with more components. This error happens under quite complex conditions (involving casts and matrices) that I still try to narrow down, but I think that the fix is logical enough, without it, the asserts introduced in the patch fail in many tests. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/93

3 5

[PATCH 0/1] MR2212: riched20/tests: Add context to the EM_FORMATRANGE tests.
by Francois Gouget (＠fgouget) 15 Feb '23

15 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2212

3 2

[PATCH v2 0/1] MR92: vkd3d-shader/hlsl: Write SM4 break instructions.
by Giovanni Mascellani (＠giomasce) 15 Feb '23

15 Feb '23

-- v2: vkd3d-shader/hlsl: Write SM4 break instructions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/92

4 4

[PATCH v2 0/1] MR90: vkd3d-shader/hlsl: Improve mul vs dp* selection for dot().
by Nikolay Sivov (＠nsivov) 15 Feb '23

15 Feb '23

-- v2: vkd3d-shader/hlsl: Use mul only for two scalars for dot(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/90

4 3

[PATCH 0/4] MR2210: include: Some fixes related to IME functions.
by Rémi Bernon 15 Feb '23

15 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2210

2 5

[PATCH v2 0/4] MR2208: msvcrt: Improve error handling in getenv.
by Piotr Caban (＠piotr) 15 Feb '23

15 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54486 -- v2: msvcrt: Improve error handling in _wgetenv_s. msvcrt: Improve error handling in getenv_s. https://gitlab.winehq.org/wine/wine/-/merge_requests/2208

3 5

Re: [PATCH v5 0/1] MR80: vkd3d-shader/hlsl: Support reflect() intrinsic.
by Giovanni Mascellani (＠giomasce) 15 Feb '23

15 Feb '23

On Wed Feb 15 13:55:41 2023 +0000, Nikolay Sivov wrote: > Hi, @giomasce. Is anything blocking this MR? I'd like to see more tests that `reflect()` really behaves like on native with different types combinations. For example, what happens if you call `reflect()` on a `float` and a `float2`? Or on a `float2` and a `float3`? From my tests, it seems that the current implementation is correct, but it would be nice to have this shown by tests, so that we don't regress it in the future. It should be quite a quick thing to do. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/80#note_24372

1 0

[PATCH v9 0/5] MR2091: windows.media.speech: Initial Unixlib work.
by Bernhard Kölbl 15 Feb '23

15 Feb '23

Second commit is to be removed. Signed-off-by: Bernhard Kölbl <besentv(a)gmail.com> -- v9: windows.media.speech: Implement Vosk create and release functions in the unixlib. https://gitlab.winehq.org/wine/wine/-/merge_requests/2091

4 20

[PATCH 0/4] MR2208: msvcrt: Improve error handling in getenv.
by Piotr Caban (＠piotr) 15 Feb '23

15 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54486 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2208

2 4