March 2023 - Wine-gitlab - list.winehq.org

[PATCH v6 0/3] MR2449: win32u: Add a few device GPU properties.
by Paul Gofman (＠gofman) 28 Mar '23

28 Mar '23

Diablo IV (closed beta) depends on DEVPKEY_Device_MatchingDeviceId being present for GPUs (once it is able to match GPU luid to the one obtained from dxgi). It also depends on the MatchingDeviceId conating "ven_" and "dev_" substrings. Without those it doesn't consider the gpu as valid, which currently results in the game complaining about no GPUs found. I guess that maybe it is trying to filter out software GPUs and such this way. As far as my testing goes, DEVPKEY_Device_MatchingDeviceId has this form with hardware GPUs only and maybe with the recent enough Win10 or Win11. The other two device properties being added are also queried by the game although they are not strictly needed for it. -- v6: win32u: Set DEVPKEY_Device_RemovalPolicy for GPUs. win32u: Set DEVPKEY_Device_BusNumber for GPUs. win32u: Set DEVPKEY_Device_MatchingDeviceId for GPUs. https://gitlab.winehq.org/wine/wine/-/merge_requests/2449

3 6

[PATCH v5 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) 28 Mar '23

28 Mar '23

I initially wanted to do the refactoring in a separate merge request, but since my merge request yesterday broke the tests, I decided to add the implementation into this commit as well. -- v5: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. kernelbase: Call create_key() from create_subkey(). kernelbase: Factor creating a subkey out of create_key(). kernelbase: Don't open Wow6432nodes from create_key(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 6

[PATCH v7 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 28 Mar '23

28 Mar '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by ~~only opening the file with write access where necessary~~ temporarily modifying file access permisions to allow the file to be opened. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v7: server: Allow to open files without permission bits. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

3 5

[PATCH 0/11] MR2522: wineps: Add support for more spool file records
by Piotr Caban (＠piotr) 28 Mar '23

28 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2522

3 12

[PATCH v5 0/1] MR2429: msvcrt100: Add stub implementation for _UnrealizedChore::CheckTaskCollection
by Vijay Kiran Kamuju (＠infyquest) 28 Mar '23

28 Mar '23

Add stub implementation for _UnrealizedChore::CheckTaskCollection https://bugs.winehq.org/show_bug.cgi?id=53794 -- v5: msvcr100: Add _UnrealizedChore::_CheckTaskCollection stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2429

3 3

[PATCH v3 0/1] MR2482: dwrite: Use cache when font transform matrix contains only translation offsets.
by Zhiyi Zhang (＠zhiyi) 28 Mar '23

28 Mar '23

Word 2016 queries a lot of font glyph bounding boxes and bitmaps with translation matrices. The result of these queries is not cached because the transform matrix is not the identity matrix. However, the translation offsets don't affect FreeType font operations at all, which can be verified in ft_matrix_from_dwrite_matrix() called by get_glyph_transform(). So these results with translation matrices can be cached as well. With this patch, Word 2016 stuttering is reduced significantly. -- v3: dwrite: Use cache when font transform matrix contains only translation offsets. https://gitlab.winehq.org/wine/wine/-/merge_requests/2482

3 3

[PATCH 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Rémi Bernon 28 Mar '23

28 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520

3 14

[PATCH v6 0/4] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 28 Mar '23

28 Mar '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v6: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES server: Open files for writing with O_WRONLY not O_RDWR if FILE_READ_ATTRIBUTES is also requested https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

4 9

[PATCH v10 0/3] MR741: ntdll: Implement NtFlushProcessWriteBuffers.
by Torge Matthies (＠tmatthies) 28 Mar '23

28 Mar '23

Based on [a patch](https://www.winehq.org/mailman3/hyperkitty/list/wine-devel(a)winehq.… by Jinoh Kang (@iamahuman) from February 2022. I removed the need for the event object and implemented fast paths for Linux. On macOS 10.14+ `thread_get_register_pointer_values` is called on every thread of the process. On Linux 4.14+ `membarrier(MEMBARRIER_CMD_GLOBAL_EXPEDITED, ...)` is used. On x86 Linux <= 4.13 and on other platforms `madvise(..., MADV_DONTNEED)` is used, which sends IPIs to all cores causing them to do a memory barrier. -- v10: ntdll: Add thread_get_register_pointer_values-based implementation of NtFlushProcessWriteBuffers. ntdll: Add sys_membarrier-based implementation of NtFlushProcessWriteBuffers. ntdll: Add MADV_DONTNEED-based implementation of NtFlushProcessWriteBuffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/741

2 3

[PATCH 0/1] MR2418: ucrtbase: adding CxxFrameHandler4 to spec
by James McDonnell (＠ElementalWarrior) 28 Mar '23

28 Mar '23

Add missing function to spec for affinity photo -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2418

3 4