March 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR2399: d3d11: Get rid of the DXBC tag definitions.
by Henri Verbeet (＠hverbeet) 14 Mar '23

14 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2399

3 3

[PATCH v3 0/1] MR2376: wintypes: Stub RoIsApiContractMajorVersionPresent().
by Daniel Tang (＠danielzgtg) 14 Mar '23

14 Mar '23

This is one of the stubs required for MS Office 365. -- v3: wintypes: Stub RoIsApiContractMajorVersionPresent(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2376

4 6

[PATCH 0/1] MR2157: ntdll/unix: Init the trap handler.
by eric pouech (＠epo) 14 Mar '23

14 Mar '23

Otherwise we get nested exceptions on linux on any breakpoint in a multi-arch wow64 (AMD64) configuration, running a 32bit debuggee. With this patch, winetest kernel32:debugger runs to the end (it times out without), yet spitting a couple of failures (that don't exist in old wow64 configuration). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2157

2 4

[PATCH 0/6] MR2389: wined3d: Deduplicate the different get_line() variants.
by Henri Verbeet (＠hverbeet) 14 Mar '23

14 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2389

4 8

[PATCH 0/5] MR2360: wined3d: move stubs out of state tables
by Max Figura (＠maxfigura) 14 Mar '23

14 Mar '23

Removing WINED3D_RS entries from state tables and moving stubs to wined3d_device_apply_stateblock. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2360

4 7

[PATCH 0/5] MR2353: ddraw: SetSurfaceDesc() refactoring, part 3.
by Zebediah Figura (＠zfigura) 14 Mar '23

14 Mar '23

In truth this part is actually just ddraw_surface_create() refactoring, but it came about while working on SetSurfaceDesc()... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2353

4 8

[PATCH 0/1] MR2390: winegstreamer: Cache wg_parser input data.
by Derek Lesho (＠dlesho) 14 Mar '23

14 Mar '23

On my Steam Deck, this reduces the time it takes to initialize the wg_parser radically (by around 1 second). This helps in the game WILD HEARTS, which doesn't present while loading help videos during gameplay, causing large stutters. Because GStreamer can randomly access the file with no known pattern on our side, I opted to implement this by buffering 4 chunks so that interleaved reads to different areas of the file don't cause us to discard and reload cached data more than we need to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2390

3 3

Re: [PATCH v2 0/16] MR2386: windows.perception.stub: Implement IHolographicSpaceStatics2/3 interfaces.
by Rémi Bernon 14 Mar '23

14 Mar '23

Rémi Bernon (@rbernon) commented about include/windows.graphics.holographic.idl: > +import "windows.graphics.directx.direct3d11.idl"; > +import "windows.perception.idl"; > +import "windows.perception.spatial.idl"; > +import "windows.ui.core.idl"; > + > +namespace Windows.Graphics.Holographic { > + typedef enum HolographicFramePresentResult HolographicFramePresentResult; > + typedef enum HolographicFramePresentWaitBehavior HolographicFramePresentWaitBehavior; > + typedef struct HolographicAdapterId HolographicAdapterId; > + typedef struct HolographicStereoTransform HolographicStereoTransform; > + > + interface IHolographicCameraPose; > + interface IHolographicCameraRenderingParameters; > + interface IHolographicFrame; > + interface IHolographicFramePrediction; > + interface IHolographicSpaceStatics2; If you only forward declare `IHolographicSpaceStatics` here, you don't need its definition later in the file, as you also don't implement it. This then makes 5ec7b6eecc89f2e88df836e1e68c9d59fa640816 ad31506143de193058129e2981818b6e7fc5c252 8fbfa09fd86eb7306688e0914c44964860165a0d 2e1f8bd100e040e8025c5801cecdf7636187582c aaeb3ffc5ce074ddea6a16e5b28788f73b1fd12c also unnecessary, which to be honest, seems appealing to me at least from a review perspective, given the number of new classes and interfaces. Of course, we might need them later and could be useful to keep them around, but then it would be nice to have it done more gradually if possible. Regarding 04ee932ff5e261b9aceee47542f91aa6b4f115c1, and for similar changes, it'd be nice to make smaller additions, for instance adding one interface definition at a time (and its dependencies if they aren't too much, or add them beforehand), so that reviewing what needs what is easier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2386#note_26841

1 0

[PATCH v2 0/1] MR2367: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests.
by Alex Henrie (＠alexhenrie) 14 Mar '23

14 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54640 -- v2: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2367

3 2

[PATCH v4 0/4] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon 14 Mar '23

14 Mar '23

-- v4: winex11: Remove now unnecessary user locale change checks. win32u: Prevent user locale change in NtUserActivateKeyboardLayout. win32u: Keep the current user locale when loading layout. win32u: Keep the current user locale when enumerating layouts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

1 5