March 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR2385: openssh installer by chocolatey fails to install because of missing regkey.
by Louis Lenders (＠xe) 12 Mar '23

12 Mar '23

See https://community.chocolatey.org/packages/openssh#files (tools\chocolateyinstall.ps1) $EditionId = (Get-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Windows NT\CurrentVersion' -Name 'EditionID').EditionId -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2385

3 3

[PATCH v3 0/2] MR2240: Winedbg to load 64bit modules for a wow64 debuggee in multi-arch config.
by eric pouech (＠epo) 12 Mar '23

12 Mar '23

This series intent is to let winedbg (and dbghelp) load the 64bit PE modules of a wow64 debuggee. At this stage, all debug info of all modules (PE and ELF) are properly loaded (and displayed with 'info wow share' command). Breakpoint and backtrace in 64bit code of a wow64 debuggee are not available. The serie contains: - extension of tests to show that 64bit load dll events are generated for a wow64 debuggee (for a 64bit debugger, not for a 32bit one) - change for adapting filtering of events I opted for doing it in ntdll and passing the machine of the mapping in request's reply. Please advisde if you'd prefer another approach. -- v3: server,ntdll,wow64: Move filter of (un)load DLL debug events to client side. kernel32/tests: Extend the tests for load/unload debug events on Wow64. https://gitlab.winehq.org/wine/wine/-/merge_requests/2240

2 3

[PATCH v2 0/1] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) 12 Mar '23

12 Mar '23

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- v2: shell32: Avoid stack corruption caused by long URLs https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 2

[PATCH v4 0/1] MR2372: kernel32/tests: Fix tls callback tests on Windows 7
by Evan Tang (＠etang-cw) 12 Mar '23

12 Mar '23

Fixes broken tests introduced in 2203a8564c5faba383a3512f8244dba12d79da16 Looks like on Windows 7, if a dll has no entry point, no tls callbacks are run. On Windows 10, the `DLL_PROCESS_ATTACH` is run but nothing else. By having an entry point, everything is run like you'd expect Also changes the tests to test the full set of process/thread attach/detach -- v4: kernel32/tests: Fix tls callback tests on Windows 7 https://gitlab.winehq.org/wine/wine/-/merge_requests/2372

3 2

[PATCH 0/1] MR2379: windows.networking: Stub DllGetActivationFactory().
by Daniel Tang (＠danielzgtg) 11 Mar '23

11 Mar '23

With this MR, now I can create documents in Word. Applied together with my other patches, we will have the 3 main apps of Microsoft Office working! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2379

3 2

[PATCH 0/1] MR2383: shell32: Avoid stack corruption caused by long URLs
by Stefan Rentsch (＠restet) 11 Mar '23

11 Mar '23

Previously long URI/URLs (> 1024 characters) would cause a stack corruption and crash Wine. After this MR, Wine will no longer crash but the URL is not opened either primarily due to `SHELL_Argify` limitations. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2383

3 2

[PATCH 0/1] MR2375: wofutil: Stub WofIsExternalFile().
by Daniel Tang (＠danielzgtg) 11 Mar '23

11 Mar '23

This fixes a crash in `OneDriveSetup.exe`. It still doesn't install with "A supported version of Windows 10 or Windows 11 is required to proceed," but at least it doesn't crash. After this patch, we can now see the OneDrive logo, the progress bar, and the "Installing OneDrive" label. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2375

3 3

[PATCH v3 0/1] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) 11 Mar '23

11 Mar '23

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v3: sppc: Add stubs for MS Office. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

4 4

[PATCH 0/3] MR2382: npptools: Add CreateBlob and DestroyBlob stubs.
by Alex Henrie (＠alexhenrie) 11 Mar '23

11 Mar '23

After stubbing the two functions, the program is able to at least print its help text and describe what it can do. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54671 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2382

2 3

[PATCH v2 0/1] MR2369: comdlg32/tests: Fix itemdlg tests on Windows.
by Florian Will (＠w-flo) 11 Mar '23

11 Mar '23

I'm not sure if the GetTempPathW() dir is okay for this. d3dx11 seems to do the same in tests, so I copied that approach. Commit message: The wine testbot runs tests with C:\Users\Public\Documents as the working directory. Itemdlg tests create test files in the working directory and then try to select them for opening in an IFileOpenDialog. The dialog has its SetFolder method called to point it to the current working directory before showing the dialog, in order for the test code to find the test files it had created there just before opening the dialog. On Windows, this failed because calling the dialog's SetFolder method with C:\Users\Public\Documents doesn't work as expected. The dialog points to the C:\Users\\[CURRENT_USER]\Documents directory instead. Subsequently, the test would be unable to select the test file because it doesn't exist in that directory. So the dialog wouldn't accept the file and close itself to finish the test, but show an error message instead, resulting in a test timeout. To fix this, set the current working directory to the temporary directory before calling individual itemdlg test_* functions. Switch back to the previous working directory after tests finish. -- v2: comdlg32/tests: Fix itemdlg tests on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/2369

2 1