April 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/4] MR2564: winex11: Preparatory IME cleanup.
by Rémi Bernon 05 Apr '23

05 Apr '23

Same as https://gitlab.winehq.org/wine/wine/-/merge_requests/2563 but on winex11 side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2564

1 5

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Rémi Bernon 04 Apr '23

04 Apr '23

On Tue Apr 4 20:42:52 2023 +0000, Byeongsik Jeon wrote: > On a recent review, I realized that I hadn't analyzed this issue > properly, and the problem had already been fixed by another commit. > https://gitlab.winehq.org/wine/wine/-/commit/f6ddd4ca86672fe2739ea7d1701511… > The cause of the problem was that the wrong parameter value(new_context) > was being passed to ImeSelect(). Because of this, ImeSelect() didn't > work properly and kept the fdwConversion value of the wrong value (fdwConversionCaps). > For example, in ImeSelect(), fdwConversion is initialized in the > following routine: > ``` > if ( !( lpIMC->fdwInit & INIT_CONVERSION ) ) > { > lpIMC->fdwConversion = IME_CMODE_NATIVE; > lpIMC->fdwInit |= INIT_CONVERSION; > } > ``` > If the IME follows this initialization routine, the values of > fdwConversion, fdwSentence set in ime_select_ime() will be ignored. I guess maybe we'd have to clear the `fdwInit` flag before calling `ImeSelect`? As far as I could see in the tests, the `fdwConversion` and `fdwSentence` fields aren't modified by imm32 and left for the IME to reset or not. It caused some spurious failures before 7d03937abe899db810c983779f2566b94d787e8a with the fields keeping the values from the default (MS) IME. The tests also suggest that the values are cached between different IME selections, unlike what Wine is currently doing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520#note_28984

1 0

[PATCH v2 0/2] MR2496: Draft: Fix hang when a program calls IMFMediaSession_Start with an invalid source.
by Santino Mazza (＠tati1454) 04 Apr '23

04 Apr '23

This fixes a bug when the session topology contains an invalid source, which makes the session thread to hang and stop executing commands. -- v2: mf: Handle errors when subscribing to events. mf/tests: Test media session error handling. https://gitlab.winehq.org/wine/wine/-/merge_requests/2496

3 4

Re: [PATCH v2 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.
by Byeongsik Jeon (＠bsjeon) 04 Apr '23

04 Apr '23

On Tue Mar 28 10:35:26 2023 +0000, Byeongsik Jeon wrote: > Saenaru. This is not an MS IME, but a DDK-based open source Korean IME. > I think you can check this in the Wine test code. On a recent review, I realized that I hadn't analyzed this issue properly, and the problem had already been fixed by another commit. https://gitlab.winehq.org/wine/wine/-/commit/f6ddd4ca86672fe2739ea7d1701511… The cause of the problem was that the wrong parameter value(new_context) was being passed to ImeSelect(). Because of this, ImeSelect() didn't work properly and kept the fdwConversion value of the wrong value (fdwConversionCaps). For example, in ImeSelect(), fdwConversion is initialized in the following routine: ``` if ( !( lpIMC->fdwInit & INIT_CONVERSION ) ) { lpIMC->fdwConversion = IME_CMODE_NATIVE; lpIMC->fdwInit |= INIT_CONVERSION; } ``` If the IME follows this initialization routine, the values of fdwConversion, fdwSentence set in ime_select_ime() will be ignored. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2520#note_28981

1 0

Re: [PATCH v3 0/5] MR2566: uiautomationcore: Initial default ProviderType_BaseHwnd clientside provider implementation. - approved
by Alexandre Julliard (＠julliard) 04 Apr '23

04 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2566

1 0

Re: [PATCH v2 0/1] MR2512: wined3d: Rotate vk bind masks in wined3d_swapchain_vk_rotate. - approved
by Alexandre Julliard (＠julliard) 04 Apr '23

04 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2512

1 0

[PATCH 0/4] MR2586: quartz/vmr9: Clean up IVMRFilterConfig9::SetRenderingMode().
by Zebediah Figura (＠zfigura) 04 Apr '23

04 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2586

2 4

Re: [PATCH v7 0/7] MR2568: win32u: Support setting the current mode using gdi_device_manager. - approved
by Alexandre Julliard (＠julliard) 04 Apr '23

04 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2568

1 0

Re: [PATCH v3 0/1] MR2579: kernel32/debugger: Fix a failing test (on Wine). - approved
by Alexandre Julliard (＠julliard) 04 Apr '23

04 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2579

1 0

Re: [PATCH v2 0/1] MR2576: winex11.drv: Fix a typo. - approved
by Alexandre Julliard (＠julliard) 04 Apr '23

04 Apr '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2576

1 0