May 2023 - Wine-gitlab - list.winehq.org

[PATCH v11 0/3] MR2808: Draft: SNI tray implementation
by Cherser-s (＠Cherser-s) 18 May '23

18 May '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v11: configure: fix winesni.drv not getting disabled https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

4 6

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Ethan Lee (＠flibitijibibo) 18 May '23

18 May '23

On Thu May 18 20:36:57 2023 +0000, Giovanni Mascellani wrote: > No, I don't think the caller gets to decide anything. The optimizing > pass can either decide to alter the instruction stream (if it thinks > there is some optimization to be done) or leave it unchanged. In the > first case it returns `true`, in the second `false`. The caller will > receive whatever stream the pass decides to leave. > In this case, however, I don't think there is any question about whether > to touch or not the instruction stream. We definitely want to fold the > absolute value operation, since it's pretty clear that for the native > compiler `abs(INT_MIN) == INT_MIN`. The only care we have to use is to > never call `abs(INT_MIN)` in C, because that's UB. If you use the > statement I provided above that should never happen and everything is fine. Ahh, okay that makes sense - I'll go ahead and make this change now; knowing the native compiler's result cleared this up right away! -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33148

1 0

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Giovanni Mascellani (＠giomasce) 18 May '23

18 May '23

On Thu May 18 20:32:04 2023 +0000, Ethan Lee wrote: > If I'm understanding correctly, the folding pass makes a temporary node > that the fold functions write into - the fold function can either > successfully inline an op into a constant that can replace the op node, > or it can't and the temporary node is discarded, leaving the original > node list alone. > It sounds like the intended change to the current revision is to always > assign the full constant value even if it turns out to be invalid - that > is, the caller can either listen to the return value and discard the dst > node, or use it at their own risk... does that make sense? No, I don't think the caller gets to decide anything. The optimizing pass can either decide to alter the instruction stream (if it thinks there is some optimization to be done) or leave it unchanged. In the first case it returns `true`, in the second `false`. The caller will receive whatever stream the pass decides to leave. In this case, however, I don't think there is any question about whether to touch or not the instruction stream. We definitely want to fold the absolute value operation, since it's pretty clear that for the native compiler `abs(INT_MIN) == INT_MIN`. The only care we have to use is to never call `abs(INT_MIN)` in C, because that's UB. If you use the statement I provided above that should never happen and everything is fine. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33147

1 0

[PATCH v5 0/2] MR2821: wined3d: Improve d3d8 compatibility of minification and magnification filters.
by Sebastian Mayr (＠smayr) 18 May '23

18 May '23

This fixes the visual glitches and crashes of Worms Blast that were reported here: https://bugs.winehq.org/show_bug.cgi?id=54898 (and here: https://github.com/ValveSoftware/Proton/issues/706) There is, however, still an issue with the background music, which is not playing. -- v5: wined3d: Improve d3d8 compatibility of texture filters. d3d8/tests: Test IDirect3DDevice8::ValidateDevice() with various min, mag and mip filters. https://gitlab.winehq.org/wine/wine/-/merge_requests/2821

5 7

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Ethan Lee (＠flibitijibibo) 18 May '23

18 May '23

On Thu May 18 20:30:01 2023 +0000, Giovanni Mascellani wrote: > I think that what we want is: > ``` > dst->value.u[k].i = src->value.u[k].i == INT_MIN ? INT_MIN : abs(src->value.u[k].i); > ``` If I'm understanding correctly, the folding pass makes a temporary node that the fold functions write into - the fold function can either successfully inline an op into a constant that can replace the op node, or it can't and the temporary node is discarded, leaving the original node list alone. It sounds like the intended change to the current revision is to always assign the full constant value even if it turns out to be invalid - that is, the caller can either listen to the return value and discard the dst node, or use it at their own risk... does that make sense? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33144

1 0

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Giovanni Mascellani (＠giomasce) 18 May '23

18 May '23

On Thu May 18 20:28:51 2023 +0000, Zebediah Figura wrote: > I don't understand, why would it break the result? I think that what we want is: ``` dst->value.u[k].i = src->value.u[k].i == INT_MIN ? INT_MIN : abs(src->value.u[k].i); ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33143

1 0

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Zebediah Figura (＠zfigura) 18 May '23

18 May '23

On Thu May 18 20:23:30 2023 +0000, Ethan Lee wrote: > This change seems like it would break the result - do we want it to be > more like > ``` > bool success = true; > ... > case HLSL_TYPE_INT: > /* Always evaluate this expression... */ > dst->value.u[k].i = abs(src->value.u[k].i); > /* ... but if we try abs(INT_MIN), mark this fold as > invalid */ > if (src->value.u[k].i == INT_MIN) > { > success = false; > } > break; > ... > return success; > ``` I don't understand, why would it break the result? -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33142

1 0

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Ethan Lee (＠flibitijibibo) 18 May '23

18 May '23

On Thu May 18 20:22:26 2023 +0000, Francisco Casas wrote: > Indeed, I didn't have the big picture in mind. returning false keeps the > original instruction. > However, I also think that we should go for the change in case we ever > call hlsl_fold_constant_exprs() from somewhere else. This change seems like it would break the result - do we want it to be more like ``` bool success = true; ... case HLSL_TYPE_INT: /* Always evaluate this expression... */ dst->value.u[k].i = abs(src->value.u[k].i); /* ... but if we try abs(INT_MIN), mark this fold as invalid */ if (src->value.u[k].i == INT_MIN) { success = false; } break; ... return success; ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33141

1 0

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Francisco Casas (＠fcasas) 18 May '23

18 May '23

On Thu May 18 20:19:08 2023 +0000, Zebediah Figura wrote: > > I might have misread, but doesn't the return value apply to the full > vector and not its components? I thought returning false made it so the > whole abs op was left alone if any component was INT_MIN, like an > all-or-nothing deal. > That is the case, yes. That said, I believe we want to make that change anyway. Indeed, I didn't have the big picture in mind. returning false keeps the original instruction. However, I also think that we should go for the change in case we ever call hlsl_fold_constant_exprs() from somewhere else. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33140

1 0

Re: [PATCH v4 0/1] MR203: vkd3d-shader/hlsl: Fold constant integral abs().
by Zebediah Figura (＠zfigura) 18 May '23

18 May '23

> I might have misread, but doesn't the return value apply to the full vector and not its components? I thought returning false made it so the whole abs op was left alone if any component was INT_MIN, like an all-or-nothing deal. That is the case, yes. That said, I believe we want to make that change anyway. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/203#note_33139

1 0