May 2023 - Wine-gitlab - list.winehq.org

[PATCH v5 0/26] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Vijay Kiran Kamuju (＠infyquest) 13 May '23

13 May '23

Add the stub function D3DXComputeTangent based on the staging patch. https://bugs.winehq.org/show_bug.cgi?id=41697 Since this will at least make the application go further. Even though the implementation is based on documentation https://learn.microsoft.com/en-us/windows/win32/direct3d9/d3dxcomputetangent -- v5: d3dx9: Stub D3DXComputeTangent wineps: Store font substitution table in DEVMODE. wineps: Store data from PPD file used in unixlib in DEVMODE. wineps: Use standard DEVMODEW structure instead of PSDRV_DEVMODE when possible. wineps: Remove unused fields from PSDRV_DEVMODE. wineps: Remove gdi_physdev from print_ctx structure. winemac: Use the default IME implementation for ImeSetCompositionString. winex11: Use the default IME implementation for ImeSetCompositionString. kernelbase/tests: Use win_skip() for missing APIs. kernel32/tests: Use win_skip() for missing APIs. qcap/tests: Test the audio capture CLSID. qcap/tests: Test audio capture pin information. qcap/tests: Test audio capture pin interfaces. qcap/audiorecord: Add a stub source pin. qcap/audiorecord: Get rid of the AudioRecord typedef. kernelbase: Move Wow64EnableWow64FsRedirection() from kernel32 to kernelbase. win32u: Don't export wow64 Unix call functions. ntdll: Move the Unix function tables to avoid forward declarations, and make them static. ntdll: Add a helper function to free a range of pages. ntdll: Add logging for free ranges. ntdll: Support partial view release in NtFreeVirtualMemory(). ntdll: Factor out some view manipulation functions. ntdll: Fully support unaligned views in free ranges management. ntdll: Fix size validation in NtFreeVirtualMemory(). kernelbase: Validate nonzero size for MEM_RELEASE in VirtualFreeEx(). ntdll/tests: Add tests for freeing a part of view. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/2795

2 1

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Vijay Kiran Kamuju (＠infyquest) 13 May '23

13 May '23

On Fri May 12 21:14:16 2023 +0000, Zebediah Figura wrote: > I kind of ask because—while I don't want to hold up progress upstream—as > the person who is both maintaining the Wine-Staging patch, and working > on (admittedly long stalled) actual tests for tangents, if this doesn't > actually help the bug, all this patch is going to do is add more rebase > headache for me. I know that this makes staging rebase as mess, this is necessary to reduce the stalled patches to be mainlined as its been ages. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32683

1 0

Re: [PATCH v2 0/5] MR2796: qcap: Audio capture filter implementation, part 2. - approved
by Alexandre Julliard (＠julliard) 12 May '23

12 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2796

1 0

Re: [PATCH v2 0/1] MR2802: wordpad: Resize buttons of toolbar to make them align with height of the font list combox. - approved
by Alexandre Julliard (＠julliard) 12 May '23

12 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2802

1 0

Re: [PATCH v4 0/4] MR2792: wine{alsa,coreaudio,oss,pulse}: Move AudioClock into mmdevapi. - approved
by Alexandre Julliard (＠julliard) 12 May '23

12 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2792

1 0

Re: [PATCH v3 0/8] MR2801: winemac: Use a new type of NtUserMessageCall to move IME input processing to imm32. - approved
by Alexandre Julliard (＠julliard) 12 May '23

12 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2801

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Zebediah Figura (＠zfigura) 12 May '23

12 May '23

On Fri May 12 21:07:04 2023 +0000, Matteo Bruni wrote: > Ah, now I realize I read the "go further" in the MR description as > "work". I'd like to know that too. I kind of ask because—while I don't want to hold up progress upstream—as the person who is both maintaining the Wine-Staging patch, and working on (admittedly long stalled) actual tests for tangents, if this doesn't actually help the bug, all this patch is going to do is add more rebase headache for me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32671

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Matteo Bruni (＠Mystral) 12 May '23

12 May '23

On Fri May 12 21:07:04 2023 +0000, Zebediah Figura wrote: > Does this actually make the program work? Ah, now I realize I read the "go further" in the MR description as "work". I'd like to know that too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32670

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Zebediah Figura (＠zfigura) 12 May '23

12 May '23

Does this actually make the program work? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32669

1 0

Re: [PATCH v4 0/1] MR2795: d3dx9_36: Stub D3DXComputeTangent
by Matteo Bruni (＠Mystral) 12 May '23

12 May '23

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/mesh.c: > return hr; > } > > +/************************************************************************* > + * D3DXComputeTangent (D3DX9_36.@) > + */ > +HRESULT WINAPI D3DXComputeTangent(ID3DXMesh *mesh, const DWORD stage_idx, DWORD tangent_idx, That "const" shouldn't be there. I guess it doesn't matter in practice but it does look quite weird. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2795#note_32666

1 0