May 2023 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/2] MR2700: msxml3: Rename msxml3 to winexml and point msxml* to it.
by Loïc Rebmeister 04 May '23

04 May '23

I think this commit is great as it will reduce the maintenance cost of the different `msxml*` dlls by unifying work. If a version of a different `msxml*` act differently than the other version we can always do something like in `.spec` files: ``` @ stdcall -private DllGetClassObject(ptr ptr ptr) winexml.MSXML*_DllGetClassObject ``` But by checking: https://gitlab.winehq.org/wine/wine/-/blob/master/dlls/msvcr120/Makefile.in Moving all code to `msxml` and using `PARENTSRC` would seems to be more in line with what wine is already doing. Either way is fine, the only thing that is sure is that splitting xml source work for each dll is not healthy, and code need to be cross merged in some way. Using a `winexml` is more memory efficient, but using `msxml` + `PARENTSRC` seems more application compatible, either way is fine for me. Also making `wine*` modules seems to become a recent common trend, see: https://gitlab.winehq.org/wine/wine/-/merge_requests/2298 @julliard I think you should make clearer guidelines about making `wine*.dll` modules, and proposing alternative to these modules in the guidelines. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2700#note_31956

1 0

[PATCH 0/1] MR2740: winemenubuilder: Create .desktop files for programs that open URIs
by Alex Henrie (＠alexhenrie) 04 May '23

04 May '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=22904 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2740

4 4

[PATCH v3 0/2] MR2732: winecoreaudio: Implement per-channel volume control.
by Davide Beatrici (＠davidebeatrici) 04 May '23

04 May '23

Requires testing, as I only have access to a remote macOS machine. -- v3: mmdevapi: Remove unused "channel" member in set_volumes_params. winecoreaudio: Implement per-channel volume control. https://gitlab.winehq.org/wine/wine/-/merge_requests/2732

3 6

[PATCH v3 0/5] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v3: vkd3d-shader/tpf: Validate index range declarations. vkd3d-shader/tpf: Validate input/output registers. vkd3d-shader/tpf: Validate signature element masks. vkd3d-shader/tpf: Validate signature element register indices. vkd3d-shader/tpf: Validate input/output register index counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

2 5

[PATCH v5 0/2] MR2690: mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.
by Ziqing Hui (＠zhui) 04 May '23

04 May '23

The tests shows that, for sink writer created by MFCreateSinkWriterFromURL, we are not able to grab the media sink object immediately after the creation, unless the media sink object can be created without setting media type(MP3, ASF). -- v5: mfreadwrite/tests: Test GetService for MP4 sink writer. mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2690

3 4

[PATCH v2 0/4] MR198: vkd3d-shader: Add more TPF validations.
by Conor McCarthy (＠cmccarthy) 04 May '23

04 May '23

Introduces an `idx_count` field to `struct vkd3d_shader_register`. Another patch set is needed for further validations and to use this field where applicable. -- v2: vkd3d-shader/tpf: Validate input/output registers. vkd3d-shader/tpf: Validate signature element masks. vkd3d-shader/tpf: Validate signature element register indices. vkd3d-shader/tpf: Validate input/output register index counts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/198

2 4

Re: [PATCH v6 0/2] MR2546: winegstreamer: Create extra decodebin to decode compressed stream.
by Ziqing Hui (＠zhui) 04 May '23

04 May '23

I do agree that it would be better to make the annoying GStreamer-Video-CRITICAL messages disappear. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2546#note_31943

1 0

Re: [PATCH v5 0/1] MR2713: kernelbase: Add GetPackagesByPackageFamily stub. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2713

1 0

Re: [PATCH v2 0/1] MR2654: libs/vkd3d: Leave the command queue op mutex locked after a partial flush. - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2654

1 0

Re: [PATCH v2 0/1] MR2738: po: Update Dutch translation - approved
by Alexandre Julliard (＠julliard) 03 May '23

03 May '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2738

1 0