June 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/5] MR3119: uiautomationcore: Add support for raising serverside events.
by Connor McAdams (＠cmcadams) 21 Jun '23

21 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3119

3 10

[PATCH 0/1] MR3123: crypt32: Do not create persistent container in CRYPT_CreateKeyProv().
by Paul Gofman (＠gofman) 21 Jun '23

21 Jun '23

The way CryptAcquireContext is currently used for temporary internal context in CertCreateSelfSignCertificate(), there is always a unique container created and persisted in registry (thus resulting in ever growing registry while an app repeatedly creates ephemeral certs with CertCreateSelfSignCertificate). The unique container name doesn't go anywhere outside of CRYPT_CreateKeyProv, and the crypt context is only used internally in CertCreateSelfSignCertificate() to generate the key and extract the key data (and put that to certificate store), so using a non-persistent context should be better. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3123

3 2

[PATCH v8 0/8] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu 21 Jun '23

21 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v8: jscript: Get rid of the function instance in arguments obj. jscript: Start from the last argument when adding them to named locals. jscript: Store detached args into a scope's specialized buffer. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

2 9

[PATCH v5 0/6] MR2944: winewayland.drv: part 4: First window contents on screen
by Alexandros Frantzis (＠afrantzis) 21 Jun '23

21 Jun '23

The goal of this MR is to set up the minimum necessary infrastructure to display the contents of some simple, software rendered windows. This involves two major steps: 1. Associate a window with a Wayland surface and give it the `xdg_toplevel` role, so that the compositor can display it. We also have to implement the required initial `xdg_surface` configuration sequence to be able to safely (i.e., without the compositor disconnecting us with an error) attach buffers to the surface in step (2). 2. Implement the `window_surface` interface for the Wayland driver. For now we provide a simple (and suboptimal) `window_surface_flush` implementation: for each flush we create a new `wl_shm` buffer, copy the whole window contents (ignoring damaged bounds for now) into it and attach it to the target Wayland surface. In the next MR I will optimize this implementation in multiple ways: a. implement a buffer queue to avoid constantly allocating new buffers b. respect the damaged bounds of the `window_surface` to minimize copying of data from the `window_surface` to the SHM buffer (and also for correctness) c. communicate damaged surface regions to the compositor to (potentially) allow more efficient texture uploads. With this MR many (software-rendered) applications can now display dynamic content on screen. We can't interact with the apps yet, but we do get to enjoy `notepad` in all its blinking-cursor glory. Thanks! -- v5: winewayland.drv: Do not commit buffers to unconfigured surfaces. winewayland.drv: Implement a simple window_surface flush. https://gitlab.winehq.org/wine/wine/-/merge_requests/2944

3 11

[PATCH 0/1] MR2507: vbscript: Add additional types for stack_pop_bool.
by Jason Millard (＠jsm174) 21 Jun '23

21 Jun '23

I have found some scripts where comparisons that use floats and OLECOLOR directly fail. For example: ``` If Light005.State Then ' State is a float V_R4 End If If Light005.Colorfull Then ' Colorfull is an OLECOLOR VT_UI4 End If ``` This is because `stack_pop_bool` does not handle `VT_R4` and `VT_UI4` and returns `E_NOTIMPL`. This adds additional types to `stack_pop_bool` similar to `VARIANT_Coerce`. Fixes https://bugs.winehq.org/show_bug.cgi?id=54731 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2507

4 7

[PATCH 0/5] MR2982: dxgi: Refactor D3D12 swapchain (second part)
by Giovanni Mascellani (＠giomasce) 21 Jun '23

21 Jun '23

Second and last part of https://gitlab.winehq.org/wine/wine/-/merge_requests/2930. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2982

4 7

[PATCH v2 0/2] MR240: vkd3d-shader: Add constant folding for the 'dot' operation.
by Nikolay Sivov (＠nsivov) 21 Jun '23

21 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader: Add constant folding for 'dp2add' operation. vkd3d-shader: Add constant folding for the 'dot' operation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/240

4 5

[PATCH 0/1] MR3129: dbghelp/test: Add explicit tests about loading ELF modules.
by eric pouech (＠epo) 21 Jun '23

21 Jun '23

Perhaps next time ELF loader is modified, it'll be noticed if it breaks things. See: - https://bugs.winehq.org/show_bug.cgi?id=55058 - https://bugs.winehq.org/show_bug.cgi?id=55096 Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3129

2 2

Re: [PATCH v2 0/1] MR3104: win32u: Add DriverVersion string for GPUs to registry
by Michael Skorokhodov (＠Samsuper) 21 Jun '23

21 Jun '23

On Wed Jun 21 09:30:59 2023 +0000, Zhiyi Zhang wrote: > I think it will be better if you can report different driver versions > for different vendors. For example, NVIDIA, AMD, and Intel drivers > should have different versions. You can use gpu->vendor_id to > differentiate them. For other vendors, either report a 1.0.0 version or > simply don't add this property. It might be good, but that variable doesn't contain any ID, only zero. I tried running games and applications. Probably, it could work in ValveSoftware/Wine when they update their repository. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3104#note_36443

1 0

[PATCH 0/1] MR3130: win32u: Use SessionId for non-interactive check instead of WSF_VISIBLE.
by Tatsuyuki Ishi (＠ishitatsuyuki) 21 Jun '23

21 Jun '23

Both window station visibility and session id are related to services being spawned in a non-interactive session, however the process window station can be manually set by the application while the session id can not be. The enumerated display config should not change even in the case of a window station update, hence testing for SessionId == 0 is more reliable here. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55074 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3130

4 7