June 2023 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR239: vkd3d-shader/codegen: Skip register allocation for unused object variables.
by Nikolay Sivov (＠nsivov) 20 Jun '23

20 Jun '23

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v2: vkd3d-shader/codegen: Skip register allocation for unused object variables. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/239

3 3

[PATCH v7 0/9] MR2942: jscript: Misc fixes and improvements.
by Gabriel Ivăncescu 20 Jun '23

20 Jun '23

Some of these fixes are subtle (like the first patch) and very annoying to debug. Although the first patch looks like a hack, surprisingly, it's how the spec itself says it is! It's not even an IE quirk, but a special case in the spec. For example, the variable name (which holds the builtin eval func) **does** matter: if it's called something other than 'eval', it gets treated differently (as if indirect), and this is verified by the tests + the spec's wording (so Microsoft's implementation follows it). Most of the patches other than the first 2 are pretty small so they're in same MR. -- v7: jscript: Store ref to the function code instead of the function instance jscript: Start from the last argument when adding them to named locals. jscript: Store detached locals into a scope's specialized buffer. jscript: Detach the frame's scope before inserting eval() variables into it. jscript: Don't use iface_to_jsdisp where it's not necessary to grab it. jscript: Get rid of jsobj in scope_chain_t. jscript: Fix function leak in scope_init_locals. jscript: Fix addressing invalid memory if ref is an argument. jscript: Correctly implement context for indirect eval calls in ES5+ modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/2942

2 16

[PATCH v4 0/2] MR2875: shell32: add support for balloon icon copying
by Cherser-s (＠Cherser-s) 20 Jun '23

20 Jun '23

Currently shell32 only transfers the plain icon for `Shell_NotifyIcon` calls, ignoring balloon icons. This patch allows transferring both images to explorer.exe tray. -- v4: shell32: add support for balloon icon copying shell32: refactor notify_icon for multiple icons https://gitlab.winehq.org/wine/wine/-/merge_requests/2875

2 2

[PATCH 0/3] MR3116: oleaut32/recinfo: Use correct allocator for the record data.
by Nikolay Sivov (＠nsivov) 20 Jun '23

20 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3116

2 3

[PATCH 0/1] MR217: include: Use WIN32_LEAN_AND_MEAN to exlude non-required headers
by Alistair Leslie-Hughes (＠alesliehughes) 20 Jun '23

20 Jun '23

Reference https://bugs.winehq.org/show_bug.cgi?id=54985 >From the line we see the mingw version used causes an In file included from /usr/share/mingw-w64/include/unknwnbase.h:47, [ 935s] from /usr/share/mingw-w64/include/objidlbase.h:439, [ 935s] from include/combaseapi.h:29, [ 935s] from include/objbase.h:267, [ 935s] from include/ole2.h:25, [ 935s] from /usr/share/mingw-w64/include/wtypes.h:13, [ 935s] from include/winscard.h:22, [ 935s] from include/windows.h:68, [ 935s] from libs/vkd3d/include/private/vkd3d_common.h:23, [ 935s] from libs/vkd3d/libs/vkd3d-shader/vkd3d_shader_private.h:49, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.y:24, [ 935s] from libs/vkd3d/libs/vkd3d-shader/preproc.l:23: [ 935s] /usr/share/mingw-w64/include/wtypesbase.h:148:16: error: redefinition of 'struct _SECURITY_ATTRIBUTES' [ 935s] 148 | typedef struct _SECURITY_ATTRIBUTES { The included file winscard.h seemed a little odd. The vkd3d isn't going to use this. Adding the define WIN32_LEAN_AND_MEAN to the Makefile.in (in wine), produce the following warnings. /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:75:5: warning: implicit declaration of function ‘abort’ [-Wimplicit-function-declaration] 75 | abort(); | ^~~~~ /home/alesliehughes/wine/libs/vkd3d/include/private/vkd3d_common.h:258:14: warning: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration] 258 | *major = atoi(version); Adding header <stdlib.h> removed all the warnings. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/217

5 7

[PATCH v4 0/4] MR3073: Implement FileDispositionInformationEx and FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE
by Joel Holdsworth (＠jhol) 20 Jun '23

20 Jun '23

This MR supercedes !1895 as a solution to bug [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771). Rather than fixing the problem of Wine's inability to modify the attributes of read-only files, this patch set instead implements `FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE` which the Msys2 and Cygwin runtime libriries can use to avoid needing to modify attributes. -- v4: ntdll: Implemented FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll/tests: Added tests for FILE_DISPOSITION_IGNORE_READONLY_ATTRIBUTE ntdll: Initial implementation of FileDispositionInformationEx include: Defined FILE_DISPOSITION_INFORMATION_EX and friends https://gitlab.winehq.org/wine/wine/-/merge_requests/3073

3 8

[PATCH v23 0/6] MR2808: SNI tray implementation
by Cherser-s (＠Cherser-s) 20 Jun '23

20 Jun '23

Adds the tray icons implementation based on org.kde.StatusNotifierItem interface usage. Does allow restarting StatusNotifierWatcher object, but will fallback to XEMBED or internal tray, if wine gets initialized when there is no StatusNotifierWatcher object registered. -- v23: winesni.drv: add dbus watch instead of using plain unix fds and flush winesni.drv: replaced the dbus connection logic with a single connection per each SNI object winesni.drv: wrap functions with pthread mutex locking winesni.drv: implement basic balloon notification support explorer: add winesni.drv tray implementation support winesni.drv: add KDE StatusNotifierItem implementation for tray https://gitlab.winehq.org/wine/wine/-/merge_requests/2808

3 7

[PATCH 0/2] MR3105: Add a few additional nullchecks (Coverity)
by Fabian Maurer (＠DarkShadow44) 20 Jun '23

20 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3105

3 3

[PATCH 0/1] MR3099: wbemprox: Fix memory leak on error path in enum_key (scan-build).
by Alex Henrie (＠alexhenrie) 20 Jun '23

20 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3099

4 3

[PATCH v8 0/2] MR2068: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 20 Jun '23

20 Jun '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)) Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v8: comdlg32: Enable visual styles when showing IFileDialog. comdlg32: Return E_UNEXPECTED if IFileDialog is already shown https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

2 3