June 2023 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR2978: jscript: Remove unnecessary call to malloc in strbuf_ensure_size.
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2978

3 2

[PATCH 0/1] MR2979: jscript: Fix memory leak on error path in String_replace (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2979

3 2

[PATCH v2 0/2] MR2963: mf/tests: Test input and ouput type for WMA decoder DMO.
by Ziqing Hui (＠zhui) 05 Jun '23

05 Jun '23

-- v2: mf/tests: Test output type for WMA decoder DMO. mf/tests: Test input type for WMA decoder DMO. https://gitlab.winehq.org/wine/wine/-/merge_requests/2963

3 3

[PATCH 0/1] MR2977: wbemprox: Fix memory leak on error path in create_view (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2977

3 2

[PATCH 0/1] MR2975: msi: Fix memory leak in ready_media (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

base_url was never freed, and can simply be enlarged instead of copying it to a new buffer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2975

3 2

[PATCH 0/1] MR2973: msi: Make TransformView_Create static.
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2973

3 2

[PATCH 0/1] MR2972: msi: Return ERROR_OUTOFMEMORY if calloc fails in TransformView_Create (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

Instead of ERROR_SUCCESS. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2972

3 2

[PATCH 0/1] MR2971: mscms: Fix double free on error path in EnumColorProfilesA (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

If fileW is not null, it is freed at the end of the function. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2971

3 2

[PATCH 0/1] MR2970: wusa: Fix double free on error path in read_update_package (scan-build).
by Alex Henrie (＠alexhenrie) 05 Jun '23

05 Jun '23

If read_identity returns FALSE, it has already called clear_identity. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2970

3 2

Re: [PATCH v2 0/5] MR2901: winegstreamer: Test and fix H264 timestamps and concatenated streams.
by Zebediah Figura (＠zfigura) 05 Jun '23

05 Jun '23

> It is not a matter of no-confidence, although I could argue that being told that my statements are non-sensical in several occasions isn't a great way to build confidence. I suspect I know at least one of the occasions you're referring to, and I'd like to apologize for that. It's never been my intent to demean or insult, and I'm sorry for having done so anyway. I will try to be more mindful of my language in the future. > I took maintainership of the wg_transform code, not just because I wrote most of it, but also in order to help with the bandwidth, and avoid bothering two persons on every single change. I believe I have taken every comment into account very carefully, and haven't bypassed your review or Nikolay's for MF related things, on any meaningful change. I appreciate the wish to reduce my workload, and I will gladly agree that my reviews have been acknowledged. As I've stated, though, I would still like the opportunity to perform those reviews on any winegstreamer changes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2901#note_34600

1 0