July 2023 - Wine-gitlab - list.winehq.org

[PATCH v3 0/10] MR3418: Draft: Add tryok() for tests that may need multiple attempts to succeed
by Francois Gouget (＠fgouget) 31 Jul '23

31 Jul '23

This is meant to simplify testing conditions that generally hold true but may occasionally fail due to interference from external factors (such as processes that start / stop, network connections being opened / closed, etc). The trick is to loop a few times on the set of flaky conditions until they succeed. During the last attempt all failures are recorded as usual, while in the previous runs, the tryok() failures area ignored but cause one more attempt to be made. The simplest case looks like this: LOOP_ON_FLAKY_TESTS(3) { // ok() failures are never ignored and not retried ok(..., "check 1", ...); // tryok() failures are ignored except on the last attempt tryok(..., "check 2", ...); } There is also: * attempt_retry() which marks the current attempt as failed as if calling tryok(0), and returns true if another attempt can be made. * attempt_failed() which returns true if an ok() call failed. --- This is independent from the 'flaky' mechanism which adds some naming constraints. The loop macro is still called LOOP_ON_FLAKY_TESTS() despite being unrelated to the flaky mechanism. The attempt_retry() and attempt_failed() macro names also don't make it obvious that they are related to tryok(). I think this mechanism is better than the flaky one because a flaky test can go bad without anyone noticing, whereas if a tryok() starts failing systematically it will cause a real failure. The other side of that coin is that, unlike flaky, the tryok() mechanism does not entirely eliminate the possibility of getting a failure, it just reduces it; though by adjusting the maximum number of attempts one can achieve an arbitrarily low failure rate. For instance if an ok() call fails 10% of the time and one wants a maximum of 1 in a million failure rate, use LOOP_ON_FLAKY_TESTS(6). The cost is an increased run time in the worst case. This also limits the use of this mechanism to tests that have a reasonably low failure rate to start with (otherwise one has to loop too many times). Also note that there are cases where looping essentially reduce the failure rate to zero. For instance ieframe:webbrowser fails if IE creates a net session while the test is counting them. But IE only creates the one net session on start up so trying even one more time should guarantee that the test will succeed. Other cases like scheduling delays and the creation of network connections are more probabilistic in nature. Maybe a comment in test.h should offer some guideline as to the target failure rate. Eventually this may replace the flaky mechanism but that depends on how well it works in practice and how practical it is to loop on flaky tests. It seems to be going well in the few cases I looked at. But I think this mechanism has value even if the two end up coexisting indefinitely. This MR uses the tryok() in some actual tests for illustration and testing purposes. The final MR will probably split most of those off to separate MRs. -- v3: mmdevapi/tests: Replace flaky with tryok() in the capture tests. mmdevapi/tests: Replace flaky with tryok() in the render tests. quartz/tests: Replace flaky() with tryok() to work around scheduling delays. DEBUG ieframe/tests: tryok() framework testing ground. ieframe/tests: Work around a network session race condition. advapi32/tests: Replace the custom loop with tryok() mechanism. ntdll/tests: Use tryok() to fix a free disk space race with other processes. kernel32/tests: Use tryok() to fix a heap race with other processes. FIXME(traces) tests: Add tryok() for tests that may need multiple tries to succeed. tests: Update the documentation. https://gitlab.winehq.org/wine/wine/-/merge_requests/3418

3 11

[PATCH 0/1] MR3450: msxml3: Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 30 Jul '23

30 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3450

3 2

[PATCH 0/1] MR3455: winedump: Add initial support for dumping Windows NT Registry Files (REGF).
by Piotr Caban (＠piotr) 29 Jul '23

29 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3455

2 1

[PATCH v3 0/6] MR3454: user32: Implement UOI_TIMERPROC_EXCEPTION_SUPPRESSION.
by Jinoh Kang (＠iamahuman) 29 Jul '23

29 Jul '23

This is required to avoid silencing (potentially fatal) exceptions from timer procedures. -- v3: win32u: Ignore unhandled info index in NtUserSetObjectInformation. win32u/tests: Add tests for NtUserSetObjectInformation. user32: Implement UOI_TIMERPROC_EXCEPTION_SUPPRESSION. user32/tests: Add tests for UOI_TIMERPROC_EXCEPTION_SUPPRESSION. https://gitlab.winehq.org/wine/wine/-/merge_requests/3454

3 7

Re: [PATCH v2 0/1] MR3360: shell32: Improve shell copy and delete items functions, notifications.
by Huw Campbell (＠HuwCampbell) 29 Jul '23

29 Jul '23

I had a review from the ReactOS guys with some suggestions, but before I make them is there any interest in taking up maintenance changes like the for the shell? Who should I ping for a review? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3360#note_40686

1 0

[PATCH 0/8] MR3449: Misc Remove DECLSPEC_HIDDEN usage.
by Alistair Leslie-Hughes (＠alesliehughes) 29 Jul '23

29 Jul '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3449

2 8

[PATCH 0/1] MR3445: server: Open files in blocking mode in create_file
by Aidan Hobson Sayers (＠aidanhs) 29 Jul '23

29 Jul '23

This fixes a bug in wine when running on 9pfs where short reads would occur, causing binaries to be loaded incorrectly. All other filesystems on Linux ignore O_NONBLOCK for regular files, so this should not affect them. Thanks to Paul Gofman for the advice on this fix. --- Ref https://gitlab.winehq.org/wine/wine/-/merge_requests/3390 for my original attempt at fixing this, particularly https://gitlab.winehq.org/wine/wine/-/merge_requests/3390#note_40093 which describes the strange situation `O_NONBLOCK` finds itself in on filesystems. The risk with this MR is that fifo, unix sockets or other special files opened via `open_unix_file` in ntdll will now have changed behaviour - but my quick look suggests that this is unlikely, as `open_unix_file` is only used for: - `dlls/ntdll/unix/file.c`: `NtCreateFile` and `NtDeleteFile` - `dlls/ntdll/unix/process.c`: loading PE information and getting a dirfd for the current directory - `dlls/ntdll/unix/env.c`: `open_nls_data_file` - `dlls/ntdll/unix/loader.c`: dll load functions - `dlls/ntdll/unix/registry.c`: `NtLoadKeyEx` cc @gofman -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3445

4 5

[PATCH 0/1] MR3447: ntdll/unix: NtTerminateThread should accept NULL handle
by Ake Rehnman (＠ake.rehnman) 29 Jul '23

29 Jul '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=55352 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3447

2 1

[PATCH v3 0/1] MR3425: msvcp140_codecvt_ids: Add DLL.
by Mohamad Al-Jaf (＠maljaf) 28 Jul '23

28 Jul '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55344 It looks like the exports are just variables. -- v3: msvcp140_codecvt_ids: Add DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/3425

3 3

[PATCH v3 0/1] MR3390: ntdll: Correctly handle pread short reads
by Aidan Hobson Sayers (＠aidanhs) 28 Jul '23

28 Jul '23

The read and pread syscalls are permitted to return fewer bytes than requested (unlike the fread libc call which will only perform a short read on error or EOF). This is most likely to occur when binaries are located on slower filesystems (e.g. NFS or 9pfs) ffab9d9 is a relatively recent regression here, but a lot of the code appears to be much older (e.g. the read call in 341b7dc) In this MR I've focused on ntdll, but I see a lot of similar mishandling of the pread return value in `server/`. I will raise a bug as I don't intend to create a follow up MR at this time. -- v3: ntdll: Correctly handle pread short reads https://gitlab.winehq.org/wine/wine/-/merge_requests/3390

4 13