July 2023 - Wine-gitlab - list.winehq.org

[PATCH v3 0/75] MR3168: Draft: Release 8.0.2.
by Michael Stefaniuc (＠mstefani) 17 Jul '23

17 Jul '23

-- v3: Release 8.0.2. localspl: Don't pass original document name to cupsStartDocument. wininet/tests: Update expected WineHQ certificate. winhttp/tests: Fix a test failure. This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/3168

5 13

[PATCH v4 0/5] MR273: vkd3d-shader: sm1 constants.
by Zebediah Figura (＠zfigura) 17 Jul '23

17 Jul '23

Most of the interesting part is the API (first patch); the rest is implementation. The basic idea is that we have predefined fixed numbers for the float, integer, and boolean constant arrays, and treat each of the three like a constant buffer. Implementation-wise, we lower sm1-style constant registers to sm4-style constant buffers and immediate constants, which are capable of expressing a strict superset of the same functionality. Note that use of immediate constants is *not* the way that wined3d currently handles DEF instructions, but rather those are uploaded via uniforms. Is there a reason for this? Relative addressing is not yet implemented. In theory it should be simple enough to either translate it directly, for external constants, or use sm4-style immediate constant buffers, for internal constants. There may be a snag if an application depends on relative addressing to cover a range of both internal and external constants; this surely would require manual assembly or an application bug, but we could implement it by copying to a temporary array using a private TEMP-like register type. -- Because API is easiest to review when there's a concrete user, I have functional patches hooking this up to wined3d, in the following branches: https://gitlab.winehq.org/zfigura/vkd3d/-/commits/himavant5 https://gitlab.winehq.org/zfigura/wine/-/commits/himavant_cb The vkd3d branch contains some extra commits necessary to compile basic shaders; I intend to submit these as soon as possible after the important API parts have been reviewed. I tested this patch series by building a mingw vkd3d tree with that branch, and running the shader runner through Wine, with a test that uses both internal and external constants: make tests/shader_runner.exe && WINE_D3D_CONFIG=renderer=vulkan wine tests/shader_runner.exe ../vkd3d/tests/hlsl/writemask-assignop-0.shader_test I actually originally wrote the API without a user in mind, and later hooked up the implementation in Wine, and was surprised to find how straightforward it ended up being, so I think that speaks quite strongly in favour of this API. Granted, I had already written "wined3d: Store push constants in wined3d_buffers in struct wined3d_state." by that point, but that was something I anticipated needing for Wine anyway, without thinking of vkd3d. -- I actually originally did the implementation all in spirv.c, mostly because this was before we had infrastructure in place to do passes on the middle IR. I much prefer this version, it's quite centralized in one place and I think ends up being simpler than the spirv.c version anyway, but I can retrieve the spirv.c version if anyone wants to see it. That said, we may not want to lower to VKD3DSPR_CONSTBUFFER for GLSL without UBOs (but then again, we could also just emit VKD3DSPR_CONSTBUFFER registers as plain GLSL arrays). The actual declaration of flat constants is kept in spirv. I suppose the alternative here is to instead declare buffers from the reflection information and simply ignore dcl_constantbuffer. I submitted the patch as-is since it seemed simple enough and I didn't want to block this work further on rewriting that part, but we may want to rewrite it in the future regardless. ``` After the torchlight red on sweaty faces After the frosty silence in the gardens After the agony in stony places The shouting and the crying Prison and palace and reverberation Of thunder of spring over distant mountains ``` -- v4: vkd3d-shader/spirv: Emit variables for flat constant buffers. vkd3d-shader/ir: Normalise sm1-style constants. vkd3d-shader/ir: Move normalization code from spirv.c to ir.c. vkd3d-shader/d3dbc: Scan descriptors for constant register sets. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/273

3 6

[PATCH v2 0/1] MR2969: include: Annotate IoAllocate functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC).
by Alex Henrie (＠alexhenrie) 17 Jul '23

17 Jul '23

-- v2: include: Annotate IoAllocate functions with __WINE_(ALLOC_SIZE|DEALLOC|MALLOC). https://gitlab.winehq.org/wine/wine/-/merge_requests/2969

2 1

Re: [PATCH v2 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests.
by Alex Henrie (＠alexhenrie) 17 Jul '23

17 Jul '23

On Mon Jul 17 16:08:54 2023 +0000, Erich Hoover wrote: > What I have in staging has a lot more tests than this, were you only > interested in these ones for some reason or are you just sending in the > first bit so that rebasing is easier? In this commit, I only took the tests from [the first patch](https://gitlab.winehq.org/wine/wine-staging/-/blob/4482bd34937ec6ab0…. Essentially, I'm trying to make it easier to upstream the junction point patches by splitting off small pieces of them, cleaning them up, and upstreaming them one at a time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3331#note_39170

1 0

Re: [PATCH v2 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests.
by Erich Hoover (＠ehoover) 17 Jul '23

17 Jul '23

What I have in staging has a lot more tests than this, were you only interested in these ones for some reason or are you just sending in the first bit so that rebasing is easier? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3331#note_39168

1 0

Re: [PATCH v2 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests.
by Alex Henrie (＠alexhenrie) 17 Jul '23

17 Jul '23

On Fri Jul 14 06:21:02 2023 +0000, **** wrote: > Marvin replied on the mailing list: > ``` > Hi, > It looks like your patch introduced the new failures shown below. > Please investigate and fix them before resubmitting your patch. > If they are not new, fixing them anyway would help a lot. Otherwise > please ask for the known failures list to be updated. > The tests also ran into some preexisting test failures. If you know how > to fix them that would be helpful. See the TestBot job for the details: > The full results can be found at: > https://testbot.winehq.org/JobDetails.pl?Key=134856 > Your paranoid android. > === w7pro64 (64 bit report) === > ntdll: > file.c:5702: Test failed: Unexpected error (0x0) > ``` I honestly don't know why this test failed. I have not been able to reproduce the failure a second time. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3331#note_39167

1 0

Re: [PATCH v2 0/1] MR3331: ntdll/tests: Add more reparse/junction point tests. - approved
by Erich Hoover (＠ehoover) 17 Jul '23

17 Jul '23

This merge request was approved by Erich Hoover. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3331

1 0

[PATCH v5 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 17 Jul '23

17 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v5: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

2 1

Re: [PATCH v3 0/6] MR3346: win32u/wow64win: Client callback interface improvements. - approved
by Huw Davies (＠huw) 17 Jul '23

17 Jul '23

This merge request was approved by Huw Davies. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3346

1 0

[PATCH v4 0/1] MR3347: klist: Add a program that lists Kerberos tickets.
by Maxim Karasev (＠mxkrsv) 17 Jul '23

17 Jul '23

It's a clean-room reimplementation that mimics Windows 10 program's output format. It prints all the information that is available via KerbQueryTicketCacheMessage. Also tested to work on Windows if dynamically linked + built with winegcc. For further extension of the functonality, implementing KerbQueryTicketCacheEx{,2,3}Message is required. -- v4: klist: Add a program that lists Kerberos tickets. https://gitlab.winehq.org/wine/wine/-/merge_requests/3347

2 1