August 2023 - Wine-gitlab - list.winehq.org

[PATCH v6 0/3] MR2168: win32u: Match second name when enum fonts.
by Keming Liang (＠Keming) 17 Aug '23

17 Aug '23

the patch can resolve the issue: https://bugs.winehq.org/show_bug.cgi?id=54483 and can also solve many crashed issue related to font(MS Shell Dlg etc.) -- v6: add a skip log when there is no simsun font in test env. https://gitlab.winehq.org/wine/wine/-/merge_requests/2168

3 5

[PATCH v2 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55450 -- v2: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

2 2

[PATCH v4 0/3] MR268: vkd3d-shader/hlsl: Handle vector arguments in fmod().
by Nikolay Sivov (＠nsivov) 17 Aug '23

17 Aug '23

-- v4: tests: Add a test for fmod() with vector arguments. vkd3d-shader: Use ternary operator in fmod() implementation. vkd3d-shader/tpf: Use 'movc' to implement ternary operator. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/268

3 9

[PATCH 0/5] MR3596: Win10 evolution for OutputDebugStringW.
by eric pouech (＠epo) 17 Aug '23

17 Aug '23

Win10 introduced the ability for OutputDebugStringW to send Unicode strings (instead of translating the Unicode string to ANSI and call OutputDebugStringA). This series: - add a couple of tests for covering various aspects + how exception with unicode string is constructed, + interaction with WaitForDebugEvent and WaitForDebugEventEx - implements WaitForDebugEventEx() - emit unicode string from OutputDebugStringW - introduce manifest constants to describe stages in exception testing (this let adding new stages way easier). Note this has not been tested on ARM. The tests results are not fully green because of existing issues in ntdll:exception (see https://bugs.winehq.org/show_bug.cgi?id=55111 for win8 and early win10, and all the failing ones in Win11...). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3596

3 7

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

Jeffrey Smith (@whydoubt) commented about dlls/gdiplus/tests/pathiterator.c: > GpPath *path; > GpPathIterator *iter; > GpStatus stat; > - INT start, end, result; > + INT count, start, end, result, closed; Again, `BOOL closed;` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42604

1 0

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

On Wed Aug 16 21:48:02 2023 +0000, Bartosz Kosiorek wrote: > How it could be done (set \*result when you return)? I just mean set *result before you return, just like you do about 5 lines before. It appears 0 would the appropriate value, in which case you could combine the if blocks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42603

1 0

[PATCH v5 0/2] MR3431: wined3d: Fix clears of the current render target in Vulkan
by Evan Tang (＠etang-cw) 17 Aug '23

17 Aug '23

Previously, clearing the current render target would delay the clear until the render pass was ended by something else Fixes missing UI in [Moving Out](https://store.steampowered.com/app/996770/Moving_Out/) -- v5: wined3d: Restart vk render pass on RT clear. d3d11: Add tests for clearing RTs in the middle of a render. https://gitlab.winehq.org/wine/wine/-/merge_requests/3431

4 5

Re: [PATCH v5 0/1] MR3581: gdiplus: add support for GdipPathIterNextPathType
by Jeffrey Smith (＠whydoubt) 17 Aug '23

17 Aug '23

Jeffrey Smith (@whydoubt) commented about dlls/gdiplus/tests/pathiterator.c: > GpPath *path; > GpPathIterator *iter; > GpStatus stat; > - INT start, end, result; > - BOOL closed; > + INT start, end, result, closed; I would leave the type as BOOL, to make it match the 4th parameter of GdipPathIterNextSubpath. But since it is implemented as an integer (as opposed to an actual boolean that only accepts true/false), it can contain any value that an INT can, so the tests should still be fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3581#note_42601

1 0

[PATCH 0/1] MR3583: wldap32: Map LDAP_OPT_AUTO_RECONNECT to LDAP_OPT_RESTART and add tests.
by Alex Henrie (＠alexhenrie) 17 Aug '23

17 Aug '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55450 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3583

3 2

[PATCH v3 0/2] MR3578: freopen() fix.
by eric pouech (＠epo) 17 Aug '23

17 Aug '23

I stumbled onto this while using freopen() for debugging purposes. Basically, freopen() fails if the FILE has been created with an invalid handle. So, this MR contains: - basic tests for freopen (no issue there, just for coverage purposes) - tests for freopen on FILE with invalid handle - fix for freopen -- v3: msvcrt: Fix freopen() on FILE with invalid underlying fd. msvcrt/tests: Add tests for freopen(). https://gitlab.winehq.org/wine/wine/-/merge_requests/3578

3 4