September 2023 - Wine-gitlab

[PATCH v6 0/2] MR2545: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID
by Yeshun Ye (＠yeyeshun) 30 Nov '25

30 Nov '25

winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID winmm/tests: Add flags tests for mixerGetLineControlsA/W support MIXER_GETLINECONTROLSF_ONEBYID and MIXER_GETLINECONTROLSF_ONEBYTYPE Signed-off-by: YeshunYe <yeyeshun(a)uniontech.com> -- v6: winmm: Remove 'dwLineID' check when MIXER_GETLINECONTROLSF_ONEBYID winmm/tests: Add flags tests for mixerGetLineControlsA/W https://gitlab.winehq.org/wine/wine/-/merge_requests/2545

2 4

[PATCH v6 0/4] MR1825: kernelbase/path.c: UrlFixupW()
by Thomas Csovcsity (＠thc13) 14 Nov '25

14 Nov '25

## Summary Tests for UrlFixupW and semi stub function implementaion. ## Test results - Tests are 100% ok on my local WIN 10 pc. Wine test bot seems to be okay too. - Wine tests on debian machine | function type | result | | ------ | ------ | | stub | 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **200** failures), 0 skipped. | | semi stub| 0020:url: 69802 tests executed (0 marked as todo, 0 as flaky, **100** failures), 0 skipped. | ## Todos For follow up merge request(s). - [ ] Add more tests for priority investigation, who url scheme fix up is working on windows. - [ ] Implement missing parts of fix up. ## Conclusion Semi stub implementation is an improvement to the existing solution. A grep showed that wine internals do not call this function, therefore it should not introduce any new bugs. Windows applications using/relying on the function should now work better, if not they may reveal already existing bugs. -- v6: shlwapi: fixup leading and trailing typos in UrlFixupW shlwapi: check for colon in UrlFixupW kernelbase: Restructure UrlFixupW() shlwapi/tests: Add tests for UrlFixupW. https://gitlab.winehq.org/wine/wine/-/merge_requests/1825

3 11

[PATCH 0/1] MR3228: Update heap.c removed return NULL at line 985. Prevents Wing Commander...
by James Carthew (＠dmjc) 28 Oct '25

28 Oct '25

Update heap.c removed return NULL at line 985. Prevents Wing Commander Prophecy and Secret Ops for loading/playing. Fixes WINE bug 55176. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3228

5 4

[PATCH v3 0/2] MR1321: Reject wic invalid formats
by Zhiyi Zhang (＠zhiyi) 21 Oct '25

21 Oct '25

These invalid formats are rejected when creating WIC render targets. Otherwise, Wine may create a WIC render target with an unsupported format and in turn, will make testing IsSupported() method difficult. -- v3: d2d1: Test creating WIC bitmap render targets. d2d1: Reject unsupported formats when creating WIC bitmap render targets. https://gitlab.winehq.org/wine/wine/-/merge_requests/1321

3 6

[PATCH 0/1] MR3880: ntdll: Only declare/set wow_teb on platforms using it
by Gerald Pfeifer (＠gerald) 17 Oct '25

17 Oct '25

Otherwise we see dlls/ntdll/unix/signal_x86_64.c:2351:14: warning: unused variable 'wow_teb' on FreeBSD. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3880

4 4

[PATCH v2 0/4] MR2928: xmllite/writer: Implement more APIs
by David Kahurani (＠kahurani) 30 Sep '25

30 Sep '25

Implements or at least tries to implement: WriteName WriteQualifiedName WriteNmToken WriteEntityRef Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- v2: xmllite/writer: Implement WriteQualifiedName. xmllite/writer: Implement WriteNmToken. xmllite/writer: Implement WriteEntityRef. xmllite/writer: Implement WriteName. https://gitlab.winehq.org/wine/wine/-/merge_requests/2928

4 8

[PATCH 0/1] MR3928: msxml3: Add GB2312 support for builtin character converter.
by Jactry Zeng (＠jactry) 09 Sep '25

09 Sep '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3928

6 7

[PATCH 0/5] MR1035: oleaut32/tests: Use IMallocSpy to test VariantClear(VT_RECORD).
by Kevin Puetz (＠puetzk) 09 Sep '25

09 Sep '25

Salvage tests and fix a leak found in another review: see https://gitlab.winehq.org/wine/wine/-/merge_requests/897#note_9175 points 1 and 2. 3. is why !897 was reverted. This does not contain the (incorrect) changes to VariantCopyInd, but instead fixes the leak identified in VariantClear (VT_RECORD needs to free pvRecord), and the wrong allocator being used in VariantCopy (it should have been IMalloc, rather than `HeapAlloc`, as shown by the fact IMallocSpy observes these allocations). This also cleans up some dubious behavior by the test IRecordInfoImpl, which was modifying a VARIANT that it did not own or receive as an argument in the middle of VariantClear. This was likely undefined behavior, and in any case concealed the heap leak. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1035

4 12

[PATCH v2 0/1] MR3529: rpcrt4: Forward NdrStubCall3 to NdrStubCall2.
by Alex Henrie (＠alexhenrie) 08 Sep '25

08 Sep '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54606 -- v2: rpcrt4: Forward NdrStubCall3 to NdrStubCall2. https://gitlab.winehq.org/wine/wine/-/merge_requests/3529

5 9

[PATCH 0/1] MR1968: Fix a problem caused by the recent official commit "rsaenh: Factor out...
by Jackie Jiang (＠sonyps5201314) 20 Aug '25

20 Aug '25

Fix a problem caused by the recent official commit "rsaenh: Factor out block_encrypt() function." that would cause DES encryption errors -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1968

3 3