October 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/2] MR6685: win32u: Fixes for arc drawing. - approved
by Alexandre Julliard (＠julliard) 18 Oct '24

18 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6685

1 0

Re: [PATCH v3 0/4] MR6695: ntdll/tests: Add reserve object tests. - approved
by Alexandre Julliard (＠julliard) 18 Oct '24

18 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6695

1 0

Re: [PATCH v2 0/6] MR6694: user32: Move DND code from winex11 XDND. - approved
by Alexandre Julliard (＠julliard) 18 Oct '24

18 Oct '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6694

1 0

[PATCH v3 0/6] MR6688: d3dx9: Move targa decoding into d3dx9, part 2.
by Connor McAdams (＠cmcadams) 18 Oct '24

18 Oct '24

These patches finish moving targa file handling into d3dx9. -- v3: d3dx9: Add support for decoding targa files with a color map in d3dx9. d3dx9: Add support for decoding targa files with run length encoding in d3dx9. d3dx9: Add support for decoding targa files with different pixel orders in d3dx9. d3dx9: Add support for loading basic targa images without WIC. d3dx9/tests: Add more tests for loading targa files. https://gitlab.winehq.org/wine/wine/-/merge_requests/6688

3 12

[PATCH v2 0/3] MR6680: msvcp140: Use current locale to convert path in _Fiopen.
by Daniel Lehman (＠dlehman25) 18 Oct '24

18 Oct '24

-- v2: msvcp140: Use current locale to convert path in _Fiopen. msvcp120/tests: Add tests for _Fiopen. msvcp140/tests: Add tests for _Fiopen. https://gitlab.winehq.org/wine/wine/-/merge_requests/6680

4 8

[PATCH 0/1] MR6699: user32/tests: Flush events after test_SetForegroundWindow.
by Rémi Bernon 18 Oct '24

18 Oct '24

Making sure there's no pending X11 event to be processed that would cause spurious failures with later tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6699

1 1

Re: [PATCH v12 0/3] MR5060: win32u, explorer, winex11.drv: Restore display settings on process exit.
by Anton Baskanov (＠baskanov) 18 Oct '24

18 Oct '24

On Fri Oct 18 14:05:23 2024 +0000, Rémi Bernon wrote: > I see, I think this should not be necessary anymore since !6573, the new > display mode will be written to the registry and other processes/threads > should get their cache invalidate immediately. > Later on, when the XRandR events are processed the cache might get > invalidated again but should end up with the same display settings. The issue was specifically with seeing mode changes from other processes. The test calls `EnumDisplaySettings()` in a loop waiting for the expected mode change. If we don't process `RRNotify` events in `xrandr14_get_id()` we won't see the new mode until some thread processes the messages. Since there are no such threads in the test process, the test will fail. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5060#note_85467

1 0

[PATCH v8 0/8] MR6649: winex11: Replace foreign windows with a driver-only host window tracking.
by Rémi Bernon 18 Oct '24

18 Oct '24

Making all the windows handled by the driver to be either GL/VK client surfaces, or top-level windows. This avoids leaking host windows into the Win32 space, and makes it possible to get rid of some remaining NtUserMapWindowPoints in `map_event_coords` for mouse input. -- v8: winex11: Get rid of the now unnecessary foreign windows. winex11: Generate relative ConfigureNotify on parent ConfigureNotify events. winex11: Use the new host windows to register foreign window events. winex11: Keep track of the host windows children window rects. winex11: Keep track of the host windows relative rects. winex11: Keep track of the host window children of interest. winex11: Create host windows recursively up to root_window. winex11: Introduce a new struct host_window for host-only windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

2 12

[PATCH v3 0/4] MR6602: explorer, services: Use admin tokens when appropriate.
by Tim Clem (＠tclem) 18 Oct '24

18 Oct '24

Let me know if you'd like me to split this up. As per feedback, I'm now doing the admin token-setting via an extension to NtSetInformationProcess. Testing on Windows shows that the owner of GetDesktopWindow() always has a default admin token with `TokenElevationTypeDefault`, no matter the token of the process/thread that is responsible for creating it. We've had issues in this area in the past - 99e2fad1 was a case where it was important that explorer not inherit the token of the *process* spawning it, but instead the token of the *thread*. This patch keeps that app working, since now explorer will set a default token regardless. In addition to the privilege issues from 99e2fad1, it is a relatively common pattern to duplicate the token of the owner of GetDesktopWindow to acquire a default token. Services are also currently launched with limited tokens, so this series also has services.exe elevate itself. -- v3: services: Apply a default admin token to the process. ntdll: Count default-elevation admin tokens as elevated from NtQueryInformationToken(TokenElevation). https://gitlab.winehq.org/wine/wine/-/merge_requests/6602

4 6

Re: [PATCH v12 0/3] MR5060: win32u, explorer, winex11.drv: Restore display settings on process exit.
by Rémi Bernon 18 Oct '24

18 Oct '24

On Fri Oct 18 13:56:14 2024 +0000, Zhiyi Zhang wrote: > If I remember correctly, it's for other threads other than the > explorer's main thread to see the new display mode immediately. Without > it, a rather large delay is causing tests to fail. I see, I think this should not be necessary anymore since !6573, the new display mode will be written to the registry and other processes/threads should get their cache invalidate immediately. Later on, when the XRandR events are processed the cache might get invalidated again but should end up with the same display settings. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5060#note_85457

1 0