October 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR6650: comdlg32: Allocate extbuf on heap rather than stack.
by Charlotte Pabst (＠CharlottePabst) 10 Oct '24

10 Oct '24

This fixes a stack overflow in Helicon Focus 8.2.0, which was introduced by b5cbb556. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57293 I'm unsure if this is actually the proper way to approach this problem, since an application being so close to a stack overflow that an allocation of wchar_t[MAX_PATH] (=260*2 bytes) is making the difference between crashing and not crashing might be an issue in itself. However, the crash was introduced by adding this allocation (or rather, changing the condition for it to happen) in previous commit, so for now I think the proper solution would be to move it to the heap instead. -- v2: comdlg32: Allocate extbuf on heap rather than stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/6650

2 3

[PATCH 0/1] MR6650: comdlg32: Allocate extbuf on heap rather than stack.
by Charlotte Pabst (＠CharlottePabst) 10 Oct '24

10 Oct '24

This fixes a stack overflow in Helicon Focus 8.2.0, which was introduced by b5cbb556. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57293 I'm unsure if this is actually the proper way to approach this problem, since an application being so close to a stack overflow that an allocation of wchar_t[MAX_PATH] (=260*2 bytes) is making the difference between crashing and not crashing might be an issue in itself. However, the crash was introduced by adding this allocation (or rather, changing the condition for it to happen) in previous commit, so for now I think the proper solution would be to move it to the heap instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6650

3 2

[PATCH v4 0/6] MR6618: jscript: Allow ES5 keywords in identifiers.
by Gabriel Ivăncescu 10 Oct '24

10 Oct '24

-- v4: jscript: Allow ES5 keywords as identifiers in expressions. jscript: Allow ES5 keywords as identifiers in labelled statements. jscript: Allow ES5 keywords as identifiers in function parameter lists. jscript: Allow ES5 keywords as identifiers in function expressions. jscript: Allow ES5 keywords as identifiers in catch statements. jscript: Allow ES5 keywords as identifiers in variable declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/6618

2 8

[PATCH 0/8] MR6649: Draft: winex11: Replace foreign windows with a driver-only host window tracking.
by Rémi Bernon 10 Oct '24

10 Oct '24

Making all the windows handled by the driver to be either GL/VK client surfaces, or top-level windows. This avoids leaking host windows into the Win32 space, and makes it possible to get rid of some remaining NtUserMapWindowPoints in `map_event_coords` for mouse input. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6649

1 8

[PATCH v2 0/1] MR6635: mlang: Check handle validity in IMLangFontLink_GetFontCodePages.
by Haoyang Chen (＠chenhaoyang) 10 Oct '24

10 Oct '24

-- v2: mlang: Check handle validity in IMLangFontLink_GetFontCodePages. https://gitlab.winehq.org/wine/wine/-/merge_requests/6635

3 2

[PATCH v2 0/7] MR6640: propsys: Support converting to BSTR for PropVariantToVariant.
by Ziqing Hui (＠zhui) 10 Oct '24

10 Oct '24

This is based on top of !6526, will mark ready after !6526 is merged. -- v2: propsys: Support converting to BSTR for PropVariantToVariant. propsys: Fix a crash in tracing for VariantToPropVariant. propsys: Implement PropVariantToBSTR. propsys: Use msvcrt wide string functions. propsys/tests: Test truncating for PropVariantToString. propsys/tests: Test PropVariantToBSTR. propsys: Add PropVariantToBSTR stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/6640

4 12

[PATCH 0/5] MR6645: dplayx: Test fixes and a test for ADDFORWARD handling.
by Anton Baskanov (＠baskanov) 10 Oct '24

10 Oct '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6645

4 7

[PATCH v4 0/6] MR6639: shlwapi: Fix a few things in wnsprintf() format handling.
by Paul Gofman (＠gofman) 10 Oct '24

10 Oct '24

-- v4: shlwapi: Use printf implementation from ntdll. ntdll: Make 'h' take precedence over 'l' in pf_vsnprintf(). ntdll: Make 'l' modifier also affect char wideness. ntdll: Output unrecognized format symbol in pf_vsnprintf(). ntdll: Fix passing char argument to pf_handle_string_format(). ntdll/tests: Add more tests for printf format. https://gitlab.winehq.org/wine/wine/-/merge_requests/6639

3 9

[PATCH 0/1] MR6646: dplayx/tests: Correct Enum tests.
by Alistair Leslie-Hughes (＠alesliehughes) 10 Oct '24

10 Oct '24

The EnumAddressTypes tests wasn't actually calling the enum function. The code within the test_EnumAddressTypes function appear to be setup for calling EnumAddresses, so added a test for this scenario as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6646

3 2

[PATCH v3 0/6] MR6618: jscript: Allow ES5 keywords in identifiers.
by Gabriel Ivăncescu 10 Oct '24

10 Oct '24

-- v3: jscript: Allow ES5 keywords as identifiers in expressions. jscript: Allow ES5 keywords as identifiers in labelled statements. jscript: Allow ES5 keywords as identifiers in function parameter lists. jscript: Allow ES5 keywords as identifiers in function expressions. jscript: Allow ES5 keywords as identifiers in catch statements. jscript: Allow ES5 keywords as identifiers in variable declarations. https://gitlab.winehq.org/wine/wine/-/merge_requests/6618

1 7