November 2024 - Wine-gitlab

[PATCH 0/1] MR3226: comctl32/edit: Scroll caret on Ctrl+A.
by Vladislav Timonin (＠vt) 28 Nov '24

28 Nov '24

Every other use of `EDIT_EM_SetSel` updates caret position by calling `EDIT_EM_ScrollCaret` or `EDIT_SetCaretPos`. Fixes caret blinking in the middle when selecting all text. ![changes](/uploads/019bce6c12e0378d391e1253ecbaf9c6/changes.png) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3226

4 6

[PATCH v6 0/3] MR5924: Draft: mfmediaengine: Implement SVR.
by Brendan McGrath (＠redmcg) 28 Nov '24

28 Nov '24

This commit replaces the SampleGrabberSink with a dedicated Video Sink, referred to as the Simple Video Renderer (SVR). This brings it more inline with Windows and provides the benefit of having direct access to the IMFSample, removing the need to copy the sample data. -- v6: mfmediaengine: Fallback to sample copy if scaling is required. mfmediaengine: Implement D3D-aware video frame sink. mfmediaengine: Implement SVR. https://gitlab.winehq.org/wine/wine/-/merge_requests/5924

5 11

[PATCH v9 0/11] MR5444: jscript: Do not allocate dispex_prop_t for indexed props.
by Gabriel Ivăncescu 28 Nov '24

28 Nov '24

-- v9: jscript: Remove PROP_IDX dispex props by handling them in object prop methods. jscript: Move filling the PROTREF into a helper. jscript: Simplify get_flags to only check whether it's enumerable. jscript: Get rid of on_put in the object vtbl. jscript: Inline prop_put. jscript: Inline prop_get. jscript: Inline invoke_prop_func and invoke PROTREFs using their vtbl method. jscript: Inline delete_prop. jscript: Use mandatory methods in the object vtbl to operate on props found jscript: Use mandatory methods in the object vtbl to operate on props mshtml/tests: Test redefining a writable indexed prop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5444

2 14

[PATCH 0/6] MR6916: winevulkan: Use vulkan object header for other objects.
by Rémi Bernon 28 Nov '24

28 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6916

1 6

[PATCH 0/1] MR1121: winhttp: Fix missing reference upcount
by Yuan Yao (＠yaoyuan.0553) 28 Nov '24

28 Nov '24

The reference count of host is supposed to go up by one in netconn_create. The missing ref increment causes error handling paths where netconn_close or release_host is called to prematurely decrement the ref count of host to zero. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1121

4 6

[PATCH 0/1] MR6894: d3dx9: Remove superfluous null check (Coverity)
by Fabian Maurer (＠DarkShadow44) 28 Nov '24

28 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6894

4 3

[PATCH 0/1] MR6899: vkd3d: Import upstream release 1.14.
by Alexandre Julliard (＠julliard) 28 Nov '24

28 Nov '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6899

3 2

[PATCH 0/4] MR6866: Draft: ntdll: On macOS x86_64, swap GSBASE between the TEB and macOS TSD when entering/leaving PE code.
by Brendan Shanks (＠bshanks) 28 Nov '24

28 Nov '24

x86_64 Windows and macOS both use `%gs` to access thread-specific data (Windows TEB, macOS TSD). To date, Wine has worked around this conflict by filling the most important TEB fields (`0x30`/`Self`, `0x58`/`ThreadLocalStorage`) in the macOS TSD structure (Apple reserved the fields for our use). This was sufficient for most Windows apps. CrossOver's Wine had an additional hack to handle `0x60`/`ProcessEnvironmentBlock`, and binary patches for certain CEF binaries which directly accessed `0x8`/`StackBase`. Additionally, Apple's libd3dshared could activate a special mode in Rosetta 2 where code executing in certain regions would use the Windows TEB when accessing `%gs`. Now that the PE separation is complete, GSBASE can be swapped when entering/exiting PE code. This is done in the syscall dispatcher, unix-call dispatcher, and for user-mode callbacks. GSBASE also needs to be set to the macOS TSD when entering signal handlers (in `init_handler()`), and then restored to the Windows TEB when exiting (in `leave_handler()`). There is a special-case needed in `usr1_handler`: when inside a syscall (on the kernel stack), GSBASE may need to be reset to either the TEB or the TSD. The only way to tell is to determine what GSBASE was set to on entry to the signal handler. --- macOS does not have a public API for setting GSBASE, but the private `_thread_set_tsd_base()` works and was added in macOS 10.12. `_thread_set_tsd_base()` is a small thunk that sets `%esi`, `%eax`, and does the `syscall`: https://github.com/apple-oss-distributions/xnu/blob/8d741a5de7ff4191bf97d57…. The syscall instruction itself clobbers `%rcx` and `%r11`. I've tried to save as few registers as possible when calling `_thread_set_tsd_base()`, but there may be room for improvement there. --- I've tested this successfully on macOS 15 (Apple Silicon and Intel) with several apps and games, including the `cefclient.exe` CEF sample. I still need to test this patch on macOS 10.13, and I'd also like to do some performance testing. --- I also tested an alternate implementation strategy for this which took advantage of the expanded "full" thread state which is passed to signal handlers when a process has set a user LDT. The full thread state includes GSBASE, so GSBASE is set back to whatever is in the sigcontext on return (like every other field in the context). This would avoid needing to explicitly reset GSBASE in `leave_handler()`, and avoid the special-case in `usr1_handler()`. This strategy was simpler, but I'm not using it for 2 reasons: - the "full" thread state is only available starting with macOS 10.15, and we still support 10.13. - more crucially, Rosetta 2 doesn't seem to correctly implement the GS.base field of the full thread state. It's set to 0 on entry, and isn't read on exit. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6866

5 16

[PATCH 0/1] MR6913: uxtheme: Check DrawThemeEdge() content rectangle pointer.
by Zhiyi Zhang (＠zhiyi) 28 Nov '24

28 Nov '24

Otherwise, applications that call DrawThemeEdge() with BF_ADJUST and a NULL content rectangle pointer will crash. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6913

3 2

Re: [PATCH v7 0/3] MR4826: Mach vm operations improvements
by Brendan Shanks (＠bshanks) 28 Nov '24

28 Nov '24

I'd still like to test these out (particularly with some games/launchers that are known to use cross-process memory writes) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4826#note_89090

1 0