November 2024 - Wine-gitlab

[PATCH v4 0/7] MR6892: dlls/propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) 23 Nov '24

23 Nov '24

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v4: dlls/propsys: Implement IPropertyDescription for several known system properties. dlls/propsys: Add IPropertyDescription stub for system defined properties. dlls/propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. dlls/propsys: Add stubs for PSGetNameFromPropertyKey. dlls/propsys: Add stubs for PropertySystem. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

3 8

[PATCH v3 0/7] MR6892: dlls/propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) 23 Nov '24

23 Nov '24

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- v3: dlls/propsys: Implement IPropertyDescription for several known system properties. dlls/propsys: Add IPropertyDescription stub for system defined properties. dlls/propsys/tests: Add conformance tests for PSGetNameFromPropertyKey. dlls/propsys: Add stubs for PSGetNameFromPropertyKey. dlls/propsys: Add stubs for PropertySystem. dlls/propsys/tests: Add conformance tests for PSGetPropertyKeyFromName. dlls/propsys/tests: Add conformance tests for getting PropertyDescriptions from PropertySystem. https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

3 8

[PATCH 0/7] MR6892: dlls/propsys: Implement IPropertyDescription for several known system properties.
by Vibhav Pant (＠vibhavp) 23 Nov '24

23 Nov '24

This MR adds a very basic implementation of `IPropertyDescription` for system defined properties (i.e, the ones in \<propkey.h\>). This is needed to support the [`Properties`](https://learn.microsoft.com/en-us/uwp/api/windows.devices.enumeration.deviceinformation.properties?view=winrt-26100) method for `IDeviceInformation` in Windows.Devices.Enumeration (!6874). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6892

3 8

[PATCH 0/1] MR6891: cmd: Use CD /D to change directory in POPD (same as PUSHD)
by huangqinjin (＠huangqinjin) 23 Nov '24

23 Nov '24

Fixes https://bugs.winehq.org/show_bug.cgi?id=57137 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6891

3 2

[PATCH v20 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 23 Nov '24

23 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v20: timeout: add minimal test suite timeout: Windows 10 introduce the timeout command https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v2 0/2] MR6289: dsound: Reject NaN values in some functions.
by Aida Jonikienė 23 Nov '24

23 Nov '24

The tests aren't really tested though (they partially require interactive mode and they caused lag issues on one person's machine). -- v2: dsound/tests: Add NaN tests for floating-point 3D functions. dsound: Reject NaN values in floating-point 3D functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/6289

1 2

[PATCH v3 0/2] MR6884: Draft: Iphlpapi.dll: Included SendARP
by Thi Garlet (＠garlett) 23 Nov '24

23 Nov '24

Returns MAC address by: - search local interfaces, or - send UDP packed that does not need linux privilege, then search local cache solve https://bugs.winehq.org/show_bug.cgi?id=9418 files updated - /dlls/iphlpapi/iphlpapi_main.c - /dlls/iphlpapi/tests/iphlpapi.c -- v3: Returns MAC address by: https://gitlab.winehq.org/wine/wine/-/merge_requests/6884

4 3

[PATCH 0/1] MR6890: win32u: Use boolean instead of bool as name of a union member.
by Gerald Pfeifer (＠gerald) 23 Nov '24

23 Nov '24

bool is a reserved identifier in C23 and would break with GCC 15 moving to -std=gnu23 (based on C23). Use boolean instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6890

3 2

Re: [PATCH v5 0/1] MR5924: Draft: mfmediaengine: Implement SVR.
by Nikolay Sivov (＠nsivov) 22 Nov '24

22 Nov '24

Some things to test: * could we use sample allocator unconditionally? In other words, is it possible to get SVR used when no device manager was provided; * EVR has a circular buffer logic, so maybe we could copy from there; * it would be great if we could get rid of locking sample buffer for copies, and that should be possible if we always have d3d samples. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5924#note_88688

1 0

Re: [PATCH v5 0/1] MR5924: Draft: mfmediaengine: Implement SVR.
by Nikolay Sivov (＠nsivov) 22 Nov '24

22 Nov '24

Nikolay Sivov (@nsivov) commented about dlls/mfmediaengine/video_frame_sink.c: > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFMediaEventGenerator_iface); > +} > + > +static struct video_frame_sink *impl_from_IMFStreamSink(IMFStreamSink *iface) > +{ > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFStreamSink_iface); > +} > + > +static struct video_frame_sink *impl_from_IMFMediaTypeHandler(IMFMediaTypeHandler *iface) > +{ > + return CONTAINING_RECORD(iface, struct video_frame_sink, IMFMediaTypeHandler_iface); > +} > + > +static void video_frame_sink_samples_release(struct video_frame_sink *sink) > +{ > + for (int i = 0; i < ARRAYSIZE(sink->sample); i++) ARRAY_SIZE is more common throughout the codebase. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5924#note_88682

1 0