November 2024 - Wine-gitlab

Re: [PATCH v2 0/8] MR6887: mshtml: Implement proper prototype chain for text nodes and events.
by Gabriel Ivăncescu 22 Nov '24

22 Nov '24

On Fri Nov 22 15:44:33 2024 +0000, Jacek Caban wrote: > Yeah, it shows that those interfaces do not reflect prototypes. In a > sense, `IHTMLDOMTextNode2` is as bad for `CharacterData` as > `IHTMLCommentElement2`. Do we have a lot of cases like that? I'm > wondering if we need to change the mechanism or could we just introduce > a private `IHTMLCharacterData` interface. Other than this, only CSS-related styles/stylesheets have a similar case like this, but those are more convoluted. I also don't see how introducing a private interface helps to simplify it. We'd still have to expose it (and forward) in comment elements, but now we'd also have to expose and forward it in text nodes, making it actually less simple, IMO. But is my forwarding a good idea? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6887#note_88530

1 0

Re: [PATCH v2 0/8] MR6887: mshtml: Implement proper prototype chain for text nodes and events.
by Jacek Caban (＠jacek) 22 Nov '24

22 Nov '24

On Fri Nov 22 15:40:33 2024 +0000, Gabriel Ivăncescu wrote: > On second thought maybe just forwarding to `IHTMLCommentElement2` would > be enough, but we still need the `IHTMLDOMTextNode2` so the prototype > works right? Yeah, it shows that those interfaces do not reflect prototypes. In a sense, `IHTMLDOMTextNode2` is as bad for `CharacterData` as `IHTMLCommentElement2`. Do we have a lot of cases like that? I'm wondering if we need to change the mechanism or could we just introduce a private `IHTMLCharacterData` interface. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6887#note_88529

1 0

Re: [PATCH v2 0/8] MR6887: mshtml: Implement proper prototype chain for text nodes and events.
by Gabriel Ivăncescu 22 Nov '24

22 Nov '24

On Fri Nov 22 15:39:38 2024 +0000, Gabriel Ivăncescu wrote: > Interesting, but I'm not sure. The issue here is that these are in the > `CharacterDataPrototype`, not in the comment element itself. So, won't > they fail if we don't handle `IHTMLDOMTextNode2` when called on the > comment element? Since it's looked up by IID/DISPID pair, not name. > `IHTMLCommentElement2` might be used for legacy modes though, I guess I > will need to test it from C code to know. On second thought maybe just forwarding to `IHTMLCommentElement2` would be enough, but we still need the `IHTMLDOMTextNode2` so the prototype works right? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6887#note_88528

1 0

[PATCH v3 0/3] MR6882: secur32, urlmon, wininet: Fix some failing tests.
by Rémi Bernon 22 Nov '24

22 Nov '24

Probably caused by some winehq.org HTTP server update, it now supports HTTP/2 and sends "Upgrade, Keep-Alive" connection strings (was "Keep-Alive" before). -- v3: wininet: Parse multi-token Connection strings for Keep-Alive. https://gitlab.winehq.org/wine/wine/-/merge_requests/6882

2 6

Re: [PATCH v2 0/8] MR6887: mshtml: Implement proper prototype chain for text nodes and events.
by Gabriel Ivăncescu 22 Nov '24

22 Nov '24

On Fri Nov 22 15:33:09 2024 +0000, Jacek Caban wrote: > Shouldn't it be `IHTMLCommentElement2` instead? Interesting, but I'm not sure. The issue here is that these are in the `CharacterDataPrototype`, not in the comment element itself. So, won't they fail if we don't handle `IHTMLDOMTextNode2` when called on the comment element? Since it's looked up by IID/DISPID pair, not name. `IHTMLCommentElement2` might be used for legacy modes though, I guess I will need to test it from C code to know. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6887#note_88525

1 0

Re: [PATCH v2 0/8] MR6887: mshtml: Implement proper prototype chain for text nodes and events.
by Jacek Caban (＠jacek) 22 Nov '24

22 Nov '24

Jacek Caban (@jacek) commented about dlls/mshtml/htmlcomment.c: > struct HTMLCommentElement { > HTMLElement element; > IHTMLCommentElement IHTMLCommentElement_iface; > + IHTMLDOMTextNode IHTMLDOMTextNode_iface; > + IHTMLDOMTextNode2 IHTMLDOMTextNode2_iface; Shouldn't it be `IHTMLCommentElement2` instead? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6887#note_88523

1 0

[PATCH v14 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 22 Nov '24

22 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v14: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v16 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 22 Nov '24

22 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v16: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

2 2

[PATCH v13 0/2] MR6869: timeout: Windows 10 introduce the timeout command
by Michele Dionisio (＠michele.dionisio) 22 Nov '24

22 Nov '24

Windows 10 and 11 introduce the timeout.exe command. This is a similar program with same argument options -- v13: timeout: add minimal test suite https://gitlab.winehq.org/wine/wine/-/merge_requests/6869

3 3

[PATCH v2 0/3] MR6882: secur32, urlmon, wininet: Fix some failing tests.
by Rémi Bernon 22 Nov '24

22 Nov '24

Probably caused by some winehq.org HTTP server update, it now supports HTTP/2 and sends "Upgrade, Keep-Alive" connection strings (was "Keep-Alive" before). -- v2: wininet: Parse multi-token Connection strings for Keep-Alive. https://gitlab.winehq.org/wine/wine/-/merge_requests/6882

1 5