December 2024 - Wine-gitlab

[PATCH v7 0/2] MR6904: ntdll.dll: Update NtQueryDirectoryFile to align with current Windows behaviour
by Eugene McArdle (＠eugenemcardle) 29 Jan '25

29 Jan '25

This PR updates the behaviour of `NtQueryDirectoryFile`, bringing it in line with current Windows behaviour. The need for this update was discovered when attempting to build the Unreal Engine with MSVC under Wine. In certain cases conditional include statements do not behave as expected, due to MSVC depending on undocumented behaviour of `NtQueryDirectoryFile`. We ran tests on multiple versions of Windows, and discovered that the behaviour has changed since the original Wine implementation, but the documentation has not. The source code for our test tool, and a set of results can be found [here](https://github.com/TensorWorks/NtQueryDirectoryFile-Test). As of Windows 8, calling `NtQueryDirectoryFile` with a re-used handle, a new mask, and setting the `RestartScan` flag to True, causes the cached results to be erased and a new scan to be performed with the updated mask. Currently, Wine performs as did earlier versions of Windows, where the changed mask is ignored, and the cache is reused. This can cause `NtQueryDirectoryFile` under Wine to falsely report that files exist, when they do not. This PR corrects this behaviour, invalidating the cache when required. Implementing this exposed further undocumented behaviour of `NtQueryDirectoryFile`, where a search for a non-existent file will return either `STATUS_NO_MORE_FILES` or `STATUS_NO_SUCH_FILE`, depending on whether or not the handle had been previously used regardless of the value of `RestartScan`. This was reflected in a `winetest` which allowed for the response to be either `STATUS_SUCCESS` or `STATUS_NO_MORE_FILES`. This patch also adds unit tests for the new behaviour of `NtQueryDirectoryFile`. These tests pass when running `winetest` under Windows, and under Wine with these changes in place, but they will fail under older versions of Wine. If run under older versions of Windows the test suite will detect that this functionality is not supported, and will not run the updated tests. -- v7: ntdll: Update NtQueryDirectoryFile to purge cache if scan is reset with a new mask ntdll: Test updated NtQueryDirectoryFile mask reset behaviour https://gitlab.winehq.org/wine/wine/-/merge_requests/6904

5 19

[PATCH 0/1] MR3109: imm32: Don't export internal variables.
by Alex Henrie (＠alexhenrie) 24 Jan '25

24 Jan '25

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/3109

6 22

[PATCH 0/6] MR6849: quartz: Simplify DirectSound Renderer Filter sample handling.
by Rémi Bernon 24 Jan '25

24 Jan '25

This has been in Proton for two years at least, it helped reduce buffer underruns and induced cracking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6849

2 9

[PATCH 0/2] MR6679: winetest: Compress embedded test executables.
by Rémi Bernon 24 Jan '25

24 Jan '25

Reducing `winetest.exe` size from ~240MB to ~80MB. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6679

2 6

[PATCH 0/12] MR5680: win32u: Implement per-monitor DPI scaling for virtual display modes.
by Rémi Bernon 24 Jan '25

24 Jan '25

For winewayland display modes emulation, instead of https://gitlab.winehq.org/wine/wine/-/merge_requests/5057. Also this could be a move toward implementing some kind of fshack upstream. (Also includes !5679, I'll rebase it when it is merged). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5680

3 16

[PATCH v2 0/5] MR5814: d3dx9, d3dcompiler: Do not emit implicit truncation warnings before version 42.
by Elizabeth Figura (＠zfigura) 24 Jan '25

24 Jan '25

-- v2: d3dx9: Link versions 42 and 43 to the corresponding d3dcompiler DLL. d3dx9: Reimplement D3DXCompileShader() for versions before 42. d3dcompiler: Use D3DCompile2VKD3D() from vkd3d-utils. d3dcompiler: Use D3DPreprocess() from vkd3d-utils. vkd3d: Import vkd3d-utils. https://gitlab.winehq.org/wine/wine/-/merge_requests/5814

4 11

[PATCH v3 0/4] MR6855: server: Fix renaming file to a hardlink of itself.
by Gabriel Ivăncescu 13 Jan '25

13 Jan '25

-- v3: server: When renaming, only fstat the source once. server: Remove source when renaming to a hardlink of itself. kernel32/tests: Test renaming a file into a hardlink of itself. kernel32/tests: Use FindClose instead of CloseHandle when closing https://gitlab.winehq.org/wine/wine/-/merge_requests/6855

2 13

[PATCH 0/1] MR7054: gdiplus: Use font linking only for missing glyphs.
by Esme Povirk (＠madewokherd) 07 Jan '25

07 Jan '25

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57076 I don't know if this is how native does it, but it makes intuitive sense to me that if we have a glyph in the requested font, we should use it, and this fixes the bug in question. This should avoid the possibility of regression in cases where font linking isn't needed. There is a possibility of regression in corner cases handled better by the earlier version of font linking. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7054

3 7

[PATCH v2 0/3] MR7037: ddraw: Clear sysmem textures on the CPU.
by Elizabeth Figura (＠zfigura) 07 Jan '25

07 Jan '25

-- v2: ddraw: Clear sysmem textures on the CPU. https://gitlab.winehq.org/wine/wine/-/merge_requests/7037

4 6

[PATCH v2 0/1] MR7068: vbscript: class single line multivar
by Francis De Brabandere (＠francisdb) 06 Jan '25

06 Jan '25

closes https://bugs.winehq.org/show_bug.cgi?id=53644 * This applies the patch [provided by](https://bugs.winehq.org/show_bug.cgi?id=53644) @sloper42 and adds tests. * I left a TODO for accessing class variables of type array for a later mr. -- v2: vbscript: class single line multivar https://gitlab.winehq.org/wine/wine/-/merge_requests/7068

3 3