December 2024 - Wine-gitlab

[PATCH 0/1] MR7066: comctl32/tests: Fix test array size (ASan).
by Nikolay Sivov (＠nsivov) 23 Dec '24

23 Dec '24

Test tests are using larger array starting with 1bd27e50d25fd057a57fec89f06d6e20176c5ef4. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7066

3 4

Re: [PATCH v6 0/2] MR7060: scrrun/tests: Add drive_get_path test
by Quinn Rafferty (＠ramleejo) 22 Dec '24

22 Dec '24

On Sun Dec 22 18:39:49 2024 +0000, Nikolay Sivov wrote: > What does it return for network drives? > P.S. I see you closed !7050, please reuse same MR next time, that > preserves comments and commits history. Good question, this morning I shared a drive over smb from my Mac to my Windows 11 computer. I mounted the network drive and verified it worked. I re-ran the tests on Windows and drive_get_path was still outputting the drive letter and a colon "W:", even for the network drive. I am happy to add more specific tests with network drives if you think that would be beneficial? Thanks for your feedback, I am very new to wine's code-base and really appreciate it. I apologize on the MR, thank you for the information. I had read your feedback that I needed to clean it (the last MR) and mistook that to mean make a new one, especially since my code was very different. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7060#note_91071

1 0

Re: [PATCH v2 0/1] MR7017: ntdll: Set the correct character map name for Shift JIS
by Zsolt Vadász 22 Dec '24

22 Dec '24

On Sun Dec 22 17:58:32 2024 +0000, Akihiro Sagawa wrote: > From my point of view, SJIS is correct. > Here is an example of SJIS locale usage written by [Red > Hat](https://access.redhat.com/solutions/727043) and > [HP-UX](https://web.archive.org/web/20061206132454/http://docs.hp.com/en/UXL… > (see Appendix A). > Historically, until around 2000, the Japanese UNIX environment mainly > used an encoding different from Shift-JIS, called EUC-JP (Extended Unix > Code for Japanese). Therefore, with the exception of HP-UX, SJIS has > rarely been used in locale settings. I'm not well versed in the topic, I wrote this patch, because on two of my systems (Mint and Artix), the charmap file is named SHIFT_JIS rather than SJIS. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7017#note_91069

1 0

[PATCH v3 0/2] MR7064: Draft: ntdll: Check for invalid %gs value in 32-bit code on WoW64.
by William Horvath (＠whrvth) 22 Dec '24

22 Dec '24

Adapted from [check_invalid_gs](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad… in signal_i386.c. This prevents crashing when the %gs register is manipulated in 32-bit code on "new-style" WoW64. [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) is a simple reproduction of the crash, courtesy of Fabian Maurer from the Bugzilla comments. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 -- v3: ntdll: Check for invalid %gs value in 32-bit code on WoW64. https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

3 5

Re: [PATCH v6 0/2] MR7060: scrrun/tests: Add drive_get_path test
by Nikolay Sivov (＠nsivov) 22 Dec '24

22 Dec '24

What does it return for network drives? P.S. I see you closed !7050, please reuse same MR next time, that preserves comments and commits history. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7060#note_91053

1 0

[PATCH 0/1] MR7065: comctl32/tests: Use sufficient user data buffer in the Tab tests (ASan)
by Nikolay Sivov (＠nsivov) 22 Dec '24

22 Dec '24

The issue here is that TCITEM is not enough to hold lparam over sizeof(LPARAM). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7065

2 2

[PATCH v2 0/2] MR7064: Draft: ntdll: Check for invalid %gs value in 32-bit code on WoW64.
by William Horvath (＠whrvth) 22 Dec '24

22 Dec '24

Adapted from [check_invalid_gs](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad… in signal_i386.c. This prevents crashing when the %gs register is manipulated in 32-bit code on "new-style" WoW64. [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) is a simple reproduction of the crash, courtesy of Fabian Maurer from the Bugzilla comments. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 -- v2: ntdll: Check for invalid %gs value in 32-bit code on WoW64. ntdll: Allow get_current_teb assembly to be used on all platforms. https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

2 3

[PATCH 0/1] MR7064: ntdll: Check for invalid %gs value in 32-bit code on WoW64.
by William Horvath (＠whrvth) 22 Dec '24

22 Dec '24

Adapted from check_invalid_gs in [signal_i386.c](https://gitlab.winehq.org/wine/wine/-/blob/d7a7cae2e2d1ad34a…. This prevents crashing when the %gs register is manipulated in 32-bit code on "new-style" WoW64. [test.c](https://bugs.winehq.org/attachment.cgi?id=77444) is a simple reproduction of the crash, courtesy of Fabian Maurer from the Bugzilla comments. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57444 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7064

3 3

[PATCH 0/11] MR7063: win32u: More fixes for arcs.
by Elizabeth Figura (＠zfigura) 22 Dec '24

22 Dec '24

This time including some regression tests. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7063

3 12

[PATCH 0/1] MR7062: dwrite: Avoid stack-buffer-overflow in arabic_setup_masks.
by Nikolay Sivov (＠nsivov) 22 Dec '24

22 Dec '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/7062

2 2