March 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/1] MR5070: win32u: Cache is_virtual_desktop.
by Gabriel Ivăncescu 28 May '24

28 May '24

It can be substantially faster in some cases. Notepad++ (with several plugins) start up goes down from around ~1.03 sec to ~0.61 sec on my machine (with wineprefix active). 9b7669592d6f8b40976b571b70f8543777d35167 is what introduced this performance regression. I don't know why exactly, but it made my Notepad++ noticeably slower when launched from a file manager (so it's not just at wineprefix startup overhead), which is very annoying. -- v2: win32u: Cache is_virtual_desktop. https://gitlab.winehq.org/wine/wine/-/merge_requests/5070

2 7

[PATCH v4 0/2] MR2120: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications
by Evan Tang (＠etang-cw) 28 May '24

28 May '24

This seems to be relied on by some versions of [this Unreal Engine input plugin](https://www.unrealengine.com/marketplace/en-US/product/wm-input-man… Note: I'm not sure how to deal with `HID_USAGE_GENERIC_KEYPAD`, which (I think) would fall under `RIM_TYPEKEYBOARD`. Do we need to store extra info to differentiate these from `HID_USAGE_GENERIC_KEYBOARD` or is there something in the device info struct that can differentiate them? -- v4: user32: Post WM_INPUT_DEVICE_CHANGE when registering for notifications user32: Add tests for WM_INPUT_DEVICE_CHANGE messages https://gitlab.winehq.org/wine/wine/-/merge_requests/2120

3 4

[PATCH 0/3] MR5383: oleaut32: Load bitmap as DIB.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5383

3 8

[PATCH v3 0/1] MR5333: vcruntime140_1: Pass original frame to catch block on stack.
by Daniel Lehman (＠dlehman25) 28 May '24

28 May '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56451 local variables with alignas(32) or higher may cause the unwinding code to fetch the original frame from a different spot on the stack from where the catch block code places it -- v3: vcruntime140_1: Pass original frame to catch block on stack. https://gitlab.winehq.org/wine/wine/-/merge_requests/5333

3 3

[PATCH v6 0/1] MR5211: ntdll/unix: Use termios2 for serial when possible.
by Kirill Zhumarin (＠kirill.zhumarin) 28 May '24

28 May '24

Termios2 is a modern Linux feature thats allows usage of any custom baudrate instead of hardcoded values from the 1970's. Also, this patch improves compatibility with the win32 api, because windows allow any custom baudrates by design. Example software for which this patch is needed: http://www.vi-soft.com.ua/index_e.htm This software for reading/writing/patch fullflash of Siemens mobile phones, where serial speed is important. V-Klay uses 1600000 baudrate and perfectly works on Linux with termios2 and Prolific PL2303. -- v6: ntdll/unix: Use termios2 for serial when possible. https://gitlab.winehq.org/wine/wine/-/merge_requests/5211

5 10

[PATCH v66 0/6] MR2786: Add support for AF_UNIX sockets
by Ally Sommers (＠dropbear) 28 May '24

28 May '24

Windows 10 [received support](https://devblogs.microsoft.com/commandline/af_unix-comes-to-window… for AF_UNIX sockets in Insider Build 17063. This merge request adds basic support for AF_UNIX sockets to ws2_32 and wineserver. Of particular note is the difficulty in handling `sun_path`. Most of the functions that allow for translating Windows paths to Unix paths are not accessible from ws2_32. I considered the following options: * Pass the Windows path to wineserver and do the conversion there. * This is, as far as I can tell, not possible without major rearchitecting. wineserver does not have functions to translate Windows paths to Unix paths, for obvious reasons. * Obtain the current working directory of the requesting process and temporarily change directories to there. * This only handles relative paths and fails for absolute paths, UNC paths, etc. * Conditionally change directories based on whether the path is relative or not. * This is error-prone and wineserver does not have the requisite functions to do this cleanly. I ultimately decided to pass the translated Unix path to wineserver, which changes directories to `dirname(path)`. It then provides `bind` and `connect` with `basename(path)`. This is not threadsafe, but wineserver is not (currently) multithreaded. Abstract sockets are not fully supported by this patch, matching the behavior of Windows. -- v66: ws2_32/tests: Add test for AF_UNIX sockets. server: Fix getsockname() and accept() on AF_UNIX sockets. server: Introduce error when attempting to create a SOCK_DGRAM AF_UNIX socket. server: Allow for deletion of socket files. ws2_32: Add support for AF_UNIX sockets. ws2_32: Add afunix.h header. https://gitlab.winehq.org/wine/wine/-/merge_requests/2786

7 22

[PATCH v2 0/5] MR4624: wined3d: More old-GL fixes.
by Matteo Bruni (＠Mystral) 28 May '24

28 May '24

-- v2: d3d9/tests: Skip test_sample_attached_rendertarget() without pixel shaders support. wined3d: Don't override texture parameters for COND_NP2 on multisample textures. wined3d: Don't skip FFP projection transform update. d3d9: Don't do instanced draws in DrawPrimitive() and DrawPrimitiveUP(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4624

2 8

[PATCH 0/2] MR3929: ntdll: Remove entries from queue in RtlWakeAddressAll().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

This avoids one case of spurious wakeup of WaitOnAddress (which could be triggered by prior race on consequent WakeAddressAll and a thread trying to wake on that, leaving the waking thread in an alerted state). And fixes Resident Evil games randomly crashing due to unhandled spurious SleepConditionVariableCS wakeups. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3929

4 8

[PATCH v14 0/8] MR1074: Draft: ntdll: Improve Valgrind and GDB integration.
by Rémi Bernon 28 May '24

28 May '24

Valgrind support requires a fork, which I've published to https://gitlab.winehq.org/rbernon/valgrind. The fork implements loading DWARF debug info from PE files, instead of the old and broken upstream PDB support. I've tried to upstream these changes a long time ago but didn't receive any feedback. I think we could maybe consider keeping a fork, which I'm happy to maintain, as the changes aren't too large. We may want to investigate adding 32-on-64 support, which may require a bit more changes (to VEX specifically, because its amd64 guest doesn't support segment register manipulation). The changes here are not all related to Valgrind, and I'll create separate MR for those which may make sense independently from Valgrind / GDB. Also included is a suppression file to silent some annoying false positives, many of which are coming from the cross-stack accesses during syscalls, which are confusing Valgrind's stack heuristics. One can try this out with something like: `WINELOADERNOEXEC=1 valgrind --suppressions=tools/valgrind.supp wine64/loader/wine64 wine64/programs/winecfg/winecfg.exe` -- v14: ntdll: Avoid marking freed block header as undefined for valgrind. ntdll: Force HEAP_TAIL_CHECKING_ENABLED flag with valgrind. ntdll: Fix valgrind notifications from ntdll.so. ntdll: Import valgrind headers for PE side ntdll. DEBUG: ntdll: Don't use preloader when running on valgrind. tools: Add gdbunwind.py script with a syscall unwinder. ntdll: Maintain a PE module link map and expose it to GDB. loader: Expose the standard debugging symbols for GDB. https://gitlab.winehq.org/wine/wine/-/merge_requests/1074

3 12

[PATCH 0/4] MR4424: ntdll: Implement reading multiple entries in NtQueryDirectoryObject. (#52585)
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4424

5 11