March 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR5413: user32/tests: Revert test updates for win11.
by Esme Povirk (＠madewokherd) 27 Mar '24

27 Mar '24

With the info I now have, I don't think updating the expected sequence is the right approach. Since it only occurs in a full test run on testbot, my options for investigating are limited. We need to either figure out what's weird about the state when newtb-w11pro64-amd-64 runs this test, or isolate it. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5413

2 1

[PATCH 0/2] MR738: tests/test-driver Miscelaneous improvements.
by Francisco Casas (＠fcasas) 27 Mar '24

27 Mar '24

Some times the test can be aborted for reasons others than failed assertions, such as segmentation faults or reaching unreacheable code. To speed up noticing these problems, the `[SIGABRT]` and `[SIGSEGV]` tags are printed on the corresponding exit codes. Also, "reached unreachable code" lines are also detected and printed with an [AF] tag. An error may look like this: ``` FAIL: tests/hlsl/some-test.shader_test (SM4.0-SM5.1)OpenGL/SPIR-V 43[XF] 79[XF] 126[XF] 149[XF] 159[XF] [AF] vkd3d/libs/vkd3d-shader/hlsl.c:246: Aborting, reached unreachable code. [SIGABRT] Aborted (core dumped) ``` -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/738

3 3

[PATCH 0/2] MR736: vkd3d-shader/dxil: Implement DX intrinsic Discard.
by Conor McCarthy (＠cmccarthy) 27 Mar '24

27 Mar '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/736

4 4

[PATCH 0/1] MR735: vkd3d-shader: Add a compile option to control whether implicit truncation warnings are printed.
by Zebediah Figura (＠zfigura) 27 Mar '24

27 Mar '24

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/735

4 5

Re: [PATCH v2 0/9] MR729: vkd3d-shader/fx: Improvements to fx_2_0 output. - approved
by Henri Verbeet (＠hverbeet) 27 Mar '24

27 Mar '24

This merge request was approved by Henri Verbeet. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/729

1 0

[PATCH v5 0/7] MR724: vkd3d-shader/hlsl: Improve SM1 support for non-float operations, part 4.
by Francisco Casas (＠fcasas) 27 Mar '24

27 Mar '24

SM1 support for LOGIC_NOT, LOGIC_OR, and LOGIC_AND. -- v5: vkd3d-shader/spirv: Throw compiler error on unrecognized register. vkd3d-shader/spirv: Implement VKD3DSIH_ABS. vkd3d-shader/d3dbc: Implement HLSL_OP2_LOGIC_AND for SM1. vkd3d-shader/d3dbc: Implement HLSL_OP2_LOGIC_OR for SM1. vkd3d-shader/hlsl: Cast to bool before applying LOGIC_NOT. vkd3d-shader/hlsl: Support LOGIC_NOT for SM1. tests: Add tests for LOGIC_NOT on uniforms. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/724

4 8

[PATCH v11 0/9] MR707: vkd3d-shader/dxil: TGSM part 2.
by Conor McCarthy (＠cmccarthy) 27 Mar '24

27 Mar '24

-- v11: vkd3d-shader/spirv: Handle the sequentially consistent ordering flag for atomic instructions. vkd3d-shader/spirv: Emit a warning if the atomic instruction volatile flag is unhandled. vkd3d-shader/dxil: Implement the DXIL ATOMICRMW instruction. vkd3d-shader/dxil: Implement DX instructions ThreadId, GroupId, ThreadIdInGroup and FlattenedThreadIdInGroup. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/707

4 12

[PATCH v3 0/1] MR691: vkd3d: Add a changelog for all the released versions of vkd3d.
by Giovanni Mascellani (＠giomasce) 27 Mar '24

27 Mar '24

It will soon need an update, but do people at least like the idea? -- v3: Add a changelog for all the released versions of vkd3d. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/691

6 9

[PATCH v9 0/13] MR626: vkd3d-utils: Constant buffer reflection without vkd3d-shader.
by Zebediah Figura (＠zfigura) 27 Mar '24

27 Mar '24

As per discussion in 606, plumbing constant buffer reflection through vkd3d-shader requires interface design and API documentation for an interface which is inherently quite specific to one format. Instead of wasting time on this interface, just implement RDEF parsing in vkd3d-utils itself. If we change our mind about this, we can always move the implementation to vkd3d-shader anyway. This does not copy the existing implementation from Wine, because: * Wine does not validate offsets; adding this changes the parsing code significantly; * Wine incorrectly handles types, deduplicating them into an rbtree; * Wine skips several fields which I have been able to find the purpose of. The implementation is not that complex to begin with, so reimplementing it from scratch is not much work. -- v9: tests: Add more tests for resource and struct RDEF contents. tests: Test constant and resource reflection via D3DReflect(). vkd3d-shader/tpf: Set the user-packed flag for sm5.0 resources as well. vkd3d-shader/tpf: Write the component count as the column count for structs. vkd3d-shader/tpf: Explicitly write the class and base type for non-numeric types. vkd3d-shader/tpf: Do not write structs with no numeric fields into the RDEF. vkd3d-shader/hlsl: Allocate register reservations for structs as well. vkd3d-shader/tpf: Do not write non-numeric struct fields into the RDEF. vkd3d-utils: Implement ID3D12ShaderReflectionType::GetMemberTypeByIndex(). vkd3d-utils: Implement ID3D12ShaderReflectionVariable::GetType(). vkd3d-utils: Implement ID3D12ShaderReflectionConstantBuffer::GetVariableByIndex(). vkd3d-utils: Parse the RD11 section. vkd3d-utils: Implement ID3D12ShaderReflection::GetConstantBufferByIndex(). https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/626

3 15

[PATCH v3 0/1] MR723: vkd3d-shader/spirv: Implement MAD in two operations if flagged as precise.
by Conor McCarthy (＠cmccarthy) 27 Mar '24

27 Mar '24

This would eliminate the todo for the precise mad() test in !718. Maybe we need test results on nvidia and intel to decide if we actually want this. -- v3: vkd3d-shader/spirv: Implement MAD in two operations if flagged as precise. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/723

4 3