April 2024 - Wine-gitlab - list.winehq.org

[PATCH v6 0/8] MR5419: quartz: Fixes for the BURIKO visual novel engine's videos
by Alfred Agrell (＠Alcaro) 28 May '24

28 May '24

The BURIKO visual novel engine (as seen in, for example, https://store.steampowered.com/app/1200720/MakingLovers/) demands that the upstream filter tries to connect with a MPEG format type. Then it memorizes the resolution, rejects the connection, and expects upstream to try RGB32 or RGB24 instead. It also passes an empty string as filename, and demands this exact error code. I have no idea why. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56491 -- v6: quartz: Fix memory leak on failure path. quartz/tests: Test the new error codes. quartz: Fix error code on empty filename. quartz/tests: Test that compressed formats are offered for MPEGs. https://gitlab.winehq.org/wine/wine/-/merge_requests/5419

3 10

[PATCH v2 0/1] MR5445: mmdevapi: Implement SAC_IsAudioObjectFormatSupported().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

Fixes missing audio in BOOMEROAD. -- v2: mmdevapi: Implement SAC_IsAudioObjectFormatSupported(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5445

3 3

[PATCH v5 0/8] MR5419: quartz: Fixes for the BURIKO visual novel engine's videos
by Alfred Agrell (＠Alcaro) 28 May '24

28 May '24

The BURIKO visual novel engine (as seen in, for example, https://store.steampowered.com/app/1200720/MakingLovers/) demands that the upstream filter tries to connect with a MPEG format type. Then it memorizes the resolution, rejects the connection, and expects upstream to try RGB32 or RGB24 instead. It also passes an empty string as filename, and demands this exact error code. I have no idea why. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56491 -- v5: quartz: Fix memory leak on failure path. quartz/tests: Test the new error codes. quartz: Fix error code on empty filename. quartz/tests: Test that compressed formats are offered for MPEGs. winegstreamer: Reduce CLSID_decodebin_parser merit, so the MPEG splitter is chosen instead for MPEGs. winegstreamer: Delete now-meaningless wg_parser_type enum. winegstreamer: Use decodebin instead of wavparse. winegstreamer: Create decodebin instead of avidemux. https://gitlab.winehq.org/wine/wine/-/merge_requests/5419

4 11

[PATCH 0/1] MR5452: winegstreamer: Try to handle broken IStream_Stat implementation in WM reader OpenStream().
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5452

4 6

[PATCH v4 0/1] MR5188: Draft: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows.
by Tim Clem (＠tclem) 28 May '24

28 May '24

This is a change from the default behavior in macdrv for as long as it's existed, as far as I can tell. Previously, gaining a dock icon was a one-way path. However, that doesn't jive with the way taskbar entries work on Windows; if an app has no windows, it doesn't appear in the taskbar. This patch attempts to remedy cases where an app winds up with superfluous dock icons for exe's that no longer have windows (looking at you, basically every launcher and Steam). The major concern I can see with this is that if an app closes all of its windows but does not exit, there will be no indication that it is still running. Two thoughts on that: 1. That *should* be an anomalous case, such as the app hanging on exit. 2. Effectively the same behavior would happen on Windows. I would love to hear any other thoughts about this change. I'm open (though I would not prefer it) to defaulting the registry key to false if that would alleviate any concerns. -- v4: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

2 2

[PATCH 0/1] MR5467: ntdll: Return STATUS_NO_YIELD_PERFORMED from NtYieldExecution() on Linux if no yield was performed.
by Paul Gofman (＠gofman) 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5467

3 3

[PATCH 0/3] MR5462: Ucrtbase's stderr is now always unbuffered.
by eric pouech (＠epo) 28 May '24

28 May '24

Starting with late Windows 10 version, in ucrtbase, stderr is now unbuffered whatever the type of the underlying fd (previously, native only set it to unbuffered when attached to character fd (console, NUL...)). This serie adds also tests for msvcrt & ucrtbase to show the discrepancies. Note: ucrtbase's tests also include a reversed engineered structure layout for FILE. _get_stream_buffer_pointers already gives base, ptr and cnt, and toying with setvbuf gave easily the rest of the fields. Didn't spend time in guessing the flags meaning: which look different from msvcrt's. Related to https://bugs.winehq.org/show_bug.cgi?id=56459 @piotr: I can share the details (the access to the test result in the bug report is limited). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5462

3 7

[PATCH 0/1] MR5296: mf/session: Keep previously allocated sample with the transform streams.
by Rémi Bernon 28 May '24

28 May '24

When using a video sample allocator, the session will allocate samples from it, then try to get some output from a transform, and if there's no output to be pulled, release the sample immediately. This will trigger the sample allocator notify callback, which will then trigger another try at pulling samples, ending up in a callback loop that can starve other working threads. Another option here would be to keep the last returned status, and only re-try to pull samples from the allocator notify callback if we previously failed to process output because of a failed allocation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5296

3 10

[PATCH 0/1] MR5431: Draft: wpcap: Load libpcap dynamically.
by Aida Jonikienė 28 May '24

28 May '24

Based on a staging patch by André Zwing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5431

4 7

[PATCH 0/1] MR5439: winegstreamer: Give each stream its own stream queue
by Brendan McGrath (＠redmcg) 28 May '24

28 May '24

This fixes a latency issue with audio, particular when played with 4k video. With a single queue, only one sample request can be processed at a time. So, for example, if a video sample takes 40ms to be delivered, then all pending audio samples will be delayed 40ms. This can lead to the audio PTS lagging the presentation clock and being dropped. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5439

5 15