May 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v3 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Zhiyi Zhang wrote: > I meant the commit message subject, not the merge request subject. You > can use 'git commit --amend' and then force push. > And please squash those two patches into one. Also, https://bugs.winehq.org/show_bug.cgi?id=56485 is the wrong link. Please delete it from this MR. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66779

1 0

Re: [PATCH v3 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Sam Joan Roque-Worcel wrote: > Ah! Thank you! I've added that in there now. Thank you for the reminder. I meant the commit message subject, not the merge request subject. You can use 'git commit --amend' and then force push. And please squash those two patches into one. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66777

1 0

Re: [PATCH v3 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

@zhiyi I've addressed your feedback and rebased the branch, PR re-up :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66773

1 0

Re: [PATCH v2 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

On Wed Apr 3 09:52:58 2024 +0000, Sam Joan Roque-Worcel wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/5427/diffs?diff_id=108367&start_sha=a41a4147bacc2bd3a64d582fb8918630ff795f1d#1309fd48153be56cdd4228d6e4bc8022a837b2de_39_39) Good spotting! No worries, thank you for taking the time to review it! I've changed the value to 17 :thumbsup: -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66770

1 0

Re: [PATCH v2 0/1] MR5427: win32u: Make SCROLL_MIN_THUMB larger.
by Sam Joan Roque-Worcel (＠Joan) 28 May '24

28 May '24

On Thu Apr 4 08:24:18 2024 +0000, Zhiyi Zhang wrote: > Please change the subject to "win32u: Make SCROLL_MIN_THUMB larger." and > add a "Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54759" in the > commit message body. Other than that, this looks good to me. Thanks for > looking into this. Ah! Thank you! I've added that in there now. Thank you for the reminder. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5427#note_66769

1 0

Re: [PATCH v2 0/2] MR5435: wined3d: Require GLSL 1.20 support. - approved
by Jan Sikorski (＠jsikorski) 28 May '24

28 May '24

This merge request was approved by Jan Sikorski. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5435

1 0

[PATCH v3 0/5] MR5397: widl: Add support for structures.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

-- v3: widl: Add support for VT_USERDEFINED to SLTG typelib generator. widl: Properly align name table entries. widl: Add support for structures. widl: Add more traces. widl: Use generic 'struct sltg_data' for collecting data. https://gitlab.winehq.org/wine/wine/-/merge_requests/5397

4 14

[PATCH 0/5] MR5422: win32u: Simplify virtual desktop mode by reporting all sources as detached.
by Rémi Bernon 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5422

2 6

[PATCH 0/1] MR5436: win32u: Replace sprintf with snprintf to avoid deprecation warnings on macOS.
by Brendan Shanks (＠bshanks) 28 May '24

28 May '24

The call in freetype.c:expand_mac_font() would be a good candidate for asprintf(), but I'm planning to send a patch soon to remove that resource-fork font extraction anyway. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5436

3 12

Re: [PATCH v2 0/2] MR5435: wined3d: Require GLSL 1.20 support.
by Elizabeth Figura (＠zfigura) 28 May '24

28 May '24

FWIW, gitlab claims that a fast-forward merge is not possible despite there being no intervening commits to the relevant files. I've observed this behaviour on other merge requests as well. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5435#note_66733

1 0