May 2024 - Wine-gitlab - list.winehq.org

[PATCH v2 0/2] MR5044: ntdll: Fix some threadpool races.
by Paul Gofman (＠gofman) 10 Jul '24

10 Jul '24

That seems to fix some (difficult to reproduce) crashes in EA Desktop / CEF, usually on shutdown but sometimes during starting up. Currently TpSetWait can set (or clear) the event, while waitqueue_thread_proc() gets woken from NtWaitForMultipleObjects by previously set wait object and call the callback as if new set (or cleared) wait object is signaled. The crashes I was reproducing were always happening when RtlDeregisterWaitEx call is racing with waking the wait and calling the callback. -- v2: ntdll: Make sure wakeups from already unset events are ignored in waitqueue_thread_proc(). https://gitlab.winehq.org/wine/wine/-/merge_requests/5044

3 5

[PATCH 0/7] MR3606: winegstreamer: Introduce a new wg_source internal interface.
by Rémi Bernon 10 Jul '24

10 Jul '24

This is the first batch of a series implementing faster media source resolution required to workaround an Unreal Engine race condition present in some games, and deterministic stream ordering that decodebin / parsebin cannot provide, which is required to expose the streams in native order, for compatibility in several other applications. I pushed the full series as a branch here: https://gitlab.winehq.org/rbernon/wine/-/commits/mr/wg-source-part-one Note that this full series is also a first step in the direction of having a simpler demuxer interface, which will be required in the future for compatibility with applications that build MF or DirectShow pipelines directly and expect the relevant components to behave as a demuxer and expose compressed media types. For now it only delays the use of wg_parser to whenever the media source is started, and matches the non-ordered streams using their media types and tags. This is a best effort solution but I don't think we can do much better for the moment. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3606

5 29

[PATCH v2 0/7] MR5138: winegstreamer: Support and expose generic audio/video MFT decoders.
by Rémi Bernon 10 Jul '24

10 Jul '24

-- v2: winegstreamer: Expose the generic video decoder transform. winegstreamer: Introduce a generic audio decoder transform. winegstreamer: Rename aac_decoder to audio_decoder. winegstreamer: Translate generic unknown audio / video media types. winegstreamer: Support generic audio / video unknown formats. winegstreamer: Call gst_video_info_from_caps for all video formats. winegstreamer: Call gst_audio_info_from_caps for all audio formats. https://gitlab.winehq.org/wine/wine/-/merge_requests/5138

3 12

[PATCH 0/1] MR5619: win32u: Use FT_LOAD_PEDANTIC on first load try in freetype_get_glyph_outline().
by Paul Gofman (＠gofman) 08 Jul '24

08 Jul '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5619

4 9

[PATCH 0/7] MR5388: Draft: RFC: WGL_ARB_pixel_format logic in opengl32
by Alexandros Frantzis (＠afrantzis) 04 Jul '24

04 Jul '24

As mentioned in https://gitlab.winehq.org/wine/wine/-/merge_requests/5264, the next step for OpenGL in the Wayland driver is support for WGL_ARB_pixel_format. It seems possible, at least in theory, to move a large part of the logic involved in this extension outside the drivers for common use by all of them (or ones that want to opt-in). The goal of this RFC MR is, through experimentation and discussion/feedback, evaluate: 1. Whether making such functionality available outside the drivers (likely in an opt-in manner to begin with) is a productive way forward, or the complexity and platform specific decisions favor the current per-driver approach. 2. If we think that (1) is a worthy goal, what's the best mechanism to achieve it. Note that the focus of this MR is currently on being a proof-of-concept, rather providing ready-for-detailed-review code (although I have done my best to keep the code decent). This MR currently (roughly in commit order): * Introduces a new wgl driver callback to allow drivers to provide to opengl32/unix a list of formats and many details about them. * Uses the information in that list to implement wglGetPixelFormatAttrib*. * Uses the information in that list plus format sorting rules from WineX11 (effectively GLX rules plus tweaks) to implement wglChoosePixelFormatARB. * Implements the get_pixel_formats callback for the Wayland driver. * Hacks the get_pixel_formats callback for WineX11, and to allow me to run some experiments to compare the output of native WineX11 and get_pixel_formats-WineX11. In the admittedly not too many games I tried the sort order is the same, so at least that's encouraging. My thoughts and notes so far: * Using this approach for wglGetPixelFormatAttrib* works well, and we can also implement wglDescribePixelFormat in this way. * It's not at all clear what the "right" sorting rules are for wglChoosePixelFormatARB. * WineX11 uses GLX + tweaks (e.g., changes depth sorting). This means that larger formats tend to be preferred, at least according to the GLX spec. For example, asking for a r5, g6, b5 in the attributes is supposed to give back rgb888 (or even higher if available) as the top format in the list. Interestingly, and to confuse things even more, I haven't been able to make GLX return non-888(8) configs at all to actually test this more, so perhaps that's what saves it here? However, eglChooseConfig works similarly and there I was able to verify this behavior (e.g., got a nice surprise 10-bit format when asking for 5551 :)). * Winemac has its own custom logic. * Mesa's WGL implementation uses a different approach, closer to Wine's normal (wgl)ChoosePixelFormat, where proximity to the target format is strongly rewarded (so it seems asking for r5g6b5 is much more likely to actually get you that). * Of course, the "gold standard" here would be to try to infer and use the rules used by some windows driver. Looking forward to thoughts/feedback! -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5388

3 14

[PATCH v3 0/10] MR5055: winegstreamer: Support input video frame padding and cropping.
by Rémi Bernon 04 Jul '24

04 Jul '24

On the client side, frame aperture may be included or omitted. This can be used to include or drop the frame padding, and the VideoProcessor MFT supports it. On GStreamer side, we can only use the unpadded frame size in the caps, because this is how decoders work, and padding needs to be added as a property of the input/output video buffers. Then, frame size needs to be adjusted to be consistent between input and output, and any difference considered as extra padding to be added on one side or the other. -- v3: winegstreamer: Respect video format padding for input buffers too. winegstreamer: Exclude padding from wg_format video frame size. winegstreamer: Use video info stride in buffer meta rather than videoflip. winegstreamer: Use a new wg_video_buffer_pool class to add buffer meta. winegstreamer: Update the output_format when stream format changes. winegstreamer: Pass optional GstVideoInfo to read_transform_output_data. winegstreamer: Split read_transform_output_data in two helpers. winegstreamer: Introduce a new sample_needs_copy_buffer helper. winegstreamer: Introduce a new sample_set_flags_from_buffer helper. mf/tests: Add more video processor tests with aperture. https://gitlab.winehq.org/wine/wine/-/merge_requests/5055

3 15

[PATCH 0/2] MR4601: winegstreamer: Order output pins based on MPEG system header.
by Anton Baskanov (＠baskanov) 02 Jul '24

02 Jul '24

Fixes in-game video playback in Earth 2150. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4601

5 10

[PATCH 0/39] MR5615: Draft: winegstreamer: Convert media type to GstCaps directly instead of through an internal representation.
by Rémi Bernon 01 Jul '24

01 Jul '24

This saves ~1500 LoC, and at the same time allows mapping arbitrary long codec data back and forth GstCaps, which will be required to support arbitrary compressed formats. We can then for instance expose unknown codecs as Wine-specific subtypes, expose generic decoders and pass the backend GstCaps serialized in the codec data. It makes the code simpler by unifying all frontend mappings and only requiring mapping between GstCaps and a unified set of formats. Mapping between IMFMediaType and the AM_MEDIA_TYPE formats is done using the standard MF functions and are tested and validated in mfplat tests. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/5615

3 7

[PATCH v2 0/1] MR5013: msi: Properly select first feature
by Fabian Maurer (＠DarkShadow44) 30 Jun '24

30 Jun '24

We need to select the first feature when all controls are created, otherwise they are not properly updated Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56290 -- v2: msi: Properly select first feature https://gitlab.winehq.org/wine/wine/-/merge_requests/5013

3 4

[PATCH v4 0/4] MR5759: comctl32 & user32: Mark radio buttons at selected when focused
by Fabian Maurer (＠DarkShadow44) 30 Jun '24

30 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56109 -- v4: user32: Send parent BN_CLICKED notification when a radio button get focused comctl32: Send parent BN_CLICKED notification when a radio button get focused user32/tests: Add tests for radio button WM_SETFOCUS comctl32/tests: Add tests for radio button WM_SETFOCUS https://gitlab.winehq.org/wine/wine/-/merge_requests/5759

3 6