May 2024 - Wine-gitlab - list.winehq.org

[PATCH v3 0/3] MR5740: Inlcude updates
by Alistair Leslie-Hughes (＠alesliehughes) 29 May '24

29 May '24

Two patches to add two new interfaces and one to fix an existing one. -- v3: include: Correct IRowsetNotify HROW parameter type include: Add IPreviewHandler* interfaces include: shtypes.idl - Add LOGFONTA/W typedef. https://gitlab.winehq.org/wine/wine/-/merge_requests/5740

2 3

Re: [PATCH v6 0/1] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

1 0

Re: [PATCH v4 0/7] MR5747: win32u: Introduce a wrapper to flush window surfaces. - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5747

1 0

Re: [PATCH v4 0/3] MR5736: win32u: Prefer properties from Vulkan over fake ones. - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5736

1 0

Re: [PATCH v3 0/5] MR5745: wined3d: Remove miscellaneous unused definitions, part 3/4. - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5745

1 0

Re: [PATCH v6 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values - approved
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727

1 0

Re: [PATCH v2 0/2] MR5740: Inlcude updates
by Alexandre Julliard (＠julliard) 29 May '24

29 May '24

Alexandre Julliard (@julliard) commented about include/shobjidl.idl: > + LONG lfWidth; > + LONG lfEscapement; > + LONG lfOrientation; > + LONG lfWeight; > + BYTE lfItalic; > + BYTE lfUnderline; > + BYTE lfStrikeOut; > + BYTE lfCharSet; > + BYTE lfOutPrecision; > + BYTE lfClipPrecision; > + BYTE lfQuality; > + BYTE lfPitchAndFamily; > + WCHAR lfFaceName[LF_FACESIZE]; > + } LOGFONTW, *PLOGFONTW, *LPLOGFONTW; > +cpp_quote("#endif /* _WINGDI_ */") > + It looks like this belongs in shtypes.idl. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5740#note_71685

1 0

Re: [PATCH 0/1] MR5719: vbscript: fix test error clear
by Jacek Caban (＠jacek) 29 May '24

29 May '24

It looks good, but please use the canonical commit message, something like: "vbscript/tests: Fix error clear call." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5719#note_71681

1 0

[PATCH v5 0/1] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 29 May '24

29 May '24

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v5: win32u: Implement EVENT_SYSTEM_FOREGROUND. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

3 2

[PATCH v4 0/2] MR2853: win32u: Implement EVENT_SYSTEM_FOREGROUND
by Esme Povirk (＠madewokherd) 29 May '24

29 May '24

I expect this is going to be tricky to get in. I ran into the following issues: * test_ShowWindow behaves very strangely on Windows. It seems this isn't typical behavior, and is caused by an interaction with test_SetFocus, but I'm not sure exactly what it does to the thread state that causes this. * Many of the SetWindowPos flag combinations tested don't actually show the window on Windows, therefore they don't send EVENT_SYSTEM_FOREGROUND. I was able to reproduce this with a stand-alone test, so it seems to be normal behavior. * Windows can show a window without activating it, and Wine on X11 can't do that reliably for managed windows. * There are a couple of cases where Windows sends an event and Wine doesn't. I figure it's OK to not cover every case, but I can go back and investigate those if needed. This interacts with https://gitlab.winehq.org/wine/wine/-/merge_requests/2314, in that the tests don't really test much without it. I applied that MR for my own testing. -- v4: user32: Run tests that notice focus changes early. win32u: Implement EVENT_SYSTEM_FOREGROUND. https://gitlab.winehq.org/wine/wine/-/merge_requests/2853

4 10