May 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR5721: wow64: In wow64_NtSetInformationToken forward TokenIntegrityLevel
by Jinoh Kang (＠iamahuman) 28 May '24

28 May '24

On Mon May 27 23:57:31 2024 +0000, Fabian Maurer wrote: > Alright, updated @DarkShadow44 you also have to translate 32bit struct parameter to 64bit before passing to native. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5721#note_71414

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > struct location where; > unsigned int ignore : 1; > unsigned int defined : 1; > + unsigned int defined_in_import : 1; What about decoupling this from the definition status? Something like `is_imported`? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71400

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/typetree.c: > error_loc("type %s already defined at %s:%d\n", type->name, type->where.input_name, type->where.first_line ); > > type->defined = TRUE; > + init_location(&type->where, NULL, NULL); It would be better to pass the explicit token location from the parser instead of relying on the implicit global last location. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71399

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/widltypes.h: > > struct location where; > > - unsigned int declonly : 1; > + /* Should we define the UDT in this var, when writing a header? */ > + bool define; This is the first and only use of `bool` in widl. Later, you're also introducing a new `unsigned int :1` field elsewhere. I think something like `is_definition` is also more appropriate for an object property. Same below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71398

1 0

Re: [PATCH v2 0/6] MR5724: widl: Various fixes.
by Rémi Bernon 28 May '24

28 May '24

Rémi Bernon (@rbernon) commented about tools/widl/parser.y: > tVOID { $$ = type_new_void(); } > | base_type { $$ = $1; } > | enumdef { $$ = $1; } > - | tENUM aIDENTIFIER { $$ = type_new_enum($2, current_namespace, FALSE, NULL); } > + | tENUM typename { $$ = type_new_enum($2, current_namespace, FALSE, NULL); } > | structdef { $$ = $1; } > - | tSTRUCT aIDENTIFIER { $$ = type_new_struct($2, current_namespace, FALSE, NULL); } > + | tSTRUCT typename { $$ = type_new_struct($2, current_namespace, FALSE, NULL); } > | uniondef { $$ = $1; } > - | tUNION aIDENTIFIER { $$ = type_new_nonencapsulated_union($2, current_namespace, FALSE, NULL); } > + | tUNION typename { $$ = type_new_nonencapsulated_union($2, current_namespace, FALSE, NULL); } > | tSAFEARRAY '(' type ')' { $$ = make_safearray($3); } > | aKNOWNTYPE { $$ = find_type_or_error(current_namespace, $1); } > ; As you're changing tabs into space, could you fix them in the entire `unqualified_type` rule? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724#note_71397

1 0

Re: [PATCH 0/1] MR5720: wineps.drv: Only merge dmDefaultSource member of devmodes when a slot is found.
by Huw Davies (＠huw) 28 May '24

28 May '24

We'll want to keep both copies of `merge_devmode()` in sync, so please combine these two commits into one. Also, the subject of the commit message seems to have word-wrapped - please keep it as a single line. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5720#note_71393

1 0

Re: [PATCH 0/2] MR5729: Fix SQLSetConnectOptionW prototype - approved
by Hans Leidekker (＠hans) 28 May '24

28 May '24

This merge request was approved by Hans Leidekker. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5729

1 0

Re: [PATCH v3 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Sun May 26 17:37:57 2024 +0000, Nikolay Sivov wrote: > I think this is would be better if done in para_set_fmt(). Instead of 32 > please use MAX_TAB_STOPS or ARRAY_SIZE(). Thanks, updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71383

1 0

Re: [PATCH 0/3] MR5710: win32u: Get rid of the UpdatedDisplayDevices force parameter. - approved
by Zhiyi Zhang (＠zhiyi) 28 May '24

28 May '24

This merge request was approved by Zhiyi Zhang. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5710

1 0

Re: [PATCH v3 0/1] MR5727: riched20: In EM_SETPARAFORMAT protect against out of bound cTabStop values
by Fabian Maurer (＠DarkShadow44) 28 May '24

28 May '24

On Sun May 26 17:37:57 2024 +0000, Nikolay Sivov wrote: > It makes more sense to test EM_GET* results here. Thanks, updated -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5727#note_71382

1 0