May 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/4] MR5458: widl: Add support for interfaces to SLTG typelib generator.
by Dmitry Timoshkov (＠dmitry) 28 May '24

28 May '24

Adding support for interfaces implies adding support for function descriptions, so the patch is a bit large. I didn't manage to create an .idl with a function outside of an interface, so I couldn't test it separately. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5458

4 7

[PATCH v6 0/1] MR5188: Draft: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows.
by Tim Clem (＠tclem) 28 May '24

28 May '24

This is a change from the default behavior in macdrv for as long as it's existed, as far as I can tell. Previously, gaining a dock icon was a one-way path. However, that doesn't jive with the way taskbar entries work on Windows; if an app has no windows, it doesn't appear in the taskbar. This patch attempts to remedy cases where an app winds up with superfluous dock icons for exe's that no longer have windows (looking at you, basically every launcher and Steam). The major concern I can see with this is that if an app closes all of its windows but does not exit, there will be no indication that it is still running. Two thoughts on that: 1. That *should* be an anomalous case, such as the app hanging on exit. 2. Effectively the same behavior would happen on Windows. I would love to hear any other thoughts about this change. I'm open (though I would not prefer it) to defaulting the registry key to false if that would alleviate any concerns. -- v6: winemac.drv: Hide app's dock icon when it wouldn't have a taskbar item on Windows. https://gitlab.winehq.org/wine/wine/-/merge_requests/5188

2 2

Re: [PATCH v2 0/1] MR5447: fonts: Add U+FF0B U+25BC U+2715, fix visual issue in Notepad++
by Loïc Rebmeister 28 May '24

28 May '24

On Sun Apr 7 09:32:45 2024 +0000, Sam Joan Roque-Worcel wrote: > Hmm I thought the tests I was getting were flakey, but it seems that my > changes here are causing failing tests. I may ask in IRC if anyone can > think of a better approach. I don't see why adding them only to a new MS Gothic font stub with only 3 symbol wouldn't work? If peoples add the real MS Gothic everything should work fine, there is no reason for it to not work. Especially since most peoples use `winetricks` and it's already used to override existing stub fonts. Adding to Tahoma seems fine as a workaround because Tahoma doesn't have those, but upstream isn't a fan of MR that push wine away from Win32 like behavior, so it may delay this being merged. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5447#note_67258

1 0

[PATCH 0/6] MR5470: win32u: Get rid of the window surface recursive mutex.
by Rémi Bernon 28 May '24

28 May '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5470

2 8

Re: [PATCH v4 0/5] MR5464: mf/tests: Check that D3D aware attribute has no effect on the topology.
by Rémi Bernon 28 May '24

28 May '24

I see, and indeed the presence of a device manager exposed through the sink services apparently changes something. I'll add some more tests for that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5464#note_67253

1 0

Re: [PATCH v4 0/5] MR5464: mf/tests: Check that D3D aware attribute has no effect on the topology.
by Nikolay Sivov (＠nsivov) 28 May '24

28 May '24

I don't know how much this test actually shows. Device manager is provided by the sink. Topology loader then is documented to set this device manager to the transforms on the video branch. There is MF_TOPOLOGY_DXVA_MODE attribute that supposedly controls that. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5464#note_67239

1 0

Re: [PATCH v3 0/2] MR5314: windows.ui: Add stub implementations of uiviewsettings and inputpanestatics
by Vijay Kiran Kamuju (＠infyquest) 28 May '24

28 May '24

uwp windows apps use the uiviewsettings to check if its mouse mode or touch mode. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5314#note_67237

1 0

Re: [PATCH v4 0/5] MR5464: mf/tests: Check that D3D aware attribute has no effect on the topology.
by Rémi Bernon 28 May '24

28 May '24

Couple of minor updates to fix leaks and debug code leftovers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5464#note_67235

1 0

[PATCH v2 0/2] MR5460: mfmediaengine: Allow decoders to be resolved before optional effect nodes.
by Rémi Bernon 28 May '24

28 May '24

Otherwise pipelines fail to resolve when media source outputs compressed samples and applications have inserted optional effects (such as VRChat with AVPro player). Note that the topology loader doesn't currently support MF_CONNECT_AS_OPTIONAL, although the connection succeeds in the the cases I've seen. -- v2: mfmediaengine: Allow decoder / converter to be resolved between topology nodes. mfmediaengine/tests: Test that effects allow converters between them. https://gitlab.winehq.org/wine/wine/-/merge_requests/5460

2 4

[PATCH v2 0/3] MR5462: Ucrtbase's stderr is now always unbuffered.
by eric pouech (＠epo) 28 May '24

28 May '24

Starting with late Windows 10 version, in ucrtbase, stderr is now unbuffered whatever the type of the underlying fd (previously, native only set it to unbuffered when attached to character fd (console, NUL...)). This serie adds also tests for msvcrt & ucrtbase to show the discrepancies. Note: ucrtbase's tests also include a reversed engineered structure layout for FILE. _get_stream_buffer_pointers already gives base, ptr and cnt, and toying with setvbuf gave easily the rest of the fields. Didn't spend time in guessing the flags meaning: which look different from msvcrt's. Related to https://bugs.winehq.org/show_bug.cgi?id=56459 @piotr: I can share the details (the access to the test result in the bug report is limited). -- v2: msvcrt: Let stderr be always be unbuffered. ucrtbase/tests: Add tests for checking buffering state of standard streams. msvcrt/tests: Add tests for check buffering state of standard streams. https://gitlab.winehq.org/wine/wine/-/merge_requests/5462

2 4