June 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/2] MR5858: odbccp32: Look at the Setup key to find the driver of ODBC config functions.
by Alistair Leslie-Hughes (＠alesliehughes) 17 Jun '24

17 Jun '24

We need to look at the Setup key for the driver, as it can be different compare to the actually driver. For example, mysql uses the same Setup file to configure both the Ascii/Unicode vession but has a different file for the actual ODBC functions. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5858

2 2

Re: [PATCH v2 0/7] MR5833: win32u: Split window surface creation functions from windowing logic.
by Rémi Bernon 17 Jun '24

17 Jun '24

On Mon Jun 17 07:53:48 2024 +0000, darkblaze69 wrote: > With this MR since 71ff81b apps don't launch with wayland driver, > showing these errors after some timeouts. > So we can't use wayland now. > ``` > 0138:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 > "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread > 0138, blocked by 0134, retrying (60 sec) > 0144:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 > "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread > 0144, blocked by 0134, retrying (60 sec) > 014c:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 > "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread > 014c, blocked by 0134, retrying (60 sec) > ``` Sorry about that, https://gitlab.winehq.org/wine/wine/-/merge_requests/5857 should fix the problem. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5833#note_73393

1 0

[PATCH 0/1] MR5857: winewayland: Avoid crashing when the dummy window surface is used.
by Rémi Bernon 17 Jun '24

17 Jun '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56840 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5857

1 1

[PATCH v4 0/1] MR5231: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list.
by Aida Jonikienė 17 Jun '24

17 Jun '24

Overriding the SDL_VIDEODRIVER variable (for Wayland support as an example) on the Linux side can lead to some games under Wine failing to load (so treat that variable as special). -- v4: ntdll: Add SDL_AUDIO*/SDL_VIDEO* to the special variables list. https://gitlab.winehq.org/wine/wine/-/merge_requests/5231

1 1

[PATCH 0/2] MR5856: ntdll: Fixes for RtlQueryRegistryValues with multi-strings.
by Alex Henrie (＠alexhenrie) 17 Jun '24

17 Jun '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/5856

2 2

[PATCH 0/1] MR5855: winex11: Fix chinese path failure of conversion.
by Haoyang Chen (＠chenhaoyang) 17 Jun '24

17 Jun '24

Chinese word is negative, the high 4 bits are signed, right shift will remain signed，high 4 bits is filled by 1. Finally it will exceed the boundaries of hax_table. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5855

2 1

[PATCH 0/1] MR5854: win32u: get_char_dimensions set height to 1 when failed
by Fan WenJie (＠fanwenjie) 17 Jun '24

17 Jun '24

Signed-off-by: Fan WenJie <fanwj(a)mail.ustc.edu.cn> when get_char_dimensions failed, width not set, width may be undefined value and cause undefined behaviour -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5854

2 1

Re: [PATCH v2 0/7] MR5833: win32u: Split window surface creation functions from windowing logic.
by darkblaze69 (＠darkblaze69) 16 Jun '24

16 Jun '24

With this MR since 71ff81b apps don't launch with wayland driver, showing these errors after some timeouts. So we can't use wayland now. ``` 0138:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread 0138, blocked by 0134, retrying (60 sec) 0144:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread 0144, blocked by 0134, retrying (60 sec) 014c:err:sync:RtlpWaitForCriticalSection section 7BF9B2E0 "../wine/dlls/ntdll/loader.c: loader_section" wait timed out in thread 014c, blocked by 0134, retrying (60 sec) ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5833#note_73375

1 0

[PATCH v17 0/7] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 16 Jun '24

16 Jun '24

This MR adds support for creating file mapping objects backed by large pages on Linux, by making the following changes: ## wineserver * On Linux, `create_temp_file` will first attempt to use memfds as the backing fd. If it fails, it'll return to the current codepath, creating a temporary file in either the server or config directory. * The created memfd will be sealed against writes, if the caller requesting the appropriate page protection flags. * This removes the requirement that FDs be only created on filesystems/directories that aren't `noexec`. * In the server method `create_mapping` , if large pages have been requested by the caller, hold that the calling thread's token holds `SeLockMemoryPrivilege` . * Additionally, add `SeLockMemoryPrivilege` to the list of privileges enabled for the Administrator. ## `ntdll` * Add `virtual_get_min_large_page_size` and its exported wrapper `wine_unix_get_min_large_page_size`. * On Linux, the minimum page size is determined by going through `/sys/kernel/mm/hugepages`. If hugepage support was not detected, `STATUS_NOT_SUPPORTED` is returned instead. On other platforms, the older hard-coded value of 2\*1024\*1024 is returned instead. * `NtCreateSection` will validate certain parameters if large pages are requested. Specifically, it will return STATUS_INVALID_PARAMETER if the requested mapping is not anonymous/unnamed, or the size is not a multiple of the minimum supported page size. ## `kernelbase` * `GetLargePageMinimum` will use `wine_unix_get_min_large_page_size`. ## `kernel32/tests` * Add new test test_large_page_file_mapping, which validates privilege enforcements and parameter validation while creating large pages backed file mapping obejcts. The tests are skipped if `GetLargePageMinimum` returns 0. -- v17: ntdll: mlock mapped pages for views created with SEC_LARGE_PAGES. kernel32: Add tests for large page mapping support. ntdll: Validate parameters to NtCreateSection if large pages are requested. server: Use memfd to back anonymous mappings on Linux. kernelbase: Implement GetLargePageMinimum by returning the value of LargePageMinimum in _KUSER_SHARED_DATA. server: Set LargePageMinimum in _KUSER_SHARED_DATA on Linux. server: Require SeLockMemoryPrivilege to create large page mappings. https://gitlab.winehq.org/wine/wine/-/merge_requests/5769

2 7

[PATCH 0/1] MR5853: user32/tests: Fix spurious "Failed sequence" reports on Windows.
by Esme Povirk (＠madewokherd) 15 Jun '24

15 Jun '24

It turns out that message sequences with "wine_only" messages, although they don't cause a test failure on Windows, do cause `ok_sequence_` to log a failure, so that it dumps the sequence. We need `ok_sequence_` to treat these as skippable messages on Windows so that it ignores the failure to match them. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5853

2 1