June 2024 - Wine-gitlab - list.winehq.org

Re: [PATCH v2 0/1] MR5778: wineps.drv: Call ResetDCW() to update Devmode in the Unix interface. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5778

1 0

Re: [PATCH v7 0/7] MR5666: d3dx9: More refactoring in preparation for shared code. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5666

1 0

Re: [PATCH v2 0/1] MR5772: windowscodecs: Add conversions from PixelFormat32bppBGRA->PixelFormat16bppBGRA5551 and a test. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5772

1 0

Re: [PATCH v3 0/4] MR5746: coremessaging: Add CreateDispatcherQueueController() stub. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5746

1 0

Re: [PATCH v4 0/6] MR5724: widl: Various fixes. - approved
by Alexandre Julliard (＠julliard) 03 Jun '24

03 Jun '24

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5724

1 0

[PATCH 0/1] MR5777: win32u: Limit GDI object generation by 127 for a 64-bit build.
by Dmitry Timoshkov (＠dmitry) 03 Jun '24

03 Jun '24

I have a .Net application that during handling of WM_NCPAINT for one of its windows genarates exception "Arithmetic operation resulted in an overflow.". This happens only in a 64-bit prefix and only for WPARAM that contains an HRGN handle with value over than 0x7fffffff. The application does the following: public static IntPtr GetNativeDC(Message m, IntPtr handle) { if (m.Msg != 0x85) // WM_NCPAINT { return NUser32.GetWindowDC(handle); } int num = 0x200013; // DCX_VALIDATE | DCX_CLIPSIBLINGS | DCX_CACHE | DCX_WINDOW IntPtr intPtr = IntPtr.Zero; IntPtr wParam = m.WParam; if (wParam.ToInt32() != 1) { num |= 0x80; // DCX_INTERSECTRGN intPtr = CreateRectRgn(0, 0, 1, 1); CombineRgn(intPtr, wParam, IntPtr.Zero, 5); // RGN_COPY } return NUser32.GetDCEx(handle, intPtr, num); } The exception is generated by wParam.ToInt32(). MSDN description for ToInt32() https://learn.microsoft.com/en-us/dotnet/api/system.intptr.toint32?view=net… states Exceptions OverflowException In a 64-bit process, the value of this instance is too large or too small to represent as a 32-bit signed integer. MSDN also has a reference to ToInt32() source: https://github.com/dotnet/runtime/blob/5535e31a712343a63f5d7d796cd874e563e5… public int ToInt32() { #if TARGET_64BIT return checked((int)_value); #else return (int)_value; #endif } It's not clear why a sign extension may lead to an overflow exception. This patch fixes the problem, and provides a test case that confirms that entry.Generation field of a GDI32 object is limited by 127 on a 64-bit platform, while 32-bit Windows doesn't have such a limitation. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5777

4 5

[PATCH 0/1] MR5778: wineps.drv: Call ResetDCW() to update Devmode in the Unix interface.
by Danyil Blyschak (＠blyss) 03 Jun '24

03 Jun '24

Previously, PSDRV_ResetDC() only updated the devmode contained in the print context, which could cause the devmode in the unix interface to be inconsistent with the print context's devmode. This can cause problems later when PostScript is being outputted, as get_device_caps() in the unix interface would reference this inconsistent devmode. By calling ResetDCW() in PSDRV_ResetDC(), these two devmodes remain in-sync. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5778

4 3

Re: [PATCH v11 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Paul Gofman (＠gofman) 03 Jun '24

03 Jun '24

On Mon Jun 3 16:19:12 2024 +0000, Vibhav Pant wrote: > I'm sorry, what are the "earlier patches" in this context? Also, I was > not entirely sure what the component modified would be, as both > NtCreationSection and CreateFileMapping would be affected by the patch, > which are in different components. Would wineserver be appropriate? Your MR at each moment should be the set of finalized patches. If you are changing something in existing patches you update / replace those without adding new patches. You set the component which your patch is directly modifying. If there is more than one (rare occasion which often means you need to split your patches) you specify higher level component. I'd really suggest to view some commit history for the related components for examples. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5769#note_72236

1 0

Re: [PATCH v11 0/21] MR5769: Add support for large page backed file mapping objects on Linux.
by Vibhav Pant (＠vibhavp) 03 Jun '24

03 Jun '24

On Mon Jun 3 16:19:12 2024 +0000, Paul Gofman wrote: > As a general note, please don't put the changes to earlier patches on > top, just modify the patches. We also start the patch names from the > name of the component the patch is modifying, like: "ntdll: Support xxx > in NtYYY()." It would probably help to look at some merged MRs and > commit history for examples. I'm sorry, what are the "earlier patches" in this context? Also, I was not entirely sure what the component modified would be, as both NtCreationSection and CreateFileMapping would be affected by the patch, which are in different components. Would wineserver be appropriate? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/5769#note_72234

1 0

[PATCH v3 0/6] MR5764: win32u: Create bitmaps for window surface pixels.
by Rémi Bernon 03 Jun '24

03 Jun '24

This should help unifying the interface and get rid of the get_info callback. Later, I think we could create bitmaps over sections shared with some DWM process and/or host compositor. -- v3: win32u: Create a HBITMAP backing the window surface pixels. winex11: Create a HBITMAP for the allocated surface pixels. winex11: Create XImage before initializing the window surface. winex11: Simplify the XSHM extension function calls. win32u: Pass BITMAPINFO and a HBITMAP to window_surface_init. win32u: Move the window surface color bits to the common struct. https://gitlab.winehq.org/wine/wine/-/merge_requests/5764

1 7