July 2024 - Wine-gitlab - list.winehq.org

[PATCH 0/1] MR6181: atl: Only warn in AtlModuleGetClassObject if the class was not found.
by Alex Henrie (＠alexhenrie) 02 Aug '24

02 Aug '24

A warning should only be printed if something went wrong, not every time the function is run. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6181

3 2

[PATCH 0/2] MR6180: gdiplus: Fixes when compiling against wine headers.
by Alistair Leslie-Hughes (＠alesliehughes) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6180

3 3

[PATCH 0/1] MR6179: include: Ensure that x86_64 syscall thunks have a consistent length when built with Clang.
by Brendan Shanks (＠bshanks) 02 Aug '24

02 Aug '24

GCC always assembles `jmp 1f` to `eb 01`, as does Clang when using -O1 or higher optimization. But with -O0, Clang outputs `e9 01 00 00 00`. The `subq $0xb,0x70(%rcx)` line in __wine_syscall_dispatcher relies on `jmp 1f` being 2 bytes. Since Wine defaults to `-g -O2` for `CFLAGS`, this wouldn't show up with a default Clang build. But the FreeBSD `wine-devel` port must override `CFLAGS`, it uses Clang for PE and was crashing on launch. See <https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=280000>. Here are compiler explorer links to see the difference: [PE](https://godbolt.org/z/35TxW8dK9) and [ELF](https://godbolt.org/z/1h3j4c4ja). Adding -O1 to the clang side will make them equivalent. I may also report this as an LLVM bug, it doesn't seem like there's any reason why Clang would prefer the long form at `-O0`. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6179

3 3

[PATCH 0/3] MR6178: ntdll: Use environ/_NSGetEnviron() directly rather than caching it in main_envp.
by Brendan Shanks (＠bshanks) 02 Aug '24

02 Aug '24

Fixes an unpredictable use-after-free crash on launch on macOS. Also, use `_NSGetEnviron()` instead of `environ` in `msv1_0` and `ntdll`. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=57005 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6178

3 4

[PATCH v2 0/1] MR6174: comctl32: Handle WM_GETOBJECT in tab control.
by Esme Povirk (＠madewokherd) 02 Aug '24

02 Aug '24

-- v2: comctl32: Handle WM_GETOBJECT in tab control. https://gitlab.winehq.org/wine/wine/-/merge_requests/6174

4 4

[PATCH v5 0/2] MR6160: comctl32: Fix sorting for listview.
by Jacob Czekalla (＠JacobCzekalla) 02 Aug '24

02 Aug '24

The listview bug is caused by passing the incorrect index to the LISTVIEW_SortItems callers custom compare function. If we pass the copied array indices, which are different because of the sorting, the caller is going to use those indices for their unsorted array which don't match. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=56140 -- v5: comctl32: Fix sorting for listview. comctl32/tests: Add test for listview sorting order. https://gitlab.winehq.org/wine/wine/-/merge_requests/6160

4 10

[PATCH 0/8] MR6177: mshtml: Use JS bindings for more objects.
by Jacek Caban (＠jacek) 02 Aug '24

02 Aug '24

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/6177

3 9

[PATCH v6 0/3] MR4405: gdi32: Implement FixBrushOrgEx according to test.
by Bartosz Kosiorek (＠gang65) 02 Aug '24

02 Aug '24

More information about different Windows versions: https://learn.microsoft.com/en-us/windows/win32/api/winnt/ns-winnt-osversio… Verified with: https://testbot.winehq.org/JobDetails.pl?Key=139906 -- v6: win32u: Fix ExtCreateRegion when parameters are wrong. gdi32/tests: Add wrong parameters ExtCreateRegion tests. gdi32: Implement FixBrushOrgEx according to test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4405

3 4

[PATCH v3 0/1] MR6053: d3dx9/effect: Trace the pass count header field.
by Nikolay Sivov (＠nsivov) 02 Aug '24

02 Aug '24

Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- v3: d3dx9/effect: Document one remaining header field. https://gitlab.winehq.org/wine/wine/-/merge_requests/6053

3 2

[PATCH 0/1] MR6176: sechost: Check both lpServiceName and lpServiceProc for NULL in StartServiceCtrlDispatcher().
by Dmitry Timoshkov (＠dmitry) 02 Aug '24

02 Aug '24

An application I'm working on calls StartServiceCtrlDispatcher() with only lpServiceProc set to NULL in last element. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/6176

3 2